Skip to content

F
Front-End
Unverified Commit 820b0e02 authored by Dan Field's avatar Dan Field Committed by GitHub
Browse files
Options

Avoid overwriting task result for non-leak checkers (#29989)

parent 204eceea
Show whitespace changes
Inline Side-by-side
Showing with 0 additions and 2 deletions
dev/devicelab/lib/framework/framework.dart
View file @ 820b0e02
...@@ -102,8 +102,6 @@ class _TaskRunner { ...@@ -102,8 +102,6 @@ class _TaskRunner {
// TODO(dnfield): remove this special casing after https://github.com/flutter/flutter/issues/29141 is resolved. // TODO(dnfield): remove this special casing after https://github.com/flutter/flutter/issues/29141 is resolved.
if (result is TaskResultCheckProcesses) { if (result is TaskResultCheckProcesses) {
result = TaskResult.failure('This test leaked dart processes'); result = TaskResult.failure('This test leaked dart processes');
} else {
result = TaskResult.success(null);
} }
final bool killed = await killProcess(info.pid); final bool killed = await killProcess(info.pid);
if (!killed) { if (!killed) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

HIAST - GitLab