Unverified Commit 809721d0 authored by Ian Hickson's avatar Ian Hickson Committed by GitHub

Revert "Track number of package dependencies in Flutter" (#20774)

* Revert "Deprecated CupertinoDialog in favor of a new widget called CupertinoP… (#20649)"

This reverts commit 3a4ae280.

* Revert "Feature pesto new recipes (#19415)"

This reverts commit e2f3b3d6.

* Revert "Use markdown table (#20721)"

This reverts commit 82d43b95.

* Revert "Documentation regarding tap gesture callbacks (#20647)"

This reverts commit 3acc2785.

* Revert "Add branch to footer information in flutter docs (#20711)"

This reverts commit 9118d3d7.

* Revert "Performance test cleanup (#20652)"

This reverts commit 1993a673.

* Revert "Track number of package dependencies in Flutter (#20722)"

This reverts commit 03d6f18f.
parent 3a4ae280
......@@ -43,51 +43,24 @@ Future<double> findCostsForFile(File file) async {
return total;
}
Future<double> findCostsForRepo() async {
final Process git = await startProcess(
'git',
<String>['ls-files', '--full-name', flutterDirectory.path],
workingDirectory: flutterDirectory.path,
);
double total = 0.0;
await for (String entry in git.stdout.transform(utf8.decoder).transform(const LineSplitter()))
total += await findCostsForFile(new File(path.join(flutterDirectory.path, entry)));
final int gitExitCode = await git.exitCode;
if (gitExitCode != 0)
throw new Exception('git exit with unexpected error code $gitExitCode');
return total;
}
Future<int> countDependencies() async {
final Process subprocess = await startProcess(
'flutter',
<String>['update-packages', '--transitive-closure'],
workingDirectory: flutterDirectory.path,
);
final List<String> lines = await subprocess.stdout.transform(utf8.decoder).transform(const LineSplitter()).toList();
final int subprocessExitCode = await subprocess.exitCode;
if (subprocessExitCode != 0)
throw new Exception('flutter exit with unexpected error code $subprocessExitCode');
final int count = lines.where((String line) => line.contains('->')).length;
if (count < 2) // we'll always have flutter and flutter_test, at least...
throw new Exception('"flutter update-packages --transitive-closure" returned bogus output:\n${lines.join("\n")}');
return count;
}
const String _kCostBenchmarkKey = 'technical_debt_in_dollars';
const String _kNumberOfDependenciesKey = 'dependencies_count';
const String _kBenchmarkKey = 'technical_debt_in_dollars';
Future<Null> main() async {
await task(() async {
final Process git = await startProcess(
'git',
<String>['ls-files', '--full-name', flutterDirectory.path],
workingDirectory: flutterDirectory.path,
);
double total = 0.0;
await for (String entry in git.stdout.transform(utf8.decoder).transform(const LineSplitter()))
total += await findCostsForFile(new File(path.join(flutterDirectory.path, entry)));
final int gitExitCode = await git.exitCode;
if (gitExitCode != 0)
throw new Exception('git exit with unexpected error code $gitExitCode');
return new TaskResult.success(
<String, dynamic>{
_kCostBenchmarkKey: await findCostsForRepo(),
_kNumberOfDependenciesKey: await countDependencies(),
},
benchmarkScoreKeys: <String>[
_kCostBenchmarkKey,
_kNumberOfDependenciesKey,
],
<String, dynamic>{_kBenchmarkKey: total},
benchmarkScoreKeys: <String>[_kBenchmarkKey],
);
});
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment