Disable post-submit failures (#100308)

7f241ba3 · Kate Lovett · GitHub · b4040c86 · 7f241ba3 · 7f241ba3
Unverified Commit 7f241ba3 authored Mar 17, 2022 by Kate Lovett Committed by GitHub Mar 17, 2022
Show whitespace changes
Inline Side-by-side

Showing with 6 additions and 2 deletions

flutter_goldens_test.dart packages/flutter_goldens/test/flutter_goldens_test.dart +3 -1

skia_client.dart packages/flutter_goldens_client/lib/skia_client.dart +3 -1

No files found.
--- a/packages/flutter_goldens/test/flutter_goldens_test.dart
+++ b/packages/flutter_goldens/test/flutter_goldens_test.dart
@@ -283,7 +283,9 @@ void main() {
          '--work-dir', '/workDirectory/temp',
          '--test-name', 'golden_file_test',
          '--png-file', '/workDirectory/temp/golden_file_test.png',
-          '--passfail',
+          // TODO(Piinks): Re-enable once https://github.com/flutter/flutter/issues/100304
+          // is resolved.
+          //'--passfail',
        ],
        null,
      );

--- a/packages/flutter_goldens_client/lib/skia_client.dart
+++ b/packages/flutter_goldens_client/lib/skia_client.dart
@@ -191,7 +191,9 @@ class SkiaGoldClient {
        .path,
      '--test-name', cleanTestName(testName),
      '--png-file', goldenFile.path,
-      '--passfail',
+      // TODO(Piinks): Re-enable once https://github.com/flutter/flutter/issues/100304
+      // is resolved.
+      //'--passfail',
    ];

    final io.ProcessResult result = await process.run(imgtestCommand);