Skip to content

F
Front-End
Unverified Commit 7e2434c8 authored by Jonah Williams's avatar Jonah Williams Committed by GitHub
Browse files
Options

move semantics inside of opacity animation (#19960)

parent b2eed9a6
Hide whitespace changes
Inline Side-by-side
Showing with 13 additions and 13 deletions
packages/flutter/lib/src/material/popup_menu.dart
View file @ 7e2434c8
...@@ -458,13 +458,19 @@ class _PopupMenu<T> extends StatelessWidget { ...@@ -458,13 +458,19 @@ class _PopupMenu<T> extends StatelessWidget {
), ),
child: new IntrinsicWidth( child: new IntrinsicWidth(
stepWidth: _kMenuWidthStep, stepWidth: _kMenuWidthStep,
child: new SingleChildScrollView( child: new Semantics(
padding: const EdgeInsets.symmetric( scopesRoute: true,
vertical: _kMenuVerticalPadding namesRoute: true,
explicitChildNodes: true,
label: semanticLabel,
child: new SingleChildScrollView(
padding: const EdgeInsets.symmetric(
vertical: _kMenuVerticalPadding
),
child: new ListBody(children: children),
), ),
child: new ListBody(children: children), ),
) ),
)
); );
return new AnimatedBuilder( return new AnimatedBuilder(
...@@ -479,13 +485,7 @@ class _PopupMenu<T> extends StatelessWidget { ...@@ -479,13 +485,7 @@ class _PopupMenu<T> extends StatelessWidget {
alignment: AlignmentDirectional.topEnd, alignment: AlignmentDirectional.topEnd,
widthFactor: width.evaluate(route.animation), widthFactor: width.evaluate(route.animation),
heightFactor: height.evaluate(route.animation), heightFactor: height.evaluate(route.animation),
child: new Semantics( child: child,
scopesRoute: true,
namesRoute: true,
explicitChildNodes: true,
label: semanticLabel,
child: child,
),
), ),
), ),
); );
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

HIAST - GitLab