Unverified Commit 7dd82813 authored by Danny Tuppeny's avatar Danny Tuppeny Committed by GitHub

Remove -j1 to run tools tests concurrently (#22038)

Fixes #21113.
parent 4108240a
...@@ -144,7 +144,6 @@ Future<Null> _runToolTests() async { ...@@ -144,7 +144,6 @@ Future<Null> _runToolTests() async {
await _pubRunTest( await _pubRunTest(
path.join(flutterRoot, 'packages', 'flutter_tools'), path.join(flutterRoot, 'packages', 'flutter_tools'),
enableFlutterToolAsserts: true, enableFlutterToolAsserts: true,
runConcurrently: false,
); );
print('${bold}DONE: All tests successful.$reset'); print('${bold}DONE: All tests successful.$reset');
...@@ -197,13 +196,9 @@ Future<Null> _runCoverage() async { ...@@ -197,13 +196,9 @@ Future<Null> _runCoverage() async {
Future<Null> _pubRunTest( Future<Null> _pubRunTest(
String workingDirectory, { String workingDirectory, {
String testPath, String testPath,
bool runConcurrently = true,
bool enableFlutterToolAsserts = false bool enableFlutterToolAsserts = false
}) { }) {
final List<String> args = <String>['run', 'test', '-rcompact']; final List<String> args = <String>['run', 'test', '-rcompact'];
if (!runConcurrently) {
args.add('-j1');
}
if (!hasColor) if (!hasColor)
args.add('--no-color'); args.add('--no-color');
if (testPath != null) if (testPath != null)
......
...@@ -6,5 +6,5 @@ To run the tests, ensure that no devices are connected, ...@@ -6,5 +6,5 @@ To run the tests, ensure that no devices are connected,
then navigate to `flutter_tools` and execute: then navigate to `flutter_tools` and execute:
```shell ```shell
../../bin/cache/dart-sdk/bin/pub run test -j1 ../../bin/cache/dart-sdk/bin/pub run test
``` ```
...@@ -4,9 +4,8 @@ These tests are not hermetic, and use actual Flutter SDK. ...@@ -4,9 +4,8 @@ These tests are not hermetic, and use actual Flutter SDK.
While they don't require actual devices, they run `flutter_tester` to test While they don't require actual devices, they run `flutter_tester` to test
Dart VM and Flutter integration. Dart VM and Flutter integration.
Some of these tests change the current directory for the process, Use this command to run:
so only one test can be run at a time. Use this command to run:
```shell ```shell
../../bin/cache/dart-sdk/bin/pub run test -j1 ../../bin/cache/dart-sdk/bin/pub run test
``` ```
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment