Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
7dd65c16
Unverified
Commit
7dd65c16
authored
Oct 06, 2022
by
Jenn Magder
Committed by
GitHub
Oct 06, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add bitcode deprecation note for add-to-app iOS developers (#112900)
parent
d440ee82
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
1 deletion
+10
-1
build_ios_framework_module_test.dart
dev/devicelab/bin/tasks/build_ios_framework_module_test.dart
+6
-1
build_ios_framework.dart
...s/flutter_tools/lib/src/commands/build_ios_framework.dart
+4
-0
No files found.
dev/devicelab/bin/tasks/build_ios_framework_module_test.dart
View file @
7dd65c16
...
@@ -87,7 +87,8 @@ Future<void> _testBuildIosFramework(Directory projectDir, { bool isModule = fals
...
@@ -87,7 +87,8 @@ Future<void> _testBuildIosFramework(Directory projectDir, { bool isModule = fals
const
String
outputDirectoryName
=
'flutter-frameworks'
;
const
String
outputDirectoryName
=
'flutter-frameworks'
;
await
inDirectory
(
projectDir
,
()
async
{
await
inDirectory
(
projectDir
,
()
async
{
await
flutter
(
final
StringBuffer
outputError
=
StringBuffer
();
await
evalFlutter
(
'build'
,
'build'
,
options:
<
String
>[
options:
<
String
>[
'ios-framework'
,
'ios-framework'
,
...
@@ -96,7 +97,11 @@ Future<void> _testBuildIosFramework(Directory projectDir, { bool isModule = fals
...
@@ -96,7 +97,11 @@ Future<void> _testBuildIosFramework(Directory projectDir, { bool isModule = fals
'--obfuscate'
,
'--obfuscate'
,
'--split-debug-info=symbols'
,
'--split-debug-info=symbols'
,
],
],
stderr:
outputError
,
);
);
if
(!
outputError
.
toString
().
contains
(
'Bitcode support has been deprecated.'
))
{
throw
TaskResult
.
failure
(
'Missing bitcode deprecation warning'
);
}
});
});
final
String
outputPath
=
path
.
join
(
projectDir
.
path
,
outputDirectoryName
);
final
String
outputPath
=
path
.
join
(
projectDir
.
path
,
outputDirectoryName
);
...
...
packages/flutter_tools/lib/src/commands/build_ios_framework.dart
View file @
7dd65c16
...
@@ -300,6 +300,10 @@ class BuildIOSFrameworkCommand extends BuildFrameworkCommand {
...
@@ -300,6 +300,10 @@ class BuildIOSFrameworkCommand extends BuildFrameworkCommand {
'See https://flutter.dev/docs/development/add-to-app/ios/add-flutter-screen#create-a-flutterengine for more information.'
);
'See https://flutter.dev/docs/development/add-to-app/ios/add-flutter-screen#create-a-flutterengine for more information.'
);
}
}
globals
.
printWarning
(
'Bitcode support has been deprecated. Turn off the "Enable Bitcode" build setting in your Xcode project or you may encounter compilation errors.
\n
'
'See https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes for details.'
);
return
FlutterCommandResult
.
success
();
return
FlutterCommandResult
.
success
();
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment