Unverified Commit 7dd65c16 authored by Jenn Magder's avatar Jenn Magder Committed by GitHub

Add bitcode deprecation note for add-to-app iOS developers (#112900)

parent d440ee82
...@@ -87,7 +87,8 @@ Future<void> _testBuildIosFramework(Directory projectDir, { bool isModule = fals ...@@ -87,7 +87,8 @@ Future<void> _testBuildIosFramework(Directory projectDir, { bool isModule = fals
const String outputDirectoryName = 'flutter-frameworks'; const String outputDirectoryName = 'flutter-frameworks';
await inDirectory(projectDir, () async { await inDirectory(projectDir, () async {
await flutter( final StringBuffer outputError = StringBuffer();
await evalFlutter(
'build', 'build',
options: <String>[ options: <String>[
'ios-framework', 'ios-framework',
...@@ -96,7 +97,11 @@ Future<void> _testBuildIosFramework(Directory projectDir, { bool isModule = fals ...@@ -96,7 +97,11 @@ Future<void> _testBuildIosFramework(Directory projectDir, { bool isModule = fals
'--obfuscate', '--obfuscate',
'--split-debug-info=symbols', '--split-debug-info=symbols',
], ],
stderr: outputError,
); );
if (!outputError.toString().contains('Bitcode support has been deprecated.')) {
throw TaskResult.failure('Missing bitcode deprecation warning');
}
}); });
final String outputPath = path.join(projectDir.path, outputDirectoryName); final String outputPath = path.join(projectDir.path, outputDirectoryName);
......
...@@ -300,6 +300,10 @@ class BuildIOSFrameworkCommand extends BuildFrameworkCommand { ...@@ -300,6 +300,10 @@ class BuildIOSFrameworkCommand extends BuildFrameworkCommand {
'See https://flutter.dev/docs/development/add-to-app/ios/add-flutter-screen#create-a-flutterengine for more information.'); 'See https://flutter.dev/docs/development/add-to-app/ios/add-flutter-screen#create-a-flutterengine for more information.');
} }
globals.printWarning(
'Bitcode support has been deprecated. Turn off the "Enable Bitcode" build setting in your Xcode project or you may encounter compilation errors.\n'
'See https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes for details.');
return FlutterCommandResult.success(); return FlutterCommandResult.success();
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment