Unverified Commit 7d76a827 authored by Darren Austin's avatar Darren Austin Committed by GitHub

Updated skipped tests for services directory. (#87874)

parent e2fb5cc3
...@@ -5,7 +5,6 @@ ...@@ -5,7 +5,6 @@
@TestOn('!chrome') @TestOn('!chrome')
import 'dart:typed_data'; import 'dart:typed_data';
import 'package:flutter/foundation.dart';
import 'package:flutter/services.dart'; import 'package:flutter/services.dart';
import 'package:flutter_test/flutter_test.dart'; import 'package:flutter_test/flutter_test.dart';
...@@ -78,5 +77,5 @@ void main() { ...@@ -78,5 +77,5 @@ void main() {
]; ];
checkEncodeDecode<dynamic>(standard, message); checkEncodeDecode<dynamic>(standard, message);
}); });
}, skip: kIsWeb); }, skip: isBrowser); // [intended] Javascript can't handle the big integer literals used here.
} }
...@@ -221,7 +221,7 @@ void main() { ...@@ -221,7 +221,7 @@ void main() {
<LogicalKeyboardKey>{LogicalKeyboardKey.shiftLeft, LogicalKeyboardKey.keyA}, <LogicalKeyboardKey>{LogicalKeyboardKey.shiftLeft, LogicalKeyboardKey.keyA},
), ),
); );
}, skip: isBrowser); // This is a macOS-specific test. }, skip: isBrowser); // [intended] This is a macOS-specific test.
testWidgets('keysPressed modifiers are synchronized with key events on iOS', (WidgetTester tester) async { testWidgets('keysPressed modifiers are synchronized with key events on iOS', (WidgetTester tester) async {
expect(RawKeyboard.instance.keysPressed, isEmpty); expect(RawKeyboard.instance.keysPressed, isEmpty);
...@@ -246,7 +246,7 @@ void main() { ...@@ -246,7 +246,7 @@ void main() {
<LogicalKeyboardKey>{LogicalKeyboardKey.shiftLeft, LogicalKeyboardKey.keyA}, <LogicalKeyboardKey>{LogicalKeyboardKey.shiftLeft, LogicalKeyboardKey.keyA},
), ),
); );
}, skip: isBrowser); // This is an iOS-specific test. }, skip: isBrowser); // [intended] This is an iOS-specific test.
testWidgets('keysPressed modifiers are synchronized with key events on Windows', (WidgetTester tester) async { testWidgets('keysPressed modifiers are synchronized with key events on Windows', (WidgetTester tester) async {
expect(RawKeyboard.instance.keysPressed, isEmpty); expect(RawKeyboard.instance.keysPressed, isEmpty);
...@@ -271,7 +271,7 @@ void main() { ...@@ -271,7 +271,7 @@ void main() {
<LogicalKeyboardKey>{LogicalKeyboardKey.shiftLeft, LogicalKeyboardKey.keyA}, <LogicalKeyboardKey>{LogicalKeyboardKey.shiftLeft, LogicalKeyboardKey.keyA},
), ),
); );
}, skip: isBrowser); // This is a Windows-specific test. }, skip: isBrowser); // [intended] This is a Windows-specific test.
testWidgets('keysPressed modifiers are synchronized with key events on android', (WidgetTester tester) async { testWidgets('keysPressed modifiers are synchronized with key events on android', (WidgetTester tester) async {
expect(RawKeyboard.instance.keysPressed, isEmpty); expect(RawKeyboard.instance.keysPressed, isEmpty);
...@@ -296,7 +296,7 @@ void main() { ...@@ -296,7 +296,7 @@ void main() {
<LogicalKeyboardKey>{LogicalKeyboardKey.shiftLeft, LogicalKeyboardKey.keyA}, <LogicalKeyboardKey>{LogicalKeyboardKey.shiftLeft, LogicalKeyboardKey.keyA},
), ),
); );
}, skip: isBrowser); // This is an Android-specific test. }, skip: isBrowser); // [intended] This is an Android-specific test.
testWidgets('keysPressed modifiers are synchronized with key events on fuchsia', (WidgetTester tester) async { testWidgets('keysPressed modifiers are synchronized with key events on fuchsia', (WidgetTester tester) async {
expect(RawKeyboard.instance.keysPressed, isEmpty); expect(RawKeyboard.instance.keysPressed, isEmpty);
...@@ -321,7 +321,7 @@ void main() { ...@@ -321,7 +321,7 @@ void main() {
<LogicalKeyboardKey>{LogicalKeyboardKey.shiftLeft, LogicalKeyboardKey.keyA}, <LogicalKeyboardKey>{LogicalKeyboardKey.shiftLeft, LogicalKeyboardKey.keyA},
), ),
); );
}, skip: isBrowser); // This is a Fuchsia-specific test. }, skip: isBrowser); // [intended] This is a Fuchsia-specific test.
testWidgets('keysPressed modifiers are synchronized with key events on Linux GLFW', (WidgetTester tester) async { testWidgets('keysPressed modifiers are synchronized with key events on Linux GLFW', (WidgetTester tester) async {
expect(RawKeyboard.instance.keysPressed, isEmpty); expect(RawKeyboard.instance.keysPressed, isEmpty);
...@@ -352,7 +352,7 @@ void main() { ...@@ -352,7 +352,7 @@ void main() {
}, },
), ),
); );
}, skip: isBrowser); // This is a GLFW-specific test. }, skip: isBrowser); // [intended] This is a GLFW-specific test.
testWidgets('keysPressed modifiers are synchronized with key events on web', (WidgetTester tester) async { testWidgets('keysPressed modifiers are synchronized with key events on web', (WidgetTester tester) async {
expect(RawKeyboard.instance.keysPressed, isEmpty); expect(RawKeyboard.instance.keysPressed, isEmpty);
...@@ -480,7 +480,7 @@ void main() { ...@@ -480,7 +480,7 @@ void main() {
}, },
), ),
); );
}, skip: isBrowser); // This is an Android-specific test. }, skip: isBrowser); // [intended] This is an Android-specific test.
testWidgets('sided modifiers without a side set return all sides on macOS', (WidgetTester tester) async { testWidgets('sided modifiers without a side set return all sides on macOS', (WidgetTester tester) async {
expect(RawKeyboard.instance.keysPressed, isEmpty); expect(RawKeyboard.instance.keysPressed, isEmpty);
...@@ -518,7 +518,7 @@ void main() { ...@@ -518,7 +518,7 @@ void main() {
}, },
), ),
); );
}, skip: isBrowser); // This is a macOS-specific test. }, skip: isBrowser); // [intended] This is a macOS-specific test.
testWidgets('sided modifiers without a side set return all sides on iOS', (WidgetTester tester) async { testWidgets('sided modifiers without a side set return all sides on iOS', (WidgetTester tester) async {
expect(RawKeyboard.instance.keysPressed, isEmpty); expect(RawKeyboard.instance.keysPressed, isEmpty);
...@@ -556,7 +556,7 @@ void main() { ...@@ -556,7 +556,7 @@ void main() {
}, },
), ),
); );
}, skip: isBrowser); // This is an iOS-specific test. }, skip: isBrowser); // [intended] This is an iOS-specific test.
testWidgets('sided modifiers without a side set return all sides on Windows', (WidgetTester tester) async { testWidgets('sided modifiers without a side set return all sides on Windows', (WidgetTester tester) async {
expect(RawKeyboard.instance.keysPressed, isEmpty); expect(RawKeyboard.instance.keysPressed, isEmpty);
...@@ -592,7 +592,7 @@ void main() { ...@@ -592,7 +592,7 @@ void main() {
}, },
), ),
); );
}, skip: isBrowser); // This is a Windows-specific test. }, skip: isBrowser); // [intended] This is a Windows-specific test.
testWidgets('sided modifiers without a side set return all sides on Linux GLFW', (WidgetTester tester) async { testWidgets('sided modifiers without a side set return all sides on Linux GLFW', (WidgetTester tester) async {
expect(RawKeyboard.instance.keysPressed, isEmpty); expect(RawKeyboard.instance.keysPressed, isEmpty);
...@@ -631,7 +631,7 @@ void main() { ...@@ -631,7 +631,7 @@ void main() {
}, },
), ),
); );
}, skip: isBrowser); // This is a GLFW-specific test. }, skip: isBrowser); // [intended] This is a GLFW-specific test.
testWidgets('sided modifiers without a side set return left sides on web', (WidgetTester tester) async { testWidgets('sided modifiers without a side set return left sides on web', (WidgetTester tester) async {
expect(RawKeyboard.instance.keysPressed, isEmpty); expect(RawKeyboard.instance.keysPressed, isEmpty);
...@@ -1098,7 +1098,7 @@ void main() { ...@@ -1098,7 +1098,7 @@ void main() {
'repeatCount': 42, 'repeatCount': 42,
}).data, isNot(equals(const RawKeyEventDataAndroid()))); }).data, isNot(equals(const RawKeyEventDataAndroid())));
}); });
}, skip: isBrowser); // This is an Android-specific group. }, skip: isBrowser); // [intended] This is an Android-specific group.
group('RawKeyEventDataFuchsia', () { group('RawKeyEventDataFuchsia', () {
const Map<int, _ModifierCheck> modifierTests = <int, _ModifierCheck>{ const Map<int, _ModifierCheck> modifierTests = <int, _ModifierCheck>{
...@@ -1203,7 +1203,7 @@ void main() { ...@@ -1203,7 +1203,7 @@ void main() {
expect(data.physicalKey, equals(PhysicalKeyboardKey.escape)); expect(data.physicalKey, equals(PhysicalKeyboardKey.escape));
expect(data.logicalKey, equals(LogicalKeyboardKey.escape)); expect(data.logicalKey, equals(LogicalKeyboardKey.escape));
expect(data.keyLabel, isEmpty); expect(data.keyLabel, isEmpty);
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/35347 });
test('Modifier keyboard keys are correctly translated', () { test('Modifier keyboard keys are correctly translated', () {
final RawKeyEvent shiftLeftKeyEvent = RawKeyEvent.fromMessage(const <String, dynamic>{ final RawKeyEvent shiftLeftKeyEvent = RawKeyEvent.fromMessage(const <String, dynamic>{
...@@ -1215,7 +1215,7 @@ void main() { ...@@ -1215,7 +1215,7 @@ void main() {
expect(data.physicalKey, equals(PhysicalKeyboardKey.shiftLeft)); expect(data.physicalKey, equals(PhysicalKeyboardKey.shiftLeft));
expect(data.logicalKey, equals(LogicalKeyboardKey.shiftLeft)); expect(data.logicalKey, equals(LogicalKeyboardKey.shiftLeft));
expect(data.keyLabel, isEmpty); expect(data.keyLabel, isEmpty);
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/35347 });
test('data.toString', () { test('data.toString', () {
expect(RawKeyEvent.fromMessage(const <String, dynamic>{ expect(RawKeyEvent.fromMessage(const <String, dynamic>{
...@@ -1252,7 +1252,7 @@ void main() { ...@@ -1252,7 +1252,7 @@ void main() {
'modifiers': 0x10, 'modifiers': 0x10,
}).data, isNot(equals(const RawKeyEventDataFuchsia()))); }).data, isNot(equals(const RawKeyEventDataFuchsia())));
}); });
}, skip: isBrowser); // This is a Fuchsia-specific group. }, skip: isBrowser); // [intended] This is a Fuchsia-specific group.
group('RawKeyEventDataMacOs', () { group('RawKeyEventDataMacOs', () {
const Map<int, _ModifierCheck> modifierTests = <int, _ModifierCheck>{ const Map<int, _ModifierCheck> modifierTests = <int, _ModifierCheck>{
...@@ -1370,7 +1370,7 @@ void main() { ...@@ -1370,7 +1370,7 @@ void main() {
expect(data.physicalKey, equals(PhysicalKeyboardKey.escape)); expect(data.physicalKey, equals(PhysicalKeyboardKey.escape));
expect(data.logicalKey, equals(LogicalKeyboardKey.escape)); expect(data.logicalKey, equals(LogicalKeyboardKey.escape));
expect(data.keyLabel, isEmpty); expect(data.keyLabel, isEmpty);
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/35347 });
test('Modifier keyboard keys are correctly translated', () { test('Modifier keyboard keys are correctly translated', () {
final RawKeyEvent shiftLeftKeyEvent = RawKeyEvent.fromMessage(const <String, dynamic>{ final RawKeyEvent shiftLeftKeyEvent = RawKeyEvent.fromMessage(const <String, dynamic>{
...@@ -1385,7 +1385,7 @@ void main() { ...@@ -1385,7 +1385,7 @@ void main() {
expect(data.physicalKey, equals(PhysicalKeyboardKey.shiftLeft)); expect(data.physicalKey, equals(PhysicalKeyboardKey.shiftLeft));
expect(data.logicalKey, equals(LogicalKeyboardKey.shiftLeft)); expect(data.logicalKey, equals(LogicalKeyboardKey.shiftLeft));
expect(data.keyLabel, isEmpty); expect(data.keyLabel, isEmpty);
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/35347 });
test('Unprintable keyboard keys are correctly translated', () { test('Unprintable keyboard keys are correctly translated', () {
final RawKeyEvent leftArrowKey = RawKeyEvent.fromMessage(const <String, dynamic>{ final RawKeyEvent leftArrowKey = RawKeyEvent.fromMessage(const <String, dynamic>{
...@@ -1399,7 +1399,7 @@ void main() { ...@@ -1399,7 +1399,7 @@ void main() {
final RawKeyEventDataMacOs data = leftArrowKey.data as RawKeyEventDataMacOs; final RawKeyEventDataMacOs data = leftArrowKey.data as RawKeyEventDataMacOs;
expect(data.physicalKey, equals(PhysicalKeyboardKey.arrowLeft)); expect(data.physicalKey, equals(PhysicalKeyboardKey.arrowLeft));
expect(data.logicalKey, equals(LogicalKeyboardKey.arrowLeft)); expect(data.logicalKey, equals(LogicalKeyboardKey.arrowLeft));
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/35347 });
test('data.toString', () { test('data.toString', () {
expect(RawKeyEvent.fromMessage(const <String, dynamic>{ expect(RawKeyEvent.fromMessage(const <String, dynamic>{
...@@ -1437,7 +1437,7 @@ void main() { ...@@ -1437,7 +1437,7 @@ void main() {
'modifiers': 0x10, 'modifiers': 0x10,
}).data, isNot(equals(const RawKeyEventDataMacOs()))); }).data, isNot(equals(const RawKeyEventDataMacOs())));
}); });
}, skip: isBrowser); // This is a macOS-specific group. }, skip: isBrowser); // [intended] This is a macOS-specific group.
group('RawKeyEventDataIos', () { group('RawKeyEventDataIos', () {
const Map<int, _ModifierCheck> modifierTests = <int, _ModifierCheck>{ const Map<int, _ModifierCheck> modifierTests = <int, _ModifierCheck>{
...@@ -1555,7 +1555,7 @@ void main() { ...@@ -1555,7 +1555,7 @@ void main() {
expect(data.physicalKey, equals(PhysicalKeyboardKey.escape)); expect(data.physicalKey, equals(PhysicalKeyboardKey.escape));
expect(data.logicalKey, equals(LogicalKeyboardKey.escape)); expect(data.logicalKey, equals(LogicalKeyboardKey.escape));
expect(data.keyLabel, isEmpty); expect(data.keyLabel, isEmpty);
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/35347 });
test('Modifier keyboard keys are correctly translated', () { test('Modifier keyboard keys are correctly translated', () {
final RawKeyEvent shiftLeftKeyEvent = RawKeyEvent.fromMessage(const <String, dynamic>{ final RawKeyEvent shiftLeftKeyEvent = RawKeyEvent.fromMessage(const <String, dynamic>{
...@@ -1570,7 +1570,7 @@ void main() { ...@@ -1570,7 +1570,7 @@ void main() {
expect(data.physicalKey, equals(PhysicalKeyboardKey.shiftLeft)); expect(data.physicalKey, equals(PhysicalKeyboardKey.shiftLeft));
expect(data.logicalKey, equals(LogicalKeyboardKey.shiftLeft)); expect(data.logicalKey, equals(LogicalKeyboardKey.shiftLeft));
expect(data.keyLabel, isEmpty); expect(data.keyLabel, isEmpty);
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/35347 });
test('Unprintable keyboard keys are correctly translated', () { test('Unprintable keyboard keys are correctly translated', () {
final RawKeyEvent leftArrowKey = RawKeyEvent.fromMessage(const <String, dynamic>{ final RawKeyEvent leftArrowKey = RawKeyEvent.fromMessage(const <String, dynamic>{
...@@ -1584,7 +1584,7 @@ void main() { ...@@ -1584,7 +1584,7 @@ void main() {
final RawKeyEventDataIos data = leftArrowKey.data as RawKeyEventDataIos; final RawKeyEventDataIos data = leftArrowKey.data as RawKeyEventDataIos;
expect(data.physicalKey, equals(PhysicalKeyboardKey.arrowLeft)); expect(data.physicalKey, equals(PhysicalKeyboardKey.arrowLeft));
expect(data.logicalKey, equals(LogicalKeyboardKey.arrowLeft)); expect(data.logicalKey, equals(LogicalKeyboardKey.arrowLeft));
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/35347 });
test('data.toString', () { test('data.toString', () {
expect(RawKeyEvent.fromMessage(const <String, dynamic>{ expect(RawKeyEvent.fromMessage(const <String, dynamic>{
...@@ -1622,7 +1622,7 @@ void main() { ...@@ -1622,7 +1622,7 @@ void main() {
'modifiers': 0x10, 'modifiers': 0x10,
}).data, isNot(equals(const RawKeyEventDataIos()))); }).data, isNot(equals(const RawKeyEventDataIos())));
}); });
}, skip: isBrowser); // This is an iOS-specific group. }, skip: isBrowser); // [intended] This is an iOS-specific group.
group('RawKeyEventDataWindows', () { group('RawKeyEventDataWindows', () {
const Map<int, _ModifierCheck> modifierTests = <int, _ModifierCheck>{ const Map<int, _ModifierCheck> modifierTests = <int, _ModifierCheck>{
...@@ -1840,7 +1840,7 @@ void main() { ...@@ -1840,7 +1840,7 @@ void main() {
'modifiers': 0x20, 'modifiers': 0x20,
}).data, isNot(equals(const RawKeyEventDataWindows()))); }).data, isNot(equals(const RawKeyEventDataWindows())));
}); });
}, skip: isBrowser); // This is a Windows-specific group. }, skip: isBrowser); // [intended] This is a Windows-specific group.
group('RawKeyEventDataLinux-GLFW', () { group('RawKeyEventDataLinux-GLFW', () {
const Map<int, _ModifierCheck> modifierTests = <int, _ModifierCheck>{ const Map<int, _ModifierCheck> modifierTests = <int, _ModifierCheck>{
...@@ -1996,7 +1996,7 @@ void main() { ...@@ -1996,7 +1996,7 @@ void main() {
} }
expect(() => _createFailingKey(), throwsAssertionError); expect(() => _createFailingKey(), throwsAssertionError);
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/61039 });
test('Control keyboard keys are correctly translated', () { test('Control keyboard keys are correctly translated', () {
final RawKeyEvent escapeKeyEvent = RawKeyEvent.fromMessage(const <String, dynamic>{ final RawKeyEvent escapeKeyEvent = RawKeyEvent.fromMessage(const <String, dynamic>{
...@@ -2072,7 +2072,7 @@ void main() { ...@@ -2072,7 +2072,7 @@ void main() {
keyHelper: KeyHelper('glfw'), isDown: true)), keyHelper: KeyHelper('glfw'), isDown: true)),
)); ));
}); });
}, skip: isBrowser); // This is a GLFW-specific group. }, skip: isBrowser); // [intended] This is a GLFW-specific group.
group('RawKeyEventDataLinux-GTK', () { group('RawKeyEventDataLinux-GTK', () {
const Map<int, _ModifierCheck> modifierTests = <int, _ModifierCheck>{ const Map<int, _ModifierCheck> modifierTests = <int, _ModifierCheck>{
...@@ -2228,7 +2228,7 @@ void main() { ...@@ -2228,7 +2228,7 @@ void main() {
} }
expect(() => _createFailingKey(), throwsAssertionError); expect(() => _createFailingKey(), throwsAssertionError);
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/61039 });
test('Control keyboard keys are correctly translated', () { test('Control keyboard keys are correctly translated', () {
final RawKeyEvent escapeKeyEvent = RawKeyEvent.fromMessage(const <String, dynamic>{ final RawKeyEvent escapeKeyEvent = RawKeyEvent.fromMessage(const <String, dynamic>{
...@@ -2321,7 +2321,7 @@ void main() { ...@@ -2321,7 +2321,7 @@ void main() {
keyHelper: KeyHelper('gtk'), isDown: true)), keyHelper: KeyHelper('gtk'), isDown: true)),
)); ));
}); });
}, skip: isBrowser); // This is a GTK-specific group. }, skip: isBrowser); // [intended] This is a GTK-specific group.
group('RawKeyEventDataWeb', () { group('RawKeyEventDataWeb', () {
const Map<int, ModifierKey> modifierTests = <int, ModifierKey>{ const Map<int, ModifierKey> modifierTests = <int, ModifierKey>{
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment