Commit 7a955487 authored by pq's avatar pq

Add missing returns.

As of `1.18.0-dev-0`, these cases will get flagged.  In the meantime, the
parent f92f71fe
...@@ -83,6 +83,7 @@ class OperationToken extends ExpressionToken { ...@@ -83,6 +83,7 @@ class OperationToken extends ExpressionToken {
case Operation.Division: case Operation.Division:
return ' \u00F7 '; return ' \u00F7 ';
} }
return null;
} }
} }
...@@ -258,6 +259,7 @@ class CalcExpression { ...@@ -258,6 +259,7 @@ class CalcExpression {
case ExpressionState.Result: case ExpressionState.Result:
return appendOperation(Operation.Subtraction); return appendOperation(Operation.Subtraction);
} }
return null;
} }
/// Computes the result of the current expression and returns a new /// Computes the result of the current expression and returns a new
......
...@@ -130,6 +130,7 @@ class GridDemoPhotoItem extends StatelessWidget { ...@@ -130,6 +130,7 @@ class GridDemoPhotoItem extends StatelessWidget {
child: image child: image
); );
} }
return null;
} }
} }
......
...@@ -75,6 +75,7 @@ class StocksAppState extends State<StocksApp> { ...@@ -75,6 +75,7 @@ class StocksAppState extends State<StocksApp> {
accentColor: Colors.redAccent[200] accentColor: Colors.redAccent[200]
); );
} }
return null;
} }
Route<Null> _getRoute(RouteSettings settings) { Route<Null> _getRoute(RouteSettings settings) {
......
...@@ -287,6 +287,7 @@ class ReverseAnimation extends Animation<double> ...@@ -287,6 +287,7 @@ class ReverseAnimation extends Animation<double>
case AnimationStatus.completed: return AnimationStatus.dismissed; case AnimationStatus.completed: return AnimationStatus.dismissed;
case AnimationStatus.dismissed: return AnimationStatus.completed; case AnimationStatus.dismissed: return AnimationStatus.completed;
} }
return null;
} }
@override @override
......
...@@ -157,7 +157,6 @@ class Expression extends EquationMember { ...@@ -157,7 +157,6 @@ class Expression extends EquationMember {
if (!m.isConstant) { if (!m.isConstant) {
throw new ParserException( throw new ParserException(
'The divisor was not a constant expression', <EquationMember>[this, m]); 'The divisor was not a constant expression', <EquationMember>[this, m]);
return null;
} }
return this._applyMultiplicand(1.0 / m.value); return this._applyMultiplicand(1.0 / m.value);
......
...@@ -227,6 +227,7 @@ class _MaterialButtonState extends State<MaterialButton> { ...@@ -227,6 +227,7 @@ class _MaterialButtonState extends State<MaterialButton> {
return Colors.white30; return Colors.white30;
} }
} }
return null;
} }
void _handleHighlightChanged(bool value) { void _handleHighlightChanged(bool value) {
......
...@@ -63,6 +63,7 @@ class Dialog extends StatelessWidget { ...@@ -63,6 +63,7 @@ class Dialog extends StatelessWidget {
case Brightness.dark: case Brightness.dark:
return Colors.grey[800]; return Colors.grey[800];
} }
return null;
} }
@override @override
......
...@@ -67,6 +67,7 @@ class DrawerItem extends StatelessWidget { ...@@ -67,6 +67,7 @@ class DrawerItem extends StatelessWidget {
return Colors.white30; return Colors.white30;
return null; // use default icon theme colour unmodified return null; // use default icon theme colour unmodified
} }
return null;
} }
TextStyle _getTextStyle(ThemeData themeData) { TextStyle _getTextStyle(ThemeData themeData) {
......
...@@ -65,6 +65,7 @@ class Icon extends StatelessWidget { ...@@ -65,6 +65,7 @@ class Icon extends StatelessWidget {
case Brightness.light: case Brightness.light:
return Colors.black; return Colors.black;
} }
return null;
} }
Color _getDefaultColor(BuildContext context) { Color _getDefaultColor(BuildContext context) {
......
...@@ -104,6 +104,7 @@ class RaisedButton extends StatelessWidget { ...@@ -104,6 +104,7 @@ class RaisedButton extends StatelessWidget {
case Brightness.dark: case Brightness.dark:
return Colors.white12; return Colors.white12;
} }
return null;
} }
} }
......
...@@ -186,4 +186,5 @@ Widget buildTextSelectionHandle( ...@@ -186,4 +186,5 @@ Widget buildTextSelectionHandle(
child: handle child: handle
); );
} }
return null;
} }
...@@ -1353,6 +1353,7 @@ class BoxDecoration extends Decoration { ...@@ -1353,6 +1353,7 @@ class BoxDecoration extends Decoration {
double distance = (position - center).distance; double distance = (position - center).distance;
return distance <= math.min(size.width, size.height) / 2.0; return distance <= math.min(size.width, size.height) / 2.0;
} }
return null;
} }
@override @override
......
...@@ -125,6 +125,7 @@ class TextPainter { ...@@ -125,6 +125,7 @@ class TextPainter {
case TextBaseline.ideographic: case TextBaseline.ideographic:
return _paragraph.ideographicBaseline; return _paragraph.ideographicBaseline;
} }
return null;
} }
double _lastMinWidth; double _lastMinWidth;
...@@ -211,6 +212,7 @@ class TextPainter { ...@@ -211,6 +212,7 @@ class TextPainter {
?? _getOffsetFromUpstream(offset, caretPrototype) ?? _getOffsetFromUpstream(offset, caretPrototype)
?? emptyOffset; ?? emptyOffset;
} }
return null;
} }
/// Returns a list of rects that bound the given selection. /// Returns a list of rects that bound the given selection.
......
...@@ -1125,7 +1125,6 @@ abstract class RenderBox extends RenderObject { ...@@ -1125,7 +1125,6 @@ abstract class RenderBox extends RenderObject {
'set a size and lay out any children, or, set sizedByParent to true ' 'set a size and lay out any children, or, set sizedByParent to true '
'so that performResize() sizes the render object.' 'so that performResize() sizes the render object.'
); );
return true;
} }
return true; return true;
}); });
......
...@@ -82,6 +82,7 @@ class RenderList extends RenderVirtualViewport<ListParentData> { ...@@ -82,6 +82,7 @@ class RenderList extends RenderVirtualViewport<ListParentData> {
case Axis.horizontal: case Axis.horizontal:
return padding.horizontal; return padding.horizontal;
} }
return null;
} }
double get _preferredExtent { double get _preferredExtent {
......
...@@ -57,6 +57,7 @@ class ViewportDimensions { ...@@ -57,6 +57,7 @@ class ViewportDimensions {
case ViewportAnchor.end: case ViewportAnchor.end:
return paintOffset + (containerSize - contentSize); return paintOffset + (containerSize - contentSize);
} }
return null;
} }
@override @override
......
...@@ -112,6 +112,7 @@ class BannerPainter extends CustomPainter { ...@@ -112,6 +112,7 @@ class BannerPainter extends CustomPainter {
case BannerLocation.topLeft: case BannerLocation.topLeft:
return -math.PI / 4.0; return -math.PI / 4.0;
} }
return null;
} }
} }
......
...@@ -245,7 +245,6 @@ class _DismissableState extends State<Dismissable> { ...@@ -245,7 +245,6 @@ class _DismissableState extends State<Dismissable> {
return vy > _kMinFlingVelocity; return vy > _kMinFlingVelocity;
} }
} }
return false;
} }
void _handleDragEnd(DragEndDetails details) { void _handleDragEnd(DragEndDetails details) {
......
...@@ -740,6 +740,7 @@ class _LazyBlockElement extends RenderObjectElement { ...@@ -740,6 +740,7 @@ class _LazyBlockElement extends RenderObjectElement {
case Axis.vertical: case Axis.vertical:
return new Offset(0.0, size.height); return new Offset(0.0, size.height);
} }
return null;
} }
static RenderBox _getNextWithin(_RenderLazyBlock block, RenderBox child) { static RenderBox _getNextWithin(_RenderLazyBlock block, RenderBox child) {
......
...@@ -224,6 +224,7 @@ abstract class PageableState<T extends Pageable> extends ScrollableState<T> { ...@@ -224,6 +224,7 @@ abstract class PageableState<T extends Pageable> extends ScrollableState<T> {
case Axis.vertical: case Axis.vertical:
return box.size.height; return box.size.height;
} }
return null;
} }
@override @override
......
...@@ -285,6 +285,7 @@ class ScrollableState<T extends Scrollable> extends State<T> { ...@@ -285,6 +285,7 @@ class ScrollableState<T extends Scrollable> extends State<T> {
case ViewportAnchor.end: case ViewportAnchor.end:
return pixelOffset; return pixelOffset;
} }
return null;
} }
/// Convert a scrollOffset value to the number of pixels to which it corresponds. /// Convert a scrollOffset value to the number of pixels to which it corresponds.
......
...@@ -239,6 +239,7 @@ class _VirtualListViewport extends VirtualViewport { ...@@ -239,6 +239,7 @@ class _VirtualListViewport extends VirtualViewport {
} }
break; break;
} }
return null;
} }
@override @override
......
...@@ -294,5 +294,6 @@ class _TextSelectionHandleOverlayState extends State<_TextSelectionHandleOverlay ...@@ -294,5 +294,6 @@ class _TextSelectionHandleOverlayState extends State<_TextSelectionHandleOverlay
case TextDirection.rtl: case TextDirection.rtl:
return rtlType; return rtlType;
} }
return null;
} }
} }
...@@ -70,6 +70,7 @@ abstract class VirtualViewportElement extends RenderObjectElement { ...@@ -70,6 +70,7 @@ abstract class VirtualViewportElement extends RenderObjectElement {
case ViewportAnchor.end: case ViewportAnchor.end:
return scrollOffset; return scrollOffset;
} }
return null;
} }
/// Returns a two-dimensional representation of the scroll offset, accounting /// Returns a two-dimensional representation of the scroll offset, accounting
......
...@@ -29,6 +29,7 @@ class TestOrientedBox extends SingleChildRenderObjectWidget { ...@@ -29,6 +29,7 @@ class TestOrientedBox extends SingleChildRenderObjectWidget {
case Orientation.portrait: case Orientation.portrait:
return new BoxDecoration(backgroundColor: const Color(0xFF0000FF)); return new BoxDecoration(backgroundColor: const Color(0xFF0000FF));
} }
return null;
} }
@override @override
......
...@@ -134,6 +134,7 @@ ApplicationPackage getApplicationPackageForPlatform(TargetPlatform platform) { ...@@ -134,6 +134,7 @@ ApplicationPackage getApplicationPackageForPlatform(TargetPlatform platform) {
case TargetPlatform.linux_x64: case TargetPlatform.linux_x64:
return null; return null;
} }
return null;
} }
class ApplicationPackageStore { class ApplicationPackageStore {
...@@ -156,5 +157,6 @@ class ApplicationPackageStore { ...@@ -156,5 +157,6 @@ class ApplicationPackageStore {
case TargetPlatform.linux_x64: case TargetPlatform.linux_x64:
return null; return null;
} }
return null;
} }
} }
...@@ -53,6 +53,7 @@ String getNameForHostPlatform(HostPlatform platform) { ...@@ -53,6 +53,7 @@ String getNameForHostPlatform(HostPlatform platform) {
return 'linux-x64'; return 'linux-x64';
} }
assert(false); assert(false);
return null;
} }
enum TargetPlatform { enum TargetPlatform {
...@@ -80,6 +81,7 @@ String getNameForTargetPlatform(TargetPlatform platform) { ...@@ -80,6 +81,7 @@ String getNameForTargetPlatform(TargetPlatform platform) {
return 'linux-x64'; return 'linux-x64';
} }
assert(false); assert(false);
return null;
} }
TargetPlatform getTargetPlatformForName(String platform) { TargetPlatform getTargetPlatformForName(String platform) {
......
...@@ -235,7 +235,6 @@ class IOSDevice extends Device { ...@@ -235,7 +235,6 @@ class IOSDevice extends Device {
} else { } else {
return false; return false;
} }
return false;
} }
@override @override
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment