Unverified Commit 7a8bbbd8 authored by Jenn Magder's avatar Jenn Magder Committed by GitHub

Install prebuilt iOS app only once (#75387)

parent 7aa17231
...@@ -332,10 +332,6 @@ class IOSDevice extends Device { ...@@ -332,10 +332,6 @@ class IOSDevice extends Device {
return LaunchResult.failed(); return LaunchResult.failed();
} }
packageId = buildResult.xcodeBuildExecution?.buildSettings['PRODUCT_BUNDLE_IDENTIFIER']; packageId = buildResult.xcodeBuildExecution?.buildSettings['PRODUCT_BUNDLE_IDENTIFIER'];
} else {
if (!await installApp(package)) {
return LaunchResult.failed();
}
} }
packageId ??= package.id; packageId ??= package.id;
......
...@@ -27,21 +27,6 @@ import '../../src/common.dart'; ...@@ -27,21 +27,6 @@ import '../../src/common.dart';
import '../../src/context.dart'; import '../../src/context.dart';
import '../../src/fakes.dart'; import '../../src/fakes.dart';
const FakeCommand kDeployCommand = FakeCommand(
command: <String>[
'Artifact.iosDeploy.TargetPlatform.ios',
'--id',
'123',
'--bundle',
'/',
'--no-wifi',
],
environment: <String, String>{
'PATH': '/usr/bin:null',
'DYLD_LIBRARY_PATH': '/path/to/libraries',
}
);
// The command used to actually launch the app with args in release/profile. // The command used to actually launch the app with args in release/profile.
const FakeCommand kLaunchReleaseCommand = FakeCommand( const FakeCommand kLaunchReleaseCommand = FakeCommand(
command: <String>[ command: <String>[
...@@ -123,7 +108,6 @@ void main() { ...@@ -123,7 +108,6 @@ void main() {
testWithoutContext('IOSDevice.startApp attaches in debug mode via log reading on iOS 13+', () async { testWithoutContext('IOSDevice.startApp attaches in debug mode via log reading on iOS 13+', () async {
final FileSystem fileSystem = MemoryFileSystem.test(); final FileSystem fileSystem = MemoryFileSystem.test();
final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[ final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[
kDeployCommand,
kAttachDebuggerCommand, kAttachDebuggerCommand,
]); ]);
final IOSDevice device = setUpIOSDevice( final IOSDevice device = setUpIOSDevice(
...@@ -160,7 +144,6 @@ void main() { ...@@ -160,7 +144,6 @@ void main() {
testWithoutContext('IOSDevice.startApp launches in debug mode via log reading on <iOS 13', () async { testWithoutContext('IOSDevice.startApp launches in debug mode via log reading on <iOS 13', () async {
final FileSystem fileSystem = MemoryFileSystem.test(); final FileSystem fileSystem = MemoryFileSystem.test();
final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[ final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[
kDeployCommand,
kLaunchDebugCommand, kLaunchDebugCommand,
]); ]);
final IOSDevice device = setUpIOSDevice( final IOSDevice device = setUpIOSDevice(
...@@ -198,7 +181,6 @@ void main() { ...@@ -198,7 +181,6 @@ void main() {
testWithoutContext('IOSDevice.startApp succeeds in release mode', () async { testWithoutContext('IOSDevice.startApp succeeds in release mode', () async {
final FileSystem fileSystem = MemoryFileSystem.test(); final FileSystem fileSystem = MemoryFileSystem.test();
final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[ final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[
kDeployCommand,
kLaunchReleaseCommand, kLaunchReleaseCommand,
]); ]);
final IOSDevice device = setUpIOSDevice( final IOSDevice device = setUpIOSDevice(
...@@ -226,7 +208,6 @@ void main() { ...@@ -226,7 +208,6 @@ void main() {
testWithoutContext('IOSDevice.startApp forwards all supported debugging options', () async { testWithoutContext('IOSDevice.startApp forwards all supported debugging options', () async {
final FileSystem fileSystem = MemoryFileSystem.test(); final FileSystem fileSystem = MemoryFileSystem.test();
final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[ final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[
kDeployCommand,
FakeCommand( FakeCommand(
command: <String>[ command: <String>[
'script', 'script',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment