Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
77512a3c
Unverified
Commit
77512a3c
authored
Jan 10, 2019
by
xster
Committed by
GitHub
Jan 10, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
chromebot recipe instructions missing a step (#26337)
parent
b16ef489
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
3 deletions
+4
-3
README.md
dev/bots/README.md
+4
-3
No files found.
dev/bots/README.md
View file @
77512a3c
...
@@ -77,16 +77,17 @@ The typical cycle for editing a recipe is:
...
@@ -77,16 +77,17 @@ The typical cycle for editing a recipe is:
1.
Make your edits (probably to files in
1.
Make your edits (probably to files in
`//chrome_infra/build/scripts/slave/recipes/flutter`
).
`//chrome_infra/build/scripts/slave/recipes/flutter`
).
2
.
Update the tests. Run
`build/scripts/slave/recipes.py --use-bootstrap test
1
.
Update the tests. Run
`build/scripts/slave/recipes.py --use-bootstrap test
train`
to update existing expected output to match the new output. Verify
train`
to update existing expected output to match the new output. Verify
completely new test cases by altering the
`GenTests`
method of the recipe.
completely new test cases by altering the
`GenTests`
method of the recipe.
The recipe is required to have 100% test coverage.
The recipe is required to have 100% test coverage.
3
.
Run
`build/scripts/slave/recipes.py run flutter/<repo> slavename=<slavename>
1
.
Run
`build/scripts/slave/recipes.py run flutter/<repo> slavename=<slavename>
mastername=client.flutter buildername=<buildername> buildnumber=1234`
where
`<repo>`
is one
mastername=client.flutter buildername=<buildername> buildnumber=1234`
where
`<repo>`
is one
of
`flutter`
or
`engine`
, and
`slavename`
and
`buildername`
can be looked up
of
`flutter`
or
`engine`
, and
`slavename`
and
`buildername`
can be looked up
from the
*Build Properties*
section of a
[
recent
from the
*Build Properties*
section of a
[
recent
build](https://build.chromium.org/p/client.flutter/one_line_per_build).
build](https://build.chromium.org/p/client.flutter/one_line_per_build).
4.
Upload the patch (
`git commit`
,
`git cl upload`
) and send it to someone in
1.
To submit a CL, you need a local branch first (
`git checkout -b [some branch name]`
).
1.
Upload the patch (
`git commit`
,
`git cl upload`
) and send it to someone in
the
`recipes/flutter/OWNERS`
file for review.
the
`recipes/flutter/OWNERS`
file for review.
### Editing the client.flutter buildbot master
### Editing the client.flutter buildbot master
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment