Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
76319df5
Commit
76319df5
authored
Dec 12, 2015
by
Ian Hickson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Avoid rebuilding entire app when an overlay needs updating
parent
1ab83e66
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
25 additions
and
17 deletions
+25
-17
overlay.dart
packages/flutter/lib/src/widgets/overlay.dart
+25
-17
No files found.
packages/flutter/lib/src/widgets/overlay.dart
View file @
76319df5
...
...
@@ -22,31 +22,42 @@ class OverlayEntry {
bool
get
opaque
=>
_opaque
;
bool
_opaque
;
void
set
opaque
(
bool
value
)
{
assert
(
_overlay
!=
null
);
if
(
_opaque
==
value
)
return
;
_opaque
=
value
;
markNeedsBuild
();
_overlay
.
setState
(()
{
_opaque
=
value
;
});
}
OverlayState
_state
;
OverlayState
_overlay
;
final
GlobalKey
_key
=
new
GlobalKey
();
/// Remove this entry from the overlay.
void
remove
()
{
_
state
?.
_remove
(
this
);
_
state
=
null
;
_
overlay
?.
_remove
(
this
);
_
overlay
=
null
;
}
/// Cause this entry to rebuild during the next pipeline flush.
///
/// You need to call this function if the output of [builder] has changed.
void
markNeedsBuild
()
{
// TODO(ianh): find a way to make this not rebuild the entire overlay
_state
?.
setState
(()
{});
_key
.
currentState
?.
setState
(()
{
/* the state that changed is in the builder */
});
}
String
toString
()
=>
'
$runtimeType
@
$hashCode
(opaque:
$opaque
)'
;
}
class
_OverlayEntry
extends
StatefulComponent
{
_OverlayEntry
(
OverlayEntry
entry
)
:
entry
=
entry
,
super
(
key:
entry
.
_key
);
final
OverlayEntry
entry
;
_OverlayEntryState
createState
()
=>
new
_OverlayEntryState
();
}
class
_OverlayEntryState
extends
State
<
_OverlayEntry
>
{
Widget
build
(
BuildContext
context
)
=>
config
.
entry
.
builder
(
context
);
}
/// A [Stack] of entries that can be managed independently.
class
Overlay
extends
StatefulComponent
{
Overlay
({
...
...
@@ -77,9 +88,9 @@ class OverlayState extends State<Overlay> {
/// If [above] is non-null, the entry is inserted just above [above].
/// Otherwise, the entry is inserted on top.
void
insert
(
OverlayEntry
entry
,
{
OverlayEntry
above
})
{
assert
(
entry
.
_
state
==
null
);
assert
(
above
==
null
||
(
above
.
_
state
==
this
&&
_entries
.
contains
(
above
)));
entry
.
_
state
=
this
;
assert
(
entry
.
_
overlay
==
null
);
assert
(
above
==
null
||
(
above
.
_
overlay
==
this
&&
_entries
.
contains
(
above
)));
entry
.
_
overlay
=
this
;
setState
(()
{
int
index
=
above
==
null
?
_entries
.
length
:
_entries
.
indexOf
(
above
)
+
1
;
_entries
.
insert
(
index
,
entry
);
...
...
@@ -91,10 +102,10 @@ class OverlayState extends State<Overlay> {
/// If [above] is non-null, the entries are inserted just above [above].
/// Otherwise, the entries are inserted on top.
void
insertAll
(
Iterable
<
OverlayEntry
>
entries
,
{
OverlayEntry
above
})
{
assert
(
above
==
null
||
(
above
.
_
state
==
this
&&
_entries
.
contains
(
above
)));
assert
(
above
==
null
||
(
above
.
_
overlay
==
this
&&
_entries
.
contains
(
above
)));
for
(
OverlayEntry
entry
in
entries
)
{
assert
(
entry
.
_
state
==
null
);
entry
.
_
state
=
this
;
assert
(
entry
.
_
overlay
==
null
);
entry
.
_
overlay
=
this
;
}
setState
(()
{
int
index
=
above
==
null
?
_entries
.
length
:
_entries
.
indexOf
(
above
)
+
1
;
...
...
@@ -136,10 +147,7 @@ class OverlayState extends State<Overlay> {
for
(
int
i
=
_entries
.
length
-
1
;
i
>=
0
;
--
i
)
{
OverlayEntry
entry
=
_entries
[
i
];
backwardsChildren
.
add
(
new
KeyedSubtree
(
key:
new
ObjectKey
(
entry
),
child:
entry
.
builder
(
context
)
));
backwardsChildren
.
add
(
new
_OverlayEntry
(
entry
));
if
(
entry
.
opaque
)
break
;
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment