Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
74b6ce9a
Unverified
Commit
74b6ce9a
authored
Feb 17, 2021
by
Danny Tuppeny
Committed by
GitHub
Feb 17, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Pass --run-skipped through to package:test (#76133)
parent
815976a8
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
35 additions
and
0 deletions
+35
-0
test.dart
packages/flutter_tools/lib/src/commands/test.dart
+5
-0
runner.dart
packages/flutter_tools/lib/src/test/runner.dart
+4
-0
test_test.dart
...flutter_tools/test/commands.shard/hermetic/test_test.dart
+26
-0
No files found.
packages/flutter_tools/lib/src/commands/test.dart
View file @
74b6ce9a
...
...
@@ -63,6 +63,10 @@ class TestCommand extends FlutterCommand {
'Instructions for connecting with a debugger are printed to the '
'console once the test has started.'
,
)
..
addFlag
(
'run-skipped'
,
defaultsTo:
false
,
help:
'Run skipped tests instead of skipping them.'
,
)
..
addFlag
(
'disable-service-auth-codes'
,
defaultsTo:
false
,
negatable:
false
,
...
...
@@ -309,6 +313,7 @@ class TestCommand extends FlutterCommand {
randomSeed:
stringArg
(
'test-randomize-ordering-seed'
),
reporter:
stringArg
(
'reporter'
),
timeout:
stringArg
(
'timeout'
),
runSkipped:
boolArg
(
'run-skipped'
),
);
if
(
collector
!=
null
)
{
...
...
packages/flutter_tools/lib/src/test/runner.dart
View file @
74b6ce9a
...
...
@@ -50,6 +50,7 @@ abstract class FlutterTestRunner {
String
randomSeed
,
String
reporter
,
String
timeout
,
bool
runSkipped
=
false
,
});
}
...
...
@@ -81,6 +82,7 @@ class _FlutterTestRunnerImpl implements FlutterTestRunner {
String
randomSeed
,
String
reporter
,
String
timeout
,
bool
runSkipped
=
false
,
})
async
{
// Configure package:test to use the Flutter engine for child processes.
final
String
shellPath
=
globals
.
artifacts
.
getArtifactPath
(
Artifact
.
flutterTester
);
...
...
@@ -108,6 +110,8 @@ class _FlutterTestRunnerImpl implements FlutterTestRunner {
...<
String
>[
'--tags'
,
tags
],
if
(
excludeTags
!=
null
)
...<
String
>[
'--exclude-tags'
,
excludeTags
],
if
(
runSkipped
)
'--run-skipped'
,
];
if
(
web
)
{
final
String
tempBuildDir
=
globals
.
fs
.
systemTempDirectory
...
...
packages/flutter_tools/test/commands.shard/hermetic/test_test.dart
View file @
74b6ce9a
...
...
@@ -106,6 +106,31 @@ void main() {
Cache:
()
=>
FakeCache
(),
});
testUsingContext
(
'Pipes run-skipped to package:test'
,
()
async
{
final
FakePackageTest
fakePackageTest
=
FakePackageTest
();
final
TestCommand
testCommand
=
TestCommand
(
testWrapper:
fakePackageTest
);
final
CommandRunner
<
void
>
commandRunner
=
createTestCommandRunner
(
testCommand
);
await
commandRunner
.
run
(
const
<
String
>[
'test'
,
'--no-pub'
,
'--run-skipped'
,
'--'
,
'test/fake_test.dart'
,
]);
expect
(
fakePackageTest
.
lastArgs
,
contains
(
'--run-skipped'
),
);
},
overrides:
<
Type
,
Generator
>{
FileSystem:
()
=>
fs
,
ProcessManager:
()
=>
FakeProcessManager
.
any
(),
Cache:
()
=>
FakeCache
(),
});
testUsingContext
(
'Pipes enable-observatory'
,
()
async
{
final
FakeFlutterTestRunner
testRunner
=
FakeFlutterTestRunner
(
0
);
...
...
@@ -190,6 +215,7 @@ class FakeFlutterTestRunner implements FlutterTestRunner {
@override
List
<
String
>
extraFrontEndOptions
,
String
reporter
,
String
timeout
,
bool
runSkipped
=
false
,
})
async
{
lastEnableObservatoryValue
=
enableObservatory
;
return
exitCode
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment