Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
7472fad1
Unverified
Commit
7472fad1
authored
Jun 19, 2019
by
Jonah Williams
Committed by
GitHub
Jun 19, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove most of the target logic for build web, cleanup rules (#34589)
parent
1d0aa02a
Changes
6
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
469 additions
and
484 deletions
+469
-484
build_script.dart
...ages/flutter_tools/lib/src/build_runner/build_script.dart
+459
-0
web_compilation_delegate.dart
..._tools/lib/src/build_runner/web_compilation_delegate.dart
+9
-474
resident_web_runner.dart
packages/flutter_tools/lib/src/resident_web_runner.dart
+1
-2
runner.dart
packages/flutter_tools/lib/src/test/runner.dart
+0
-3
compile.dart
packages/flutter_tools/lib/src/web/compile.dart
+0
-4
build_web_test.dart
packages/flutter_tools/test/commands/build_web_test.dart
+0
-1
No files found.
packages/flutter_tools/lib/src/build_runner/build_script.dart
0 → 100644
View file @
7472fad1
This diff is collapsed.
Click to expand it.
packages/flutter_tools/lib/src/build_runner/web_compilation_delegate.dart
View file @
7472fad1
This diff is collapsed.
Click to expand it.
packages/flutter_tools/lib/src/resident_web_runner.dart
View file @
7472fad1
...
...
@@ -131,8 +131,7 @@ class ResidentWebRunner extends ResidentRunner {
}
// Start the web compiler and build the assets.
await
webCompilationProxy
.
initialize
(
projectDirectory:
FlutterProject
.
current
().
directory
,
targets:
<
String
>[
target
],
projectDirectory:
flutterProject
.
directory
,
);
_lastCompiled
=
DateTime
.
now
();
final
AssetBundle
assetBundle
=
AssetBundleFactory
.
instance
.
createBundle
();
...
...
packages/flutter_tools/lib/src/test/runner.dart
View file @
7472fad1
...
...
@@ -76,9 +76,6 @@ Future<int> runTests(
final
bool
result
=
await
webCompilationProxy
.
initialize
(
projectDirectory:
flutterProject
.
directory
,
testOutputDir:
tempBuildDir
,
targets:
testFiles
.
map
((
String
testFile
)
{
return
fs
.
path
.
relative
(
testFile
,
from:
flutterProject
.
directory
.
path
);
}).
toList
(),
);
if
(!
result
)
{
throwToolExit
(
'Failed to compile tests'
);
...
...
packages/flutter_tools/lib/src/web/compile.dart
View file @
7472fad1
...
...
@@ -30,7 +30,6 @@ Future<void> buildWeb(FlutterProject flutterProject, String target, BuildInfo bu
try
{
result
=
await
webCompilationProxy
.
initialize
(
projectDirectory:
FlutterProject
.
current
().
directory
,
targets:
<
String
>[
target
],
release:
buildInfo
.
isRelease
,
);
if
(
result
)
{
...
...
@@ -79,11 +78,8 @@ class WebCompilationProxy {
///
/// `release` controls whether we build the bundle for dartdevc or only
/// the entrypoints for dart2js to later take over.
///
/// `targets` controls the specific compiler targets.
Future
<
bool
>
initialize
({
@required
Directory
projectDirectory
,
@required
List
<
String
>
targets
,
String
testOutputDir
,
bool
release
,
})
async
{
...
...
packages/flutter_tools/test/commands/build_web_test.dart
View file @
7472fad1
...
...
@@ -38,7 +38,6 @@ void main() {
fs
.
file
(
fs
.
path
.
join
(
'lib'
,
'main.dart'
)).
createSync
(
recursive:
true
);
when
(
mockWebCompilationProxy
.
initialize
(
projectDirectory:
anyNamed
(
'projectDirectory'
),
targets:
anyNamed
(
'targets'
),
release:
anyNamed
(
'release'
)
)).
thenAnswer
((
Invocation
invocation
)
{
final
String
path
=
fs
.
path
.
join
(
'.dart_tool'
,
'build'
,
'flutter_web'
,
'foo'
,
'lib'
,
'main_web_entrypoint.dart.js'
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment