Unverified Commit 7261b98e authored by Jim Graham's avatar Jim Graham Committed by GitHub

Enabling the ImageFiltered(ImageFilter.matrix) page of macrobenchmark (#58277)

parent 309e0aa4
...@@ -13,3 +13,6 @@ const String kTextRouteName = '/text'; ...@@ -13,3 +13,6 @@ const String kTextRouteName = '/text';
const String kAnimatedPlaceholderRouteName = '/animated_placeholder'; const String kAnimatedPlaceholderRouteName = '/animated_placeholder';
const String kColorFilterAndFadeRouteName = '/color_filter_and_fade'; const String kColorFilterAndFadeRouteName = '/color_filter_and_fade';
const String kFadingChildAnimationRouteName = '/fading_child_animation'; const String kFadingChildAnimationRouteName = '/fading_child_animation';
const String kImageFilteredTransformAnimationRouteName = '/imagefiltered_transform_animation';
const String kScrollableName = '/macrobenchmark_listview';
...@@ -42,6 +42,7 @@ class MacrobenchmarksApp extends StatelessWidget { ...@@ -42,6 +42,7 @@ class MacrobenchmarksApp extends StatelessWidget {
kAnimatedPlaceholderRouteName: (BuildContext context) => AnimatedPlaceholderPage(), kAnimatedPlaceholderRouteName: (BuildContext context) => AnimatedPlaceholderPage(),
kColorFilterAndFadeRouteName: (BuildContext context) => ColorFilterAndFadePage(), kColorFilterAndFadeRouteName: (BuildContext context) => ColorFilterAndFadePage(),
kFadingChildAnimationRouteName: (BuildContext context) => const FilteredChildAnimationPage(FilterType.opacity), kFadingChildAnimationRouteName: (BuildContext context) => const FilteredChildAnimationPage(FilterType.opacity),
kImageFilteredTransformAnimationRouteName: (BuildContext context) => const FilteredChildAnimationPage(FilterType.rotateFilter),
}, },
); );
} }
...@@ -55,6 +56,7 @@ class HomePage extends StatelessWidget { ...@@ -55,6 +56,7 @@ class HomePage extends StatelessWidget {
return Scaffold( return Scaffold(
appBar: AppBar(title: const Text(kMacrobenchmarks)), appBar: AppBar(title: const Text(kMacrobenchmarks)),
body: ListView( body: ListView(
key: const Key(kScrollableName),
children: <Widget>[ children: <Widget>[
RaisedButton( RaisedButton(
key: const Key(kCullOpacityRouteName), key: const Key(kCullOpacityRouteName),
...@@ -133,6 +135,13 @@ class HomePage extends StatelessWidget { ...@@ -133,6 +135,13 @@ class HomePage extends StatelessWidget {
Navigator.pushNamed(context, kFadingChildAnimationRouteName); Navigator.pushNamed(context, kFadingChildAnimationRouteName);
}, },
), ),
RaisedButton(
key: const Key(kImageFilteredTransformAnimationRouteName),
child: const Text('ImageFiltered Transform Animation'),
onPressed: () {
Navigator.pushNamed(context, kImageFilteredTransformAnimationRouteName);
},
),
], ],
), ),
); );
......
...@@ -42,8 +42,7 @@ class _FilteredChildAnimationPageState extends State<FilteredChildAnimationPage> ...@@ -42,8 +42,7 @@ class _FilteredChildAnimationPageState extends State<FilteredChildAnimationPage>
super.initState(); super.initState();
WidgetsBinding.instance.addPostFrameCallback((_) { WidgetsBinding.instance.addPostFrameCallback((_) {
final RenderBox childBox = _childKey.currentContext.findRenderObject() as RenderBox; final RenderBox childBox = _childKey.currentContext.findRenderObject() as RenderBox;
final Offset localCenter = childBox.paintBounds.center; _childCenter = childBox.paintBounds.center;
_childCenter = childBox.localToGlobal(localCenter);
}); });
_controller = AnimationController(vsync: this, duration: const Duration(seconds: 2)); _controller = AnimationController(vsync: this, duration: const Duration(seconds: 2));
_controller.repeat(); _controller.repeat();
......
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:flutter_driver/driver_extension.dart';
import 'package:macrobenchmarks/main.dart' as app;
void main() {
enableFlutterDriverExtension();
app.main();
}
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:macrobenchmarks/common.dart';
import 'util.dart';
void main() {
macroPerfTest(
'imagefiltered_transform_animation_perf',
kImageFilteredTransformAnimationRouteName,
pageDelay: const Duration(seconds: 1),
duration: const Duration(seconds: 10),
);
}
...@@ -7,6 +7,8 @@ import 'dart:async'; ...@@ -7,6 +7,8 @@ import 'dart:async';
import 'package:flutter_driver/flutter_driver.dart'; import 'package:flutter_driver/flutter_driver.dart';
import 'package:test/test.dart' hide TypeMatcher, isInstanceOf; import 'package:test/test.dart' hide TypeMatcher, isInstanceOf;
import 'package:macrobenchmarks/common.dart';
void macroPerfTest( void macroPerfTest(
String testName, String testName,
String routeName, String routeName,
...@@ -27,8 +29,11 @@ void macroPerfTest( ...@@ -27,8 +29,11 @@ void macroPerfTest(
await driver.forceGC(); await driver.forceGC();
final SerializableFinder scrollable = find.byValueKey(kScrollableName);
expect(scrollable, isNotNull);
final SerializableFinder button = find.byValueKey(routeName); final SerializableFinder button = find.byValueKey(routeName);
expect(button, isNotNull); expect(button, isNotNull);
await driver.scrollUntilVisible(scrollable, button, dyScroll: -50.0);
await driver.tap(button); await driver.tap(button);
if (pageDelay != null) { if (pageDelay != null) {
......
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'dart:async';
import 'package:flutter_devicelab/tasks/perf_tests.dart';
import 'package:flutter_devicelab/framework/adb.dart';
import 'package:flutter_devicelab/framework/framework.dart';
Future<void> main() async {
deviceOperatingSystem = DeviceOperatingSystem.android;
await task(createImageFilteredTransformAnimationPerfTest());
}
...@@ -217,6 +217,14 @@ TaskFunction createFadingChildAnimationPerfTest() { ...@@ -217,6 +217,14 @@ TaskFunction createFadingChildAnimationPerfTest() {
).run; ).run;
} }
TaskFunction createImageFilteredTransformAnimationPerfTest() {
return PerfTest(
'${flutterDirectory.path}/dev/benchmarks/macrobenchmarks',
'test_driver/imagefiltered_transform_animation_perf.dart',
'imagefiltered_transform_animation_perf',
).run;
}
/// Measure application startup performance. /// Measure application startup performance.
class StartupTest { class StartupTest {
const StartupTest(this.testDirectory, { this.reportMetrics = true }); const StartupTest(this.testDirectory, { this.reportMetrics = true });
......
...@@ -213,6 +213,12 @@ tasks: ...@@ -213,6 +213,12 @@ tasks:
stage: devicelab stage: devicelab
required_agent_capabilities: ["mac/android"] required_agent_capabilities: ["mac/android"]
imagefiltered_transform_animation_perf__timeline_summary:
description: >
Measures the runtime performance of imagefiltered widget with transform on Android.
stage: devicelab
required_agent_capabilities: ["mac/android"]
flavors_test: flavors_test:
description: > description: >
Checks that flavored builds work on Android. Checks that flavored builds work on Android.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment