Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
716d2524
Unverified
Commit
716d2524
authored
Mar 23, 2023
by
Michael Goderbauer
Committed by
GitHub
Mar 23, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove prefer_const_constructors ignores (#123284)
Remove prefer_const_constructors ignores
parent
11bbce1b
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
15 additions
and
19 deletions
+15
-19
expansion_tile_test.dart
packages/flutter/test/material/expansion_tile_test.dart
+6
-7
selectable_region_context_menu_test.dart
...ter/test/widgets/selectable_region_context_menu_test.dart
+3
-4
selectable_region_test.dart
packages/flutter/test/widgets/selectable_region_test.dart
+6
-8
No files found.
packages/flutter/test/material/expansion_tile_test.dart
View file @
716d2524
...
...
@@ -329,18 +329,17 @@ void main() {
const
Key
child0Key
=
Key
(
'child0'
);
const
Key
child1Key
=
Key
(
'child1'
);
// TODO(goderbauer): Reevaluate the following ignores when https://github.com/dart-lang/sdk/issues/51800 is fixed.
await
tester
.
pumpWidget
(
MaterialApp
(
// ignore: prefer_const_constructors
home:
Material
(
// ignore: prefer_const_constructors
child:
Center
(
// ignore: prefer_const_constructors
child:
ExpansionTile
(
// ignore: prefer_const_constructors
title:
const
Text
(
'title'
),
await
tester
.
pumpWidget
(
const
MaterialApp
(
home:
Material
(
child:
Center
(
child:
ExpansionTile
(
title:
Text
(
'title'
),
// Set the column's alignment to Alignment.centerRight to test CrossAxisAlignment
// of children widgets. This helps distinguish the effect of expandedAlignment
// and expandedCrossAxisAlignment later in the test.
expandedAlignment:
Alignment
.
centerRight
,
expandedCrossAxisAlignment:
CrossAxisAlignment
.
start
,
children:
const
<
Widget
>[
children:
<
Widget
>[
SizedBox
(
height:
100
,
width:
100
,
key:
child0Key
),
SizedBox
(
height:
100
,
width:
80
,
key:
child1Key
),
],
...
...
packages/flutter/test/widgets/selectable_region_context_menu_test.dart
View file @
716d2524
...
...
@@ -144,16 +144,15 @@ class RenderSelectionSpy extends RenderProxyBox
@override
SelectionGeometry
get
value
=>
_value
;
// TODO(goderbauer): Reevaluate the ignore when https://github.com/dart-lang/sdk/issues/51800 is fixed.
SelectionGeometry
_value
=
SelectionGeometry
(
// ignore: prefer_const_constructors
SelectionGeometry
_value
=
const
SelectionGeometry
(
hasContent:
true
,
status:
SelectionStatus
.
uncollapsed
,
startSelectionPoint:
const
SelectionPoint
(
startSelectionPoint:
SelectionPoint
(
localPosition:
Offset
.
zero
,
lineHeight:
0.0
,
handleType:
TextSelectionHandleType
.
left
,
),
endSelectionPoint:
const
SelectionPoint
(
endSelectionPoint:
SelectionPoint
(
localPosition:
Offset
.
zero
,
lineHeight:
0.0
,
handleType:
TextSelectionHandleType
.
left
,
...
...
packages/flutter/test/widgets/selectable_region_test.dart
View file @
716d2524
...
...
@@ -1983,16 +1983,15 @@ class RenderSelectionSpy extends RenderProxyBox
@override
SelectionGeometry
get
value
=>
_value
;
// TODO(goderbauer): Reevaluate the ignore when https://github.com/dart-lang/sdk/issues/51800 is fixed.
SelectionGeometry
_value
=
SelectionGeometry
(
// ignore: prefer_const_constructors
SelectionGeometry
_value
=
const
SelectionGeometry
(
hasContent:
true
,
status:
SelectionStatus
.
uncollapsed
,
startSelectionPoint:
const
SelectionPoint
(
startSelectionPoint:
SelectionPoint
(
localPosition:
Offset
.
zero
,
lineHeight:
0.0
,
handleType:
TextSelectionHandleType
.
left
,
),
endSelectionPoint:
const
SelectionPoint
(
endSelectionPoint:
SelectionPoint
(
localPosition:
Offset
.
zero
,
lineHeight:
0.0
,
handleType:
TextSelectionHandleType
.
left
,
...
...
@@ -2073,16 +2072,15 @@ class RenderSelectAll extends RenderProxyBox
@override
SelectionGeometry
get
value
=>
_value
;
// TODO(goderbauer): Reevaluate the ignore when https://github.com/dart-lang/sdk/issues/51800 is fixed.
SelectionGeometry
_value
=
SelectionGeometry
(
// ignore: prefer_const_constructors
SelectionGeometry
_value
=
const
SelectionGeometry
(
hasContent:
true
,
status:
SelectionStatus
.
uncollapsed
,
startSelectionPoint:
const
SelectionPoint
(
startSelectionPoint:
SelectionPoint
(
localPosition:
Offset
.
zero
,
lineHeight:
0.0
,
handleType:
TextSelectionHandleType
.
left
,
),
endSelectionPoint:
const
SelectionPoint
(
endSelectionPoint:
SelectionPoint
(
localPosition:
Offset
.
zero
,
lineHeight:
0.0
,
handleType:
TextSelectionHandleType
.
left
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment