Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
71690343
Commit
71690343
authored
Mar 24, 2017
by
Yegor
Committed by
GitHub
Mar 24, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
detailed error message re missing xcconfigs (#9001)
parent
49f5fbb8
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
9 additions
and
5 deletions
+9
-5
ios.dart
dev/devicelab/lib/framework/ios.dart
+9
-5
No files found.
dev/devicelab/lib/framework/ios.dart
View file @
71690343
...
...
@@ -23,7 +23,6 @@ Future<Null> prepareProvisioningCertificates(String flutterProjectPath) async {
await
testXcconfig
.
writeAsString
(
certificateConfig
);
}
Future
<
Null
>
_patchXcconfigFilesIfNotPatched
(
String
flutterProjectPath
)
async
{
final
List
<
File
>
xcconfigFiles
=
<
File
>[
_fs
.
file
(
path
.
join
(
flutterProjectPath
,
'ios/Flutter/Flutter.xcconfig'
)),
...
...
@@ -34,20 +33,25 @@ Future<Null> _patchXcconfigFilesIfNotPatched(String flutterProjectPath) async {
bool
xcconfigFileExists
=
false
;
for
(
final
File
file
in
xcconfigFiles
)
{
if
(
(
await
file
.
exists
()
))
{
if
(
await
file
.
exists
(
))
{
xcconfigFileExists
=
true
;
const
String
include
=
'#include "
$_kTestXcconfigFileName
"'
;
final
String
contents
=
await
file
.
readAsString
();
if
(!
contents
.
contains
(
include
))
{
final
bool
alreadyPatched
=
contents
.
contains
(
include
);
if
(!
alreadyPatched
)
{
final
IOSink
patchOut
=
file
.
openWrite
(
mode:
FileMode
.
APPEND
);
patchOut
.
writeln
();
// in case EOF is not preceded by line break
patchOut
.
writeln
(
include
);
await
patchOut
.
close
();
}
}
}
if
(!
xcconfigFileExists
)
throw
'No xcconfig file found'
;
if
(!
xcconfigFileExists
)
{
final
String
candidatesFormatted
=
xcconfigFiles
.
map
<
String
>((
File
f
)
=>
f
.
path
).
join
(
', '
);
throw
'Failed to locate a xcconfig file to patch with provisioning profile '
'info. Tried:
$candidatesFormatted
'
;
}
}
Future
<
String
>
_readProvisioningConfigFile
()
async
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment