Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
70c6fb1f
Unverified
Commit
70c6fb1f
authored
Nov 11, 2018
by
Jonah Williams
Committed by
GitHub
Nov 11, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove package:collection dependency usage from flutter_goldens (#24218)
parent
f16a569e
Changes
12
Hide whitespace changes
Inline
Side-by-side
Showing
12 changed files
with
32 additions
and
25 deletions
+32
-25
pubspec.yaml
dev/bots/pubspec.yaml
+2
-2
pubspec.yaml
dev/devicelab/pubspec.yaml
+2
-2
pubspec.yaml
dev/integration_tests/android_views/pubspec.yaml
+2
-2
pubspec.yaml
dev/tools/pubspec.yaml
+2
-2
pubspec.yaml
examples/flutter_gallery/pubspec.yaml
+2
-2
pubspec.yaml
packages/flutter/pubspec.yaml
+2
-2
pubspec.yaml
packages/flutter_driver/pubspec.yaml
+2
-2
flutter_goldens.dart
packages/flutter_goldens/lib/flutter_goldens.dart
+9
-2
pubspec.yaml
packages/flutter_goldens/pubspec.yaml
+3
-3
pubspec.yaml
packages/flutter_goldens_client/pubspec.yaml
+2
-2
pubspec.yaml
packages/flutter_tools/pubspec.yaml
+2
-2
pubspec.yaml
packages/fuchsia_remote_debug_protocol/pubspec.yaml
+2
-2
No files found.
dev/bots/pubspec.yaml
View file @
70c6fb1f
...
...
@@ -9,7 +9,7 @@ dependencies:
path
:
1.6.2
args
:
1.5.1
meta
:
1.1.6
process
:
3.0.
8
process
:
3.0.
9
platform
:
2.2.0
http
:
0.12.0
http_parser
:
3.1.3
...
...
@@ -66,4 +66,4 @@ dev_dependencies:
mockito
:
4.0.0
test_api
:
0.2.1
# PUBSPEC CHECKSUM:
8e34
# PUBSPEC CHECKSUM:
aa35
dev/devicelab/pubspec.yaml
View file @
70c6fb1f
...
...
@@ -14,7 +14,7 @@ dependencies:
meta
:
1.1.6
path
:
1.6.2
platform
:
2.2.0
process
:
3.0.
8
process
:
3.0.
9
stack_trace
:
1.9.3
vm_service_client
:
0.2.6
...
...
@@ -73,4 +73,4 @@ dev_dependencies:
watcher
:
0.9.7+10
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
yaml
:
2.1.15
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
# PUBSPEC CHECKSUM:
d119
# PUBSPEC CHECKSUM:
021a
dev/integration_tests/android_views/pubspec.yaml
View file @
70c6fb1f
...
...
@@ -60,7 +60,7 @@ dev_dependencies:
platform
:
2.2.0
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
plugin
:
0.2.0+3
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
pool
:
1.3.6
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
process
:
3.0.
8
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
process
:
3.0.
9
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
quiver
:
2.0.1
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
shelf
:
0.7.3+3
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
shelf_packages_handler
:
1.0.4
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
...
...
@@ -79,4 +79,4 @@ dev_dependencies:
flutter
:
uses-material-design
:
true
# PUBSPEC CHECKSUM:
6293
# PUBSPEC CHECKSUM:
bc94
dev/tools/pubspec.yaml
View file @
70c6fb1f
...
...
@@ -12,7 +12,7 @@ dependencies:
intl
:
0.15.7
meta
:
1.1.6
path
:
1.6.2
process
:
3.0.
8
process
:
3.0.
9
async
:
2.0.8
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
charcode
:
1.1.2
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
...
...
@@ -36,4 +36,4 @@ dev_dependencies:
stream_channel
:
1.6.8
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
term_glyph
:
1.0.1
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
# PUBSPEC CHECKSUM: ef7
2
# PUBSPEC CHECKSUM: ef7
3
examples/flutter_gallery/pubspec.yaml
View file @
70c6fb1f
...
...
@@ -63,7 +63,7 @@ dev_dependencies:
platform
:
2.2.0
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
plugin
:
0.2.0+3
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
pool
:
1.3.6
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
process
:
3.0.
8
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
process
:
3.0.
9
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
pub_semver
:
1.4.2
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
quiver
:
2.0.1
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
shelf
:
0.7.3+3
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
...
...
@@ -198,4 +198,4 @@ flutter:
-
asset
:
packages/flutter_gallery_assets/fonts/private/googlesans/GoogleSansDisplay-Regular.ttf
weight
:
400
# PUBSPEC CHECKSUM:
26f5
# PUBSPEC CHECKSUM:
ccf6
packages/flutter/pubspec.yaml
View file @
70c6fb1f
...
...
@@ -32,7 +32,7 @@ dev_dependencies:
matcher
:
0.12.3+1
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
path
:
1.6.2
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
platform
:
2.2.0
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
process
:
3.0.
8
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
process
:
3.0.
9
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
quiver
:
2.0.1
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
source_span
:
1.4.1
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
stack_trace
:
1.9.3
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
...
...
@@ -41,4 +41,4 @@ dev_dependencies:
term_glyph
:
1.0.1
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
test_api
:
0.2.1
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
# PUBSPEC CHECKSUM:
07a0
# PUBSPEC CHECKSUM:
45a1
packages/flutter_driver/pubspec.yaml
View file @
70c6fb1f
...
...
@@ -30,7 +30,7 @@ dependencies:
intl
:
0.15.7
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
matcher
:
0.12.3+1
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
platform
:
2.2.0
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
process
:
3.0.
8
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
process
:
3.0.
9
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
pub_semver
:
1.4.2
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
source_span
:
1.4.1
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
stack_trace
:
1.9.3
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
...
...
@@ -45,4 +45,4 @@ dev_dependencies:
mockito
:
4.0.0
quiver
:
2.0.1
# PUBSPEC CHECKSUM:
b6d0
# PUBSPEC CHECKSUM:
79d1
packages/flutter_goldens/lib/flutter_goldens.dart
View file @
70c6fb1f
...
...
@@ -5,7 +5,6 @@
import
'dart:async'
;
import
'dart:typed_data'
;
import
'package:collection/collection.dart'
;
import
'package:file/file.dart'
;
import
'package:file/local.dart'
;
import
'package:flutter_test/flutter_test.dart'
;
...
...
@@ -83,7 +82,15 @@ class FlutterGoldenFileComparator implements GoldenFileComparator {
}
final
List
<
int
>
goldenBytes
=
await
goldenFile
.
readAsBytes
();
// TODO(tvolkert): Improve the intelligence of this comparison.
return
const
ListEquality
<
int
>().
equals
(
goldenBytes
,
imageBytes
);
if
(
goldenBytes
.
length
!=
imageBytes
.
length
)
{
return
false
;
}
for
(
int
i
=
0
;
i
<
goldenBytes
.
length
;
i
++)
{
if
(
goldenBytes
[
i
]
!=
imageBytes
[
i
])
{
return
false
;
}
}
return
true
;
}
@override
...
...
packages/flutter_goldens/pubspec.yaml
View file @
70c6fb1f
...
...
@@ -8,17 +8,17 @@ dependencies:
# To update these, use "flutter update-packages --force-upgrade".
flutter_test
:
sdk
:
flutter
collection
:
1.14.11
file
:
5.0.6
meta
:
1.1.6
platform
:
2.2.0
process
:
3.0.
8
process
:
3.0.
9
flutter_goldens_client
:
path
:
../flutter_goldens_client
async
:
2.0.8
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
boolean_selector
:
1.0.4
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
charcode
:
1.1.2
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
collection
:
1.14.11
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
intl
:
0.15.7
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
matcher
:
0.12.3+1
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
path
:
1.6.2
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
...
...
@@ -34,4 +34,4 @@ dependencies:
dev_dependencies
:
mockito
:
4.0.0
# PUBSPEC CHECKSUM:
762e
# PUBSPEC CHECKSUM:
922f
packages/flutter_goldens_client/pubspec.yaml
View file @
70c6fb1f
...
...
@@ -8,7 +8,7 @@ dependencies:
# To update these, use "flutter update-packages --force-upgrade".
file
:
5.0.6
platform
:
2.2.0
process
:
3.0.
8
process
:
3.0.
9
intl
:
0.15.7
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
meta
:
1.1.6
# THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
...
...
@@ -18,4 +18,4 @@ dartdoc:
# Exclude this package from the hosted API docs.
nodoc
:
true
# PUBSPEC CHECKSUM: b
d30
# PUBSPEC CHECKSUM: b
e31
packages/flutter_tools/pubspec.yaml
View file @
70c6fb1f
...
...
@@ -27,7 +27,7 @@ dependencies:
package_config
:
1.0.5
platform
:
2.2.0
plugin
:
0.2.0+3
process
:
3.0.
8
process
:
3.0.
9
quiver
:
2.0.1
stack_trace
:
1.9.3
stream_channel
:
1.6.8
...
...
@@ -94,4 +94,4 @@ dartdoc:
# Exclude this package from the hosted API docs.
nodoc
:
true
# PUBSPEC CHECKSUM:
8467
# PUBSPEC CHECKSUM:
1368
packages/fuchsia_remote_debug_protocol/pubspec.yaml
View file @
70c6fb1f
...
...
@@ -9,7 +9,7 @@ environment:
dependencies
:
json_rpc_2
:
2.0.9
process
:
3.0.
8
process
:
3.0.
9
web_socket_channel
:
1.0.9
flutter_test
:
sdk
:
flutter
...
...
@@ -43,4 +43,4 @@ dependencies:
dev_dependencies
:
mockito
:
4.0.0
# PUBSPEC CHECKSUM:
b6d0
# PUBSPEC CHECKSUM:
79d1
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment