Unverified Commit 709f54f4 authored by Alexander Aprelev's avatar Alexander Aprelev Committed by GitHub

Run reload asynchronously so that multiple devices can reload in parallel. (#22693)

* Run reload asynchronously so that multiple devices can reload in parallel.
parent 53308465
......@@ -79,11 +79,15 @@ class FlutterDevice {
vmServices = localVmServices;
}
Future<void> refreshViews() async {
Future<void> refreshViews() {
if (vmServices == null || vmServices.isEmpty)
return;
return Future<void>.value(null);
final List<Future<void>> futures = <Future<void>>[];
for (VMService service in vmServices)
await service.vm.refreshViews();
futures.add(service.vm.refreshViews());
final Completer<void> completer = Completer<void>();
Future.wait(futures).whenComplete(() => completer.complete(null)); // ignore: unawaited_futures
return completer.future;
}
List<FlutterView> get views {
......
This diff is collapsed.
......@@ -949,15 +949,19 @@ class VM extends ServiceObjectOwner {
return invokeRpcRaw('_getVMTimeline', timeout: kLongRequestTimeout);
}
Future<void> refreshViews() async {
Future<void> refreshViews() {
if (!isFlutterEngine)
return;
return Future<void>.value(null);
_viewCache.clear();
final Completer<void> completer = Completer<void>();
final List<Future<ServiceObject>> futures = <Future<ServiceObject>>[];
for (Isolate isolate in isolates.toList()) {
await vmService.vm.invokeRpc<ServiceObject>('_flutter.listViews',
futures.add(vmService.vm.invokeRpc<ServiceObject>('_flutter.listViews',
timeout: kLongRequestTimeout,
params: <String, dynamic> {'isolateId': isolate.id});
params: <String, dynamic> {'isolateId': isolate.id}));
}
Future.wait(futures).whenComplete(() => completer.complete(null)); // ignore: unawaited_futures
return completer.future;
}
Iterable<FlutterView> get views => _viewCache.values;
......@@ -1226,15 +1230,15 @@ class Isolate extends ServiceObjectOwner {
Duration timeout,
bool timeoutFatal = true,
}
) async {
try {
return await invokeRpcRaw(method, params: params, timeout: timeout, timeoutFatal: timeoutFatal);
} on rpc.RpcException catch (e) {
) {
return invokeRpcRaw(method, params: params, timeout: timeout,
timeoutFatal: timeoutFatal).catchError((dynamic error) {
if (error is rpc.RpcException) {
// If an application is not using the framework
if (e.code == rpc_error_code.METHOD_NOT_FOUND)
if (error.code == rpc_error_code.METHOD_NOT_FOUND)
return null;
rethrow;
}
throw error;
}});
}
// Debug dump extension methods.
......@@ -1288,20 +1292,20 @@ class Isolate extends ServiceObjectOwner {
}
// Reload related extension methods.
Future<Map<String, dynamic>> flutterReassemble() async {
return await invokeFlutterExtensionRpcRaw(
Future<Map<String, dynamic>> flutterReassemble() {
return invokeFlutterExtensionRpcRaw(
'ext.flutter.reassemble',
timeout: kShortRequestTimeout,
timeoutFatal: true,
);
}
Future<Map<String, dynamic>> uiWindowScheduleFrame() async {
return await invokeFlutterExtensionRpcRaw('ext.ui.window.scheduleFrame');
Future<Map<String, dynamic>> uiWindowScheduleFrame() {
return invokeFlutterExtensionRpcRaw('ext.ui.window.scheduleFrame');
}
Future<Map<String, dynamic>> flutterEvictAsset(String assetPath) async {
return await invokeFlutterExtensionRpcRaw('ext.flutter.evict',
Future<Map<String, dynamic>> flutterEvictAsset(String assetPath) {
return invokeFlutterExtensionRpcRaw('ext.flutter.evict',
params: <String, dynamic>{
'value': assetPath,
}
......@@ -1309,8 +1313,8 @@ class Isolate extends ServiceObjectOwner {
}
// Application control extension methods.
Future<Map<String, dynamic>> flutterExit() async {
return await invokeFlutterExtensionRpcRaw(
Future<Map<String, dynamic>> flutterExit() {
return invokeFlutterExtensionRpcRaw(
'ext.flutter.exit',
timeout: const Duration(seconds: 2),
timeoutFatal: false,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment