Unverified Commit 6f6b5647 authored by iroiroys's avatar iroiroys Committed by GitHub

Add more specific cause on web development tool error output (#98553)

parent fd25dc84
......@@ -52,7 +52,7 @@ class Utf8Decoder extends cnv.Utf8Decoder {
// was malformed.
if (reportErrors && result.contains('\u{FFFD}')) {
throwToolExit(
'Bad UTF-8 encoding found while decoding string: $result. '
'Bad UTF-8 encoding (U+FFFD; REPLACEMENT CHARACTER) found while decoding string: $result. '
'The Flutter team would greatly appreciate if you could file a bug explaining '
'exactly what you were doing when this happened:\n'
'https://github.com/flutter/flutter/issues/new/choose\n'
......
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:flutter_tools/src/base/common.dart';
import 'package:flutter_tools/src/convert.dart';
import '../src/common.dart';
void main() {
late String passedString;
late String nonpassString;
const Utf8Decoder decoder = Utf8Decoder();
setUp(() {
passedString = 'normal string';
nonpassString = 'malformed string => �';
});
testWithoutContext('Decode a normal string', () async {
assert(passedString != null);
expect(decoder.convert(passedString.codeUnits), passedString);
});
testWithoutContext('Decode a malformed string', () async {
assert(nonpassString != null);
expect(
() => decoder.convert(nonpassString.codeUnits),
throwsA(
isA<ToolExit>().having(
(ToolExit error) => error.message,
'message',
contains('(U+FFFD; REPLACEMENT CHARACTER)'), // Added paragraph
),
),
);
});
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment