Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
6f6b5647
Unverified
Commit
6f6b5647
authored
Mar 16, 2022
by
iroiroys
Committed by
GitHub
Mar 16, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add more specific cause on web development tool error output (#98553)
parent
fd25dc84
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
42 additions
and
1 deletion
+42
-1
convert.dart
packages/flutter_tools/lib/src/convert.dart
+1
-1
convert_test.dart
packages/flutter_tools/test/general.shard/convert_test.dart
+41
-0
No files found.
packages/flutter_tools/lib/src/convert.dart
View file @
6f6b5647
...
...
@@ -52,7 +52,7 @@ class Utf8Decoder extends cnv.Utf8Decoder {
// was malformed.
if
(
reportErrors
&&
result
.
contains
(
'
\
u{FFFD}'
))
{
throwToolExit
(
'Bad UTF-8 encoding found while decoding string:
$result
. '
'Bad UTF-8 encoding
(U+FFFD; REPLACEMENT CHARACTER)
found while decoding string:
$result
. '
'The Flutter team would greatly appreciate if you could file a bug explaining '
'exactly what you were doing when this happened:
\n
'
'https://github.com/flutter/flutter/issues/new/choose
\n
'
...
...
packages/flutter_tools/test/general.shard/convert_test.dart
0 → 100644
View file @
6f6b5647
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import
'package:flutter_tools/src/base/common.dart'
;
import
'package:flutter_tools/src/convert.dart'
;
import
'../src/common.dart'
;
void
main
(
)
{
late
String
passedString
;
late
String
nonpassString
;
const
Utf8Decoder
decoder
=
Utf8Decoder
();
setUp
(()
{
passedString
=
'normal string'
;
nonpassString
=
'malformed string => �'
;
});
testWithoutContext
(
'Decode a normal string'
,
()
async
{
assert
(
passedString
!=
null
);
expect
(
decoder
.
convert
(
passedString
.
codeUnits
),
passedString
);
});
testWithoutContext
(
'Decode a malformed string'
,
()
async
{
assert
(
nonpassString
!=
null
);
expect
(
()
=>
decoder
.
convert
(
nonpassString
.
codeUnits
),
throwsA
(
isA
<
ToolExit
>().
having
(
(
ToolExit
error
)
=>
error
.
message
,
'message'
,
contains
(
'(U+FFFD; REPLACEMENT CHARACTER)'
),
// Added paragraph
),
),
);
});
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment