Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
6eb45d35
Unverified
Commit
6eb45d35
authored
Aug 19, 2020
by
Yuqian Li
Committed by
GitHub
Aug 19, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Rename needsMeasureCpuGpu to measureCpuGpu (#64000)
parent
38e0c258
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
21 additions
and
21 deletions
+21
-21
complex_layout_scroll_perf_ios__timeline_summary.dart
...sks/complex_layout_scroll_perf_ios__timeline_summary.dart
+1
-1
post_backdrop_filter_perf_ios__timeline_summary.dart
...asks/post_backdrop_filter_perf_ios__timeline_summary.dart
+1
-1
simple_animation_perf_ios.dart
dev/devicelab/bin/tasks/simple_animation_perf_ios.dart
+1
-1
perf_tests.dart
dev/devicelab/lib/tasks/perf_tests.dart
+18
-18
No files found.
dev/devicelab/bin/tasks/complex_layout_scroll_perf_ios__timeline_summary.dart
View file @
6eb45d35
...
...
@@ -10,5 +10,5 @@ import 'package:flutter_devicelab/framework/framework.dart';
Future
<
void
>
main
()
async
{
deviceOperatingSystem
=
DeviceOperatingSystem
.
ios
;
await
task
(
createComplexLayoutScrollPerfTest
(
needsM
easureCpuGpu:
true
));
await
task
(
createComplexLayoutScrollPerfTest
(
m
easureCpuGpu:
true
));
}
dev/devicelab/bin/tasks/post_backdrop_filter_perf_ios__timeline_summary.dart
View file @
6eb45d35
...
...
@@ -10,5 +10,5 @@ import 'package:flutter_devicelab/framework/framework.dart';
Future
<
void
>
main
()
async
{
deviceOperatingSystem
=
DeviceOperatingSystem
.
ios
;
await
task
(
createPostBackdropFilterPerfTest
(
needsM
easureCpuGpu:
true
));
await
task
(
createPostBackdropFilterPerfTest
(
m
easureCpuGpu:
true
));
}
dev/devicelab/bin/tasks/simple_animation_perf_ios.dart
View file @
6eb45d35
...
...
@@ -9,5 +9,5 @@ import 'package:flutter_devicelab/tasks/perf_tests.dart';
Future
<
void
>
main
()
async
{
deviceOperatingSystem
=
DeviceOperatingSystem
.
ios
;
await
task
(
createSimpleAnimationPerfTest
(
needsM
easureCpuGpu:
true
));
await
task
(
createSimpleAnimationPerfTest
(
m
easureCpuGpu:
true
));
}
dev/devicelab/lib/tasks/perf_tests.dart
View file @
6eb45d35
...
...
@@ -15,12 +15,12 @@ import 'package:flutter_devicelab/framework/framework.dart';
import
'package:flutter_devicelab/framework/utils.dart'
;
import
'package:flutter_devicelab/tasks/track_widget_creation_enabled_task.dart'
;
TaskFunction
createComplexLayoutScrollPerfTest
(
{
bool
needsM
easureCpuGpu
=
false
})
{
TaskFunction
createComplexLayoutScrollPerfTest
(
{
bool
m
easureCpuGpu
=
false
})
{
return
PerfTest
(
'
${flutterDirectory.path}
/dev/benchmarks/complex_layout'
,
'test_driver/scroll_perf.dart'
,
'complex_layout_scroll_perf'
,
needsMeasureCpuGpu:
needsM
easureCpuGpu
,
measureCpuGpu:
m
easureCpuGpu
,
).
run
;
}
...
...
@@ -109,42 +109,42 @@ TaskFunction createFlutterGalleryTransitionsPerfSkSLWarmupTest() {
).
run
;
}
TaskFunction
createBackdropFilterPerfTest
(
{
bool
needsM
easureCpuGpu
=
false
})
{
TaskFunction
createBackdropFilterPerfTest
(
{
bool
m
easureCpuGpu
=
false
})
{
return
PerfTest
(
'
${flutterDirectory.path}
/dev/benchmarks/macrobenchmarks'
,
'test_driver/run_app.dart'
,
'backdrop_filter_perf'
,
needsMeasureCpuGpu:
needsM
easureCpuGpu
,
measureCpuGpu:
m
easureCpuGpu
,
testDriver:
'test_driver/backdrop_filter_perf_test.dart'
,
).
run
;
}
TaskFunction
createPostBackdropFilterPerfTest
(
{
bool
needsM
easureCpuGpu
=
false
})
{
TaskFunction
createPostBackdropFilterPerfTest
(
{
bool
m
easureCpuGpu
=
false
})
{
return
PerfTest
(
'
${flutterDirectory.path}
/dev/benchmarks/macrobenchmarks'
,
'test_driver/run_app.dart'
,
'post_backdrop_filter_perf'
,
needsMeasureCpuGpu:
needsM
easureCpuGpu
,
measureCpuGpu:
m
easureCpuGpu
,
testDriver:
'test_driver/post_backdrop_filter_perf_test.dart'
,
).
run
;
}
TaskFunction
createSimpleAnimationPerfTest
(
{
bool
needsM
easureCpuGpu
=
false
})
{
TaskFunction
createSimpleAnimationPerfTest
(
{
bool
m
easureCpuGpu
=
false
})
{
return
PerfTest
(
'
${flutterDirectory.path}
/dev/benchmarks/macrobenchmarks'
,
'test_driver/run_app.dart'
,
'simple_animation_perf'
,
needsMeasureCpuGpu:
needsM
easureCpuGpu
,
measureCpuGpu:
m
easureCpuGpu
,
testDriver:
'test_driver/simple_animation_perf_test.dart'
,
).
run
;
}
TaskFunction
createAnimatedPlaceholderPerfTest
(
{
bool
needsM
easureCpuGpu
=
false
})
{
TaskFunction
createAnimatedPlaceholderPerfTest
(
{
bool
m
easureCpuGpu
=
false
})
{
return
PerfTest
(
'
${flutterDirectory.path}
/dev/benchmarks/macrobenchmarks'
,
'test_driver/run_app.dart'
,
'animated_placeholder_perf'
,
needsMeasureCpuGpu:
needsM
easureCpuGpu
,
measureCpuGpu:
m
easureCpuGpu
,
testDriver:
'test_driver/animated_placeholder_perf_test.dart'
,
).
run
;
}
...
...
@@ -368,7 +368,7 @@ class PerfTest {
this
.
testDirectory
,
this
.
testTarget
,
this
.
timelineFileName
,
{
this
.
needsM
easureCpuGpu
=
false
,
this
.
m
easureCpuGpu
=
false
,
this
.
testDriver
,
this
.
needsFullTimeline
=
true
,
this
.
benchmarkScoreKeys
,
...
...
@@ -385,7 +385,7 @@ class PerfTest {
/// The test file to run on the host.
final
String
testDriver
;
/// Whether to collect CPU and GPU metrics.
final
bool
needsM
easureCpuGpu
;
final
bool
m
easureCpuGpu
;
/// Whether to collect full timeline, meaning if `--trace-startup` flag is needed.
final
bool
needsFullTimeline
;
...
...
@@ -405,8 +405,8 @@ class PerfTest {
/// 'average_vsync_transitions_missed',
/// '90th_percentile_vsync_transitions_missed',
/// '99th_percentile_vsync_transitions_missed',
/// if (
needsM
easureCpuGpu) 'average_cpu_usage',
/// if (
needsM
easureCpuGpu) 'average_gpu_usage',
/// if (
m
easureCpuGpu) 'average_cpu_usage',
/// if (
m
easureCpuGpu) 'average_gpu_usage',
/// ]
/// ```
final
List
<
String
>
benchmarkScoreKeys
;
...
...
@@ -476,8 +476,8 @@ class PerfTest {
'average_vsync_transitions_missed'
,
'90th_percentile_vsync_transitions_missed'
,
'99th_percentile_vsync_transitions_missed'
,
if
(
needsM
easureCpuGpu
)
'average_cpu_usage'
,
if
(
needsM
easureCpuGpu
)
'average_gpu_usage'
,
if
(
m
easureCpuGpu
)
'average_cpu_usage'
,
if
(
m
easureCpuGpu
)
'average_gpu_usage'
,
],
);
});
...
...
@@ -518,13 +518,13 @@ class PerfTestWithSkSL extends PerfTest {
String
testDirectory
,
String
testTarget
,
String
timelineFileName
,
{
bool
needsM
easureCpuGpu
=
false
,
bool
m
easureCpuGpu
=
false
,
String
testDriver
,
})
:
super
(
testDirectory
,
testTarget
,
timelineFileName
,
needsMeasureCpuGpu:
needsM
easureCpuGpu
,
measureCpuGpu:
m
easureCpuGpu
,
testDriver:
testDriver
,
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment