Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
6b98f2ca
Unverified
Commit
6b98f2ca
authored
Nov 30, 2022
by
chunhtai
Committed by
GitHub
Nov 30, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
labeledTapTargetGuideline should passe if textfield does not have label (#116221)
parent
9532b91c
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
1 deletion
+10
-1
accessibility.dart
packages/flutter_test/lib/src/accessibility.dart
+2
-1
accessibility_test.dart
packages/flutter_test/test/accessibility_test.dart
+8
-0
No files found.
packages/flutter_test/lib/src/accessibility.dart
View file @
6b98f2ca
...
...
@@ -219,7 +219,8 @@ class LabeledTapTargetGuideline extends AccessibilityGuideline {
});
if
(
node
.
isMergedIntoParent
||
node
.
isInvisible
||
node
.
hasFlag
(
ui
.
SemanticsFlag
.
isHidden
))
{
node
.
hasFlag
(
ui
.
SemanticsFlag
.
isHidden
)
||
node
.
hasFlag
(
ui
.
SemanticsFlag
.
isTextField
))
{
return
result
;
}
final
SemanticsData
data
=
node
.
getSemanticsData
();
...
...
packages/flutter_test/test/accessibility_test.dart
View file @
6b98f2ca
...
...
@@ -874,6 +874,14 @@ void main() {
expect
(
result
.
passed
,
true
);
handle
.
dispose
();
});
testWidgets
(
'Passes if text field does not have label'
,
(
WidgetTester
tester
)
async
{
final
SemanticsHandle
handle
=
tester
.
ensureSemantics
();
await
tester
.
pumpWidget
(
_boilerplate
(
const
TextField
()));
final
Evaluation
result
=
await
labeledTapTargetGuideline
.
evaluate
(
tester
);
expect
(
result
.
passed
,
true
);
handle
.
dispose
();
});
});
testWidgets
(
'regression test for material widget'
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment