Unverified Commit 68e346e4 authored by Michael Goderbauer's avatar Michael Goderbauer Committed by GitHub

Remove outdated ignores from tool (#140467)

These were not ignoring anything (anymore).
parent c4fda233
......@@ -1481,8 +1481,6 @@ double _matrix3Distance(Matrix3 a, Matrix3 b) {
}
double _sizeDistance(Size a, Size b) {
// TODO(a14n): remove ignore when lint is updated, https://github.com/dart-lang/linter/issues/1843
// ignore: unnecessary_parenthesis
final Offset delta = (b - a) as Offset;
return delta.distance;
}
......
......@@ -13,7 +13,6 @@ import 'package:flutter/foundation.dart';
/// features are enabled, consider the [FakeAccessibilityFeatures.allOn]
/// constant.
@immutable
// ignore: avoid_implementing_value_types
class FakeAccessibilityFeatures implements AccessibilityFeatures {
/// Creates a test instance of [AccessibilityFeatures].
///
......
......@@ -14,7 +14,7 @@ import 'package:flutter/scheduler.dart';
import 'package:flutter/services.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:matcher/expect.dart' as matcher;
import 'package:matcher/src/expect/async_matcher.dart'; // ignore: implementation_imports
import 'package:matcher/src/expect/async_matcher.dart';
void main() {
group('expectLater', () {
......
......@@ -6,7 +6,6 @@ import 'dart:async';
import 'dart:typed_data';
import 'package:dwds/data/build_result.dart';
// ignore: import_of_legacy_library_into_null_safe
import 'package:dwds/dwds.dart';
import 'package:logging/logging.dart' as logging;
import 'package:meta/meta.dart';
......
......@@ -4,7 +4,6 @@
import 'dart:async';
// ignore: import_of_legacy_library_into_null_safe
import 'package:dwds/dwds.dart';
import 'package:package_config/package_config.dart';
import 'package:unified_analytics/unified_analytics.dart';
......
......@@ -229,7 +229,6 @@ class FlutterDevice {
FlutterVmService? vmService;
DevFS? devFS;
ApplicationPackage? package;
// ignore: cancel_subscriptions
StreamSubscription<String>? _loggingSubscription;
bool? _isListeningForVmServiceUri;
......
......@@ -1399,9 +1399,6 @@ class FakeDartDevelopmentService extends Fake implements DartDevelopmentService
Uri get uri => Uri.parse('http://localhost:8181');
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeAndroidDevice extends Fake implements AndroidDevice {
FakeAndroidDevice({required this.id});
......@@ -1473,9 +1470,6 @@ class FakeAndroidDevice extends Fake implements AndroidDevice {
bool get ephemeral => true;
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeIOSDevice extends Fake implements IOSDevice {
FakeIOSDevice({
DevicePortForwarder? portForwarder,
......
......@@ -550,7 +550,7 @@ void main() {
'-w', '1',
'testhostname',
],
postBuildCommand: null, // ignore: avoid_redundant_argument_values
postBuildCommand: null,
installCommand: const <String>[
'scp',
'-r',
......@@ -640,7 +640,7 @@ void main() {
'-w', '1',
'192.168.178.1',
],
postBuildCommand: null, // ignore: avoid_redundant_argument_values
postBuildCommand: null,
installCommand: const <String>[
'scp',
'-r',
......@@ -730,7 +730,7 @@ void main() {
'-w', '1',
'::1',
],
postBuildCommand: null, // ignore: avoid_redundant_argument_values
postBuildCommand: null,
installCommand: const <String>[
'scp',
'-r',
......@@ -824,7 +824,7 @@ void main() {
'-w', '1',
'testhostname',
],
postBuildCommand: null, // ignore: avoid_redundant_argument_values
postBuildCommand: null,
installCommand: <String>[
'scp',
'-r',
......@@ -904,7 +904,7 @@ void main() {
'-w', '1',
'testhostname',
],
postBuildCommand: null, // ignore: avoid_redundant_argument_values
postBuildCommand: null,
installCommand: const <String>[
'scp',
'-r',
......@@ -1229,7 +1229,7 @@ void main() {
'testhostname',
],
pingSuccessRegex: RegExp(r'[<=]\d+ms'),
postBuildCommand: null, // ignore: avoid_redundant_argument_values
postBuildCommand: null,
installCommand: const <String>[
'scp',
'-r',
......
......@@ -951,9 +951,6 @@ class FakeIOSWorkflow extends Fake implements IOSWorkflow {
final bool canListDevices;
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeAndroidDevice extends Fake implements AndroidDevice {
@override
final String id = 'device';
......
......@@ -1420,9 +1420,6 @@ class FakeDeviceManager extends Fake implements DeviceManager {
Future<List<String>> getDeviceDiagnostics() async => diagnostics;
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeDevice extends Fake implements Device {
@override
String get name => 'name';
......
......@@ -539,8 +539,6 @@ void main() {
});
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
class ThrowingScreenshotDevice extends ScreenshotDevice {
@override
Future<LaunchResult> startApp(
......@@ -558,9 +556,6 @@ class ThrowingScreenshotDevice extends ScreenshotDevice {
}
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class ScreenshotDevice extends Fake implements Device {
final List<File> screenshots = <File>[];
......@@ -699,9 +694,6 @@ class FakeProcessSignal extends Fake implements io.ProcessSignal {
Stream<io.ProcessSignal> watch() => controller.stream;
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeIosDevice extends Fake implements IOSDevice {
@override
DeviceConnectionInterface connectionInterface = DeviceConnectionInterface.attached;
......
......@@ -139,9 +139,6 @@ class FakeApplicationPackageFactory extends Fake implements ApplicationPackageFa
class FakeIOSApp extends Fake implements IOSApp { }
class FakeAndroidApk extends Fake implements AndroidApk { }
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeIOSDevice extends Fake implements IOSDevice {
@override
Future<TargetPlatform> get targetPlatform async => TargetPlatform.ios;
......@@ -162,9 +159,6 @@ class FakeIOSDevice extends Fake implements IOSDevice {
String get name => 'iOS';
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeAndroidDevice extends Fake implements AndroidDevice {
@override
Future<TargetPlatform> get targetPlatform async => TargetPlatform.android_arm;
......
......@@ -246,9 +246,6 @@ class FakeDaemonStreams implements DaemonStreams {
}
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeAndroidDevice extends Fake implements AndroidDevice {
@override
final String id = 'device';
......
......@@ -1301,9 +1301,6 @@ class FakeAndroidSdk extends Fake implements AndroidSdk {
String get adbPath => 'adb';
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeDevice extends Fake implements Device {
FakeDevice({
bool isLocalEmulator = false,
......@@ -1439,9 +1436,6 @@ class FakeDevice extends Fake implements Device {
}
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeIOSDevice extends Fake implements IOSDevice {
FakeIOSDevice({
this.connectionInterface = DeviceConnectionInterface.attached,
......
......@@ -225,9 +225,6 @@ AndroidDevice createFakeDevice(int? sdkLevel) {
);
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeAndroidDevice extends Fake implements AndroidDevice {
FakeAndroidDevice(this._apiVersion, this._lastLogcatTimestamp);
......
......@@ -168,9 +168,6 @@ class FakeFlutterDevice extends Fake implements FlutterDevice {
Future<void> initLogReader() async { }
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeDevice extends Fake implements Device {
@override
bool isSupported() => true;
......
......@@ -476,9 +476,6 @@ class FakeApplicationPackageFactory extends Fake implements ApplicationPackageFa
class FakeApplicationPackage extends Fake implements ApplicationPackage { }
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeDevice extends Fake implements Device {
FakeDevice(this.result, {this.supportsFlutterExit = true});
......
......@@ -384,9 +384,6 @@ WebDriverService setUpDriverService() {
);
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeDevice extends Fake implements Device {
@override
final PlatformType platformType = PlatformType.web;
......
......@@ -945,9 +945,6 @@ class FuchsiaModulePackage extends ApplicationPackage {
final String name;
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class MockFuchsiaDevice extends Fake implements FuchsiaDevice {
MockFuchsiaDevice(this.id, this.portForwarder, this._ipv6);
......
......@@ -786,9 +786,6 @@ class FakeDevFs extends Fake implements DevFS {
Uri? baseUri;
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeDevice extends Fake implements Device {
FakeDevice({
TargetPlatform targetPlatform = TargetPlatform.tester,
......
......@@ -1038,9 +1038,6 @@ class FakeMDnsClient extends Fake implements MDnsClient {
void stop() {}
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeIOSDevice extends Fake implements IOSDevice {
FakeIOSDevice({this.name = 'iPhone'});
......
......@@ -1591,7 +1591,6 @@ void addGradleWrapperFile(Directory directory, String gradleVersion) {
.childDirectory(gradle_utils.gradleWrapperDirectoryName)
.childFile(gradle_utils.gradleWrapperPropertiesFilename)
..createSync(recursive: true)
// ignore: unnecessary_string_escapes
..writeAsStringSync('''
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
......
......@@ -467,9 +467,6 @@ class FakeFlutterDevice extends Fake implements FlutterDevice {
TargetPlatform targetPlatform = TargetPlatform.android_arm;
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeDevice extends Fake implements Device {
@override
DartDevelopmentService get dds => FakeDartDevelopmentService();
......
......@@ -2740,9 +2740,6 @@ class FakeProjectFileInvalidator extends Fake implements ProjectFileInvalidator
}
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeDevice extends Fake implements Device {
FakeDevice({
String sdkNameAndVersion = 'Android',
......
......@@ -201,9 +201,6 @@ class FakeWebDevFS extends Fake implements WebDevFS {
}
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeWebDevice extends Fake implements Device {
@override
String get name => 'web';
......
......@@ -1417,14 +1417,8 @@ ResidentRunner setUpResidentRunner(
);
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeWebServerDevice extends FakeDevice implements WebServerDevice {}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeDevice extends Fake implements Device {
@override
String name = 'FakeDevice';
......@@ -1494,10 +1488,6 @@ class FakeAppConnection extends Fake implements AppConnection {
ranMain = true;
}
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeChromeDevice extends Fake implements ChromiumDevice {}
class FakeWipDebugger extends Fake implements WipDebugger {}
......
......@@ -2677,9 +2677,6 @@ class FakeXcdevice extends Fake implements XCDevice {
class FakeIOSWorkflow extends Fake implements IOSWorkflow {}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeDevice extends Fake implements Device {
FakeDevice({
String? deviceId,
......@@ -2776,9 +2773,6 @@ class FakeDevice extends Fake implements Device {
getNameForTargetPlatform(await targetPlatform);
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeIOSDevice extends Fake implements IOSDevice {
FakeIOSDevice({
String? deviceId,
......
......@@ -1322,9 +1322,6 @@ class FakeResidentDevtoolsHandler extends Fake implements ResidentDevtoolsHandle
}
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeDevice extends Fake implements Device {
@override
bool isSupported() => true;
......
......@@ -874,9 +874,6 @@ class MockVMService extends Fake implements vm_service.VmService {
}
}
// Unfortunately Device, despite not being immutable, has an `operator ==`.
// Until we fix that, we have to also ignore related lints here.
// ignore: avoid_implementing_value_types
class FakeDevice extends Fake implements Device { }
/// A [WebSocketConnector] that always throws an [io.SocketException].
......
......@@ -71,9 +71,9 @@ void main() {
releaseAssetServer = ReleaseAssetServer(
globals.fs.file('main.dart').uri,
fileSystem: globals.fs,
flutterRoot: null, // ignore: avoid_redundant_argument_values
flutterRoot: null,
platform: FakePlatform(),
webBuildDirectory: null, // ignore: avoid_redundant_argument_values
webBuildDirectory: null,
);
}, overrides: <Type, Generator>{
Logger: () => logger,
......@@ -665,7 +665,7 @@ void main() {
tlsCertPath: null,
tlsCertKeyPath: null,
packagesFilePath: '.packages',
urlTunneller: null, // ignore: avoid_redundant_argument_values
urlTunneller: null,
useSseForDebugProxy: true,
useSseForDebugBackend: true,
useSseForInjectedClient: true,
......@@ -681,9 +681,9 @@ void main() {
enableDds: false,
entrypoint: Uri.base,
testMode: true,
expressionCompiler: null, // ignore: avoid_redundant_argument_values
expressionCompiler: null,
extraHeaders: const <String, String>{},
chromiumLauncher: null, // ignore: avoid_redundant_argument_values
chromiumLauncher: null,
nullSafetyMode: NullSafetyMode.unsound,
);
webDevFS.requireJS.createSync(recursive: true);
......@@ -782,7 +782,7 @@ void main() {
tlsCertPath: null,
tlsCertKeyPath: null,
packagesFilePath: '.packages',
urlTunneller: null, // ignore: avoid_redundant_argument_values
urlTunneller: null,
useSseForDebugProxy: true,
useSseForDebugBackend: true,
useSseForInjectedClient: true,
......@@ -797,9 +797,9 @@ void main() {
enableDds: false,
entrypoint: Uri.base,
testMode: true,
expressionCompiler: null, // ignore: avoid_redundant_argument_values
expressionCompiler: null,
extraHeaders: const <String, String>{},
chromiumLauncher: null, // ignore: avoid_redundant_argument_values
chromiumLauncher: null,
nullSafetyMode: NullSafetyMode.sound,
);
webDevFS.requireJS.createSync(recursive: true);
......@@ -960,7 +960,7 @@ void main() {
tlsCertPath: null,
tlsCertKeyPath: null,
packagesFilePath: '.packages',
urlTunneller: null, // ignore: avoid_redundant_argument_values
urlTunneller: null,
useSseForDebugProxy: true,
useSseForDebugBackend: true,
useSseForInjectedClient: true,
......@@ -969,9 +969,9 @@ void main() {
enableDds: false,
entrypoint: Uri.base,
testMode: true,
expressionCompiler: null, // ignore: avoid_redundant_argument_values
expressionCompiler: null,
extraHeaders: const <String, String>{},
chromiumLauncher: null, // ignore: avoid_redundant_argument_values
chromiumLauncher: null,
nullAssertions: true,
nativeNullAssertions: true,
nullSafetyMode: NullSafetyMode.sound,
......@@ -998,7 +998,7 @@ void main() {
tlsCertPath: null,
tlsCertKeyPath: null,
packagesFilePath: '.packages',
urlTunneller: null, // ignore: avoid_redundant_argument_values
urlTunneller: null,
useSseForDebugProxy: true,
useSseForDebugBackend: true,
useSseForInjectedClient: true,
......@@ -1016,9 +1016,9 @@ void main() {
enableDds: false,
entrypoint: Uri.base,
testMode: true,
expressionCompiler: null, // ignore: avoid_redundant_argument_values
expressionCompiler: null,
extraHeaders: const <String, String>{},
chromiumLauncher: null, // ignore: avoid_redundant_argument_values
chromiumLauncher: null,
nullSafetyMode: NullSafetyMode.sound,
);
webDevFS.requireJS.createSync(recursive: true);
......@@ -1044,7 +1044,7 @@ void main() {
tlsCertPath: null,
tlsCertKeyPath: null,
packagesFilePath: '.packages',
urlTunneller: null, // ignore: avoid_redundant_argument_values
urlTunneller: null,
useSseForDebugProxy: true,
useSseForDebugBackend: true,
useSseForInjectedClient: true,
......@@ -1062,9 +1062,9 @@ void main() {
enableDds: false,
entrypoint: Uri.base,
testMode: true,
expressionCompiler: null, // ignore: avoid_redundant_argument_values
expressionCompiler: null,
extraHeaders: const <String, String>{},
chromiumLauncher: null, // ignore: avoid_redundant_argument_values
chromiumLauncher: null,
nullSafetyMode: NullSafetyMode.sound,
);
webDevFS.requireJS.createSync(recursive: true);
......@@ -1098,7 +1098,7 @@ void main() {
tlsCertPath: dummyCertPath,
tlsCertKeyPath: dummyCertKeyPath,
packagesFilePath: '.packages',
urlTunneller: null, // ignore: avoid_redundant_argument_values
urlTunneller: null,
useSseForDebugProxy: true,
useSseForDebugBackend: true,
useSseForInjectedClient: true,
......@@ -1109,9 +1109,9 @@ void main() {
enableDds: false,
entrypoint: Uri.base,
testMode: true,
expressionCompiler: null, // ignore: avoid_redundant_argument_values
expressionCompiler: null,
extraHeaders: const <String, String>{},
chromiumLauncher: null, // ignore: avoid_redundant_argument_values
chromiumLauncher: null,
nullSafetyMode: NullSafetyMode.unsound,
);
webDevFS.requireJS.createSync(recursive: true);
......@@ -1243,7 +1243,7 @@ void main() {
tlsCertPath: null,
tlsCertKeyPath: null,
packagesFilePath: '.packages',
urlTunneller: null, // ignore: avoid_redundant_argument_values
urlTunneller: null,
useSseForDebugProxy: true,
useSseForDebugBackend: true,
useSseForInjectedClient: true,
......@@ -1254,9 +1254,9 @@ void main() {
enableDds: false,
entrypoint: Uri.base,
testMode: true,
expressionCompiler: null, // ignore: avoid_redundant_argument_values
expressionCompiler: null,
extraHeaders: const <String, String>{},
chromiumLauncher: null, // ignore: avoid_redundant_argument_values
chromiumLauncher: null,
nullSafetyMode: NullSafetyMode.unsound,
);
webDevFS.requireJS.createSync(recursive: true);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment