Commit 68369e9d authored by Hixie's avatar Hixie

Style guide says enum values should be lowerCamelCase.

https://www.dartlang.org/articles/style-guide/#names

R=jackson@google.com

Review URL: https://codereview.chromium.org/1158813004
parent 3b06e1e1
...@@ -53,7 +53,7 @@ void main() { ...@@ -53,7 +53,7 @@ void main() {
child.parentData.flex = flex; child.parentData.flex = flex;
} }
var row = new RenderFlex(direction: FlexDirection.Horizontal); var row = new RenderFlex(direction: FlexDirection.horizontal);
// Left cell // Left cell
addFlexChildSolidColor(row, const Color(0xFF00D2B8), flex: 1); addFlexChildSolidColor(row, const Color(0xFF00D2B8), flex: 1);
...@@ -64,7 +64,7 @@ void main() { ...@@ -64,7 +64,7 @@ void main() {
var padding = new RenderPadding(padding: const EdgeDims.all(10.0), child: image); var padding = new RenderPadding(padding: const EdgeDims.all(10.0), child: image);
row.add(padding); row.add(padding);
RenderFlex column = new RenderFlex(direction: FlexDirection.Vertical); RenderFlex column = new RenderFlex(direction: FlexDirection.vertical);
// Top cell // Top cell
addFlexChildSolidColor(column, const Color(0xFF55DDCA), flex: 1); addFlexChildSolidColor(column, const Color(0xFF55DDCA), flex: 1);
......
...@@ -13,7 +13,7 @@ import '../lib/solid_color_box.dart'; ...@@ -13,7 +13,7 @@ import '../lib/solid_color_box.dart';
AppView app; AppView app;
void main() { void main() {
RenderFlex flexRoot = new RenderFlex(direction: FlexDirection.Vertical); RenderFlex flexRoot = new RenderFlex(direction: FlexDirection.vertical);
RenderObject root = new RenderDecoratedBox( RenderObject root = new RenderDecoratedBox(
decoration: new BoxDecoration(backgroundColor: const Color(0xFF606060)), decoration: new BoxDecoration(backgroundColor: const Color(0xFF606060)),
......
...@@ -26,7 +26,7 @@ import 'package:sky/framework/rendering/box.dart'; ...@@ -26,7 +26,7 @@ import 'package:sky/framework/rendering/box.dart';
import 'dart:async'; import 'dart:async';
import 'dart:sky' as sky; import 'dart:sky' as sky;
enum StockMode { Optimistic, Pessimistic } enum StockMode { optimistic, pessimistic }
class StocksApp extends App { class StocksApp extends App {
...@@ -106,7 +106,7 @@ class StocksApp extends App { ...@@ -106,7 +106,7 @@ class StocksApp extends App {
}); });
} }
StockMode _stockMode = StockMode.Optimistic; StockMode _stockMode = StockMode.optimistic;
void _handleStockModeChange(StockMode value) { void _handleStockModeChange(StockMode value) {
setState(() { setState(() {
_stockMode = value; _stockMode = value;
...@@ -133,18 +133,18 @@ class StocksApp extends App { ...@@ -133,18 +133,18 @@ class StocksApp extends App {
// new MenuItem( // new MenuItem(
// key: 'Optimistic Menu Item', // key: 'Optimistic Menu Item',
// icon: 'action/thumb_up', // icon: 'action/thumb_up',
// onGestureTap: (event) => _handleStockModeChange(StockMode.Optimistic), // onGestureTap: (event) => _handleStockModeChange(StockMode.optimistic),
// children: [ // children: [
// new ParentDataNode(new Text('Optimistic'), _flex1), // new ParentDataNode(new Text('Optimistic'), _flex1),
// new Radio(key: 'optimistic-radio', value: StockMode.Optimistic, groupValue: _stockMode, onChanged: _handleStockModeChange) // new Radio(key: 'optimistic-radio', value: StockMode.optimistic, groupValue: _stockMode, onChanged: _handleStockModeChange)
// ]), // ]),
// new MenuItem( // new MenuItem(
// key: 'Pessimistic Menu Item', // key: 'Pessimistic Menu Item',
// icon: 'action/thumb_down', // icon: 'action/thumb_down',
// onGestureTap: (event) => _handleStockModeChange(StockMode.Pessimistic), // onGestureTap: (event) => _handleStockModeChange(StockMode.pessimistic),
// children: [ // children: [
// new ParentDataNode(new Text('Pessimistic'), _flex1), // new ParentDataNode(new Text('Pessimistic'), _flex1),
// new Radio(key: 'pessimistic-radio', value: StockMode.Pessimistic, groupValue: _stockMode, onChanged: _handleStockModeChange) // new Radio(key: 'pessimistic-radio', value: StockMode.pessimistic, groupValue: _stockMode, onChanged: _handleStockModeChange)
// ]), // ]),
// new MenuDivider(key: 'div2'), // new MenuDivider(key: 'div2'),
new MenuItem( new MenuItem(
......
...@@ -79,7 +79,7 @@ class StockArrow extends Component { ...@@ -79,7 +79,7 @@ class StockArrow extends Component {
return new FlexContainer( return new FlexContainer(
inlineStyle: 'border-color: $border', inlineStyle: 'border-color: $border',
direction: FlexDirection.Row, direction: FlexDirection.horizontal,
style: _style, style: _style,
children: [ children: [
new Container( new Container(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment