Unverified Commit 67a57eb9 authored by Jonah Williams's avatar Jonah Williams Committed by GitHub

[flutter_tools] remove feature for alternative invalidation strategy (#84366)

parent 01e823c4
...@@ -47,9 +47,6 @@ abstract class FeatureFlags { ...@@ -47,9 +47,6 @@ abstract class FeatureFlags {
/// Whether fast single widget reloads are enabled. /// Whether fast single widget reloads are enabled.
bool get isSingleWidgetReloadEnabled => false; bool get isSingleWidgetReloadEnabled => false;
/// Whether the CFE experimental invalidation strategy is enabled.
bool get isExperimentalInvalidationStrategyEnabled => true;
/// Whether the windows UWP embedding is enabled. /// Whether the windows UWP embedding is enabled.
bool get isWindowsUwpEnabled => false; bool get isWindowsUwpEnabled => false;
...@@ -71,7 +68,6 @@ const List<Feature> allFeatures = <Feature>[ ...@@ -71,7 +68,6 @@ const List<Feature> allFeatures = <Feature>[
flutterIOSFeature, flutterIOSFeature,
flutterFuchsiaFeature, flutterFuchsiaFeature,
flutterCustomDevicesFeature, flutterCustomDevicesFeature,
experimentalInvalidationStrategy,
]; ];
/// The [Feature] for flutter web. /// The [Feature] for flutter web.
...@@ -270,29 +266,6 @@ const Feature singleWidgetReload = Feature( ...@@ -270,29 +266,6 @@ const Feature singleWidgetReload = Feature(
), ),
); );
/// The CFE experimental invalidation strategy.
const Feature experimentalInvalidationStrategy = Feature(
name: 'Hot reload optimization that reduces incremental artifact size',
configSetting: 'experimental-invalidation-strategy',
environmentOverride: 'FLUTTER_CFE_EXPERIMENTAL_INVALIDATION',
master: FeatureChannelSetting(
available: true,
enabledByDefault: true,
),
dev: FeatureChannelSetting(
available: true,
enabledByDefault: true,
),
beta: FeatureChannelSetting(
available: true,
enabledByDefault: true,
),
stable: FeatureChannelSetting(
available: true,
enabledByDefault: true,
),
);
/// The feature for enabling the Windows UWP embedding. /// The feature for enabling the Windows UWP embedding.
const Feature windowsUwpEmbedding = Feature( const Feature windowsUwpEmbedding = Feature(
name: 'Flutter for Windows UWP', name: 'Flutter for Windows UWP',
......
...@@ -47,9 +47,6 @@ class FlutterFeatureFlags implements FeatureFlags { ...@@ -47,9 +47,6 @@ class FlutterFeatureFlags implements FeatureFlags {
@override @override
bool get isSingleWidgetReloadEnabled => isEnabled(singleWidgetReload); bool get isSingleWidgetReloadEnabled => isEnabled(singleWidgetReload);
@override
bool get isExperimentalInvalidationStrategyEnabled => isEnabled(experimentalInvalidationStrategy);
@override @override
bool get isWindowsUwpEnabled => isEnabled(windowsUwpEmbedding); bool get isWindowsUwpEnabled => isEnabled(windowsUwpEmbedding);
......
...@@ -151,7 +151,6 @@ class FlutterDevice { ...@@ -151,7 +151,6 @@ class FlutterDevice {
extraFrontEndOptions = <String>[ extraFrontEndOptions = <String>[
if (featureFlags.isSingleWidgetReloadEnabled) if (featureFlags.isSingleWidgetReloadEnabled)
'--flutter-widget-cache', '--flutter-widget-cache',
if (featureFlags.isExperimentalInvalidationStrategyEnabled)
'--enable-experiment=alternative-invalidation-strategy', '--enable-experiment=alternative-invalidation-strategy',
...?extraFrontEndOptions, ...?extraFrontEndOptions,
]; ];
......
...@@ -2037,7 +2037,7 @@ void main() { ...@@ -2037,7 +2037,7 @@ void main() {
FeatureFlags: () => TestFeatureFlags(isSingleWidgetReloadEnabled: true) FeatureFlags: () => TestFeatureFlags(isSingleWidgetReloadEnabled: true)
}); });
testUsingContext('FlutterDevice passes alternative-invalidation-strategy flag when feature is enabled', () async { testUsingContext('FlutterDevice passes alternative-invalidation-strategy flag', () async {
fakeVmServiceHost = FakeVmServiceHost(requests: <VmServiceExpectation>[]); fakeVmServiceHost = FakeVmServiceHost(requests: <VmServiceExpectation>[]);
final FakeDevice mockDevice = FakeDevice(targetPlatform: TargetPlatform.android_arm); final FakeDevice mockDevice = FakeDevice(targetPlatform: TargetPlatform.android_arm);
...@@ -2059,7 +2059,6 @@ void main() { ...@@ -2059,7 +2059,6 @@ void main() {
Artifacts: () => Artifacts.test(), Artifacts: () => Artifacts.test(),
FileSystem: () => MemoryFileSystem.test(), FileSystem: () => MemoryFileSystem.test(),
ProcessManager: () => FakeProcessManager.any(), ProcessManager: () => FakeProcessManager.any(),
FeatureFlags: () => TestFeatureFlags(isExperimentalInvalidationStrategyEnabled: true)
}); });
testUsingContext('FlutterDevice passes initializeFromDill parameter if specified', () async { testUsingContext('FlutterDevice passes initializeFromDill parameter if specified', () async {
......
...@@ -415,7 +415,6 @@ class TestFeatureFlags implements FeatureFlags { ...@@ -415,7 +415,6 @@ class TestFeatureFlags implements FeatureFlags {
this.isIOSEnabled = true, this.isIOSEnabled = true,
this.isFuchsiaEnabled = false, this.isFuchsiaEnabled = false,
this.areCustomDevicesEnabled = false, this.areCustomDevicesEnabled = false,
this.isExperimentalInvalidationStrategyEnabled = false,
this.isWindowsUwpEnabled = false, this.isWindowsUwpEnabled = false,
}); });
...@@ -446,9 +445,6 @@ class TestFeatureFlags implements FeatureFlags { ...@@ -446,9 +445,6 @@ class TestFeatureFlags implements FeatureFlags {
@override @override
final bool areCustomDevicesEnabled; final bool areCustomDevicesEnabled;
@override
final bool isExperimentalInvalidationStrategyEnabled;
@override @override
final bool isWindowsUwpEnabled; final bool isWindowsUwpEnabled;
...@@ -473,8 +469,6 @@ class TestFeatureFlags implements FeatureFlags { ...@@ -473,8 +469,6 @@ class TestFeatureFlags implements FeatureFlags {
return isFuchsiaEnabled; return isFuchsiaEnabled;
case flutterCustomDevicesFeature: case flutterCustomDevicesFeature:
return areCustomDevicesEnabled; return areCustomDevicesEnabled;
case experimentalInvalidationStrategy:
return isExperimentalInvalidationStrategyEnabled;
case windowsUwpEmbedding: case windowsUwpEmbedding:
return isWindowsUwpEnabled; return isWindowsUwpEnabled;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment