Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
678da3ac
Commit
678da3ac
authored
Sep 12, 2016
by
Dan Rubel
Committed by
GitHub
Sep 12, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
cancel open subscription (#5824)
fixes
https://github.com/flutter/flutter/issues/5788
parent
4ea8f302
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
2 deletions
+3
-2
.analysis_options
.analysis_options
+1
-1
.analysis_options_flutter_analyze
.analysis_options_flutter_analyze
+1
-1
process.dart
packages/flutter_tools/lib/src/base/process.dart
+1
-0
No files found.
.analysis_options
View file @
678da3ac
...
@@ -38,7 +38,7 @@ linter:
...
@@ -38,7 +38,7 @@ linter:
# === error rules ===
# === error rules ===
- avoid_empty_else
- avoid_empty_else
# - comment_references # blocked on https://github.com/dart-lang/dartdoc/issues/1153
# - comment_references # blocked on https://github.com/dart-lang/dartdoc/issues/1153
# - cancel_subscriptions # https://github.com/flutter/flutter/issues/5788
- cancel_subscriptions
# - close_sinks # https://github.com/flutter/flutter/issues/5789
# - close_sinks # https://github.com/flutter/flutter/issues/5789
- control_flow_in_finally
- control_flow_in_finally
- empty_statements
- empty_statements
...
...
.analysis_options_flutter_analyze
View file @
678da3ac
...
@@ -39,7 +39,7 @@ linter:
...
@@ -39,7 +39,7 @@ linter:
# === error rules ===
# === error rules ===
- avoid_empty_else
- avoid_empty_else
# - comment_references # blocked on https://github.com/dart-lang/dartdoc/issues/1153
# - comment_references # blocked on https://github.com/dart-lang/dartdoc/issues/1153
# - cancel_subscriptions # https://github.com/flutter/flutter/issues/5788
- cancel_subscriptions
# - close_sinks # https://github.com/flutter/flutter/issues/5789
# - close_sinks # https://github.com/flutter/flutter/issues/5789
- control_flow_in_finally
- control_flow_in_finally
- empty_statements
- empty_statements
...
...
packages/flutter_tools/lib/src/base/process.dart
View file @
678da3ac
...
@@ -78,6 +78,7 @@ Future<int> runCommandAndStreamOutput(List<String> cmd, {
...
@@ -78,6 +78,7 @@ Future<int> runCommandAndStreamOutput(List<String> cmd, {
// Wait for stdout to be fully processed
// Wait for stdout to be fully processed
// because process.exitCode may complete first causing flaky tests.
// because process.exitCode may complete first causing flaky tests.
await
subscription
.
asFuture
();
await
subscription
.
asFuture
();
subscription
.
cancel
();
return
await
process
.
exitCode
;
return
await
process
.
exitCode
;
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment