Unverified Commit 65985db1 authored by Danny Tuppeny's avatar Danny Tuppeny Committed by GitHub

Double all timeouts on flutter_tools integration tests (#20872)

Due to CPU contention we've seen these go really slow on Cirrus (see https://github.com/flutter/flutter/issues/19542#issuecomment-414265152), and there's also a chance our flakes are timeouts due to running slow rather than hanging.
parent 18e7549b
...@@ -110,5 +110,5 @@ void main() { ...@@ -110,5 +110,5 @@ void main() {
// https://github.com/flutter/flutter/issues/17833 // https://github.com/flutter/flutter/issues/17833
// The test appears to be flaky and time out some times, skipping while // The test appears to be flaky and time out some times, skipping while
// investigation is ongoing: https://github.com/flutter/flutter/issues/19542 // investigation is ongoing: https://github.com/flutter/flutter/issues/19542
}, timeout: const Timeout.factor(3), skip: true); }, timeout: const Timeout.factor(6), skip: true);
} }
...@@ -36,5 +36,5 @@ void main() { ...@@ -36,5 +36,5 @@ void main() {
await _flutterAttach.hotReload(); await _flutterAttach.hotReload();
}); });
// TODO(dantup): Unskip after https://github.com/flutter/flutter/issues/17833. // TODO(dantup): Unskip after https://github.com/flutter/flutter/issues/17833.
}, timeout: const Timeout.factor(3), skip: platform.isWindows); }, timeout: const Timeout.factor(6), skip: platform.isWindows);
} }
...@@ -45,5 +45,5 @@ void main() { ...@@ -45,5 +45,5 @@ void main() {
expect(isolate.pauseEvent, isInstanceOf<VMPauseBreakpointEvent>()); expect(isolate.pauseEvent, isInstanceOf<VMPauseBreakpointEvent>());
// TODO(dantup): Unskip after https://github.com/flutter/flutter/issues/18441. // TODO(dantup): Unskip after https://github.com/flutter/flutter/issues/18441.
}, skip: !platform.isLinux); }, skip: !platform.isLinux);
}, timeout: const Timeout.factor(3)); }, timeout: const Timeout.factor(6));
} }
...@@ -46,5 +46,5 @@ void main() { ...@@ -46,5 +46,5 @@ void main() {
expect(_flutter.hasExited, equals(false)); expect(_flutter.hasExited, equals(false));
}); });
// TODO(dantup): Unskip after https://github.com/flutter/flutter/issues/17833. // TODO(dantup): Unskip after https://github.com/flutter/flutter/issues/17833.
}, timeout: const Timeout.factor(3), skip: platform.isWindows); }, timeout: const Timeout.factor(6), skip: platform.isWindows);
} }
...@@ -18,9 +18,9 @@ import '../src/common.dart'; ...@@ -18,9 +18,9 @@ import '../src/common.dart';
// Set this to true for debugging to get JSON written to stdout. // Set this to true for debugging to get JSON written to stdout.
const bool _printJsonAndStderr = false; const bool _printJsonAndStderr = false;
const Duration defaultTimeout = Duration(seconds: 20); const Duration defaultTimeout = Duration(seconds: 40);
const Duration appStartTimeout = Duration(seconds: 60); const Duration appStartTimeout = Duration(seconds: 120);
const Duration quitTimeout = Duration(seconds: 5); const Duration quitTimeout = Duration(seconds: 10);
class FlutterTestDriver { class FlutterTestDriver {
FlutterTestDriver(this._projectFolder); FlutterTestDriver(this._projectFolder);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment