Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
610ee89b
Unverified
Commit
610ee89b
authored
Jun 28, 2021
by
Jenn Magder
Committed by
GitHub
Jun 28, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Address jmagman todos (#85348)
parent
2034f74e
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
9 additions
and
26 deletions
+9
-26
build_ios_framework_module_test.dart
dev/devicelab/bin/tasks/build_ios_framework_module_test.dart
+8
-20
gradle_non_android_plugin_test.dart
dev/devicelab/bin/tasks/gradle_non_android_plugin_test.dart
+1
-2
ios_app_with_extensions_test.dart
dev/devicelab/bin/tasks/ios_app_with_extensions_test.dart
+0
-4
No files found.
dev/devicelab/bin/tasks/build_ios_framework_module_test.dart
View file @
610ee89b
...
...
@@ -239,36 +239,24 @@ Future<void> _testBuildIosFramework(Directory projectDir, { bool isModule = fals
await
_checkBitcode
(
engineFrameworkPath
,
mode
);
// TODO(jmagman): Remove ios-x86_64-simulator checks when the ARM simulator engine artifacts rolls.
final
String
x86SimulatorFramework
=
path
.
join
(
checkFileExists
(
path
.
join
(
outputPath
,
mode
,
'Flutter.xcframework'
,
'ios-x86_64-simulator'
,
'ios-
arm64_
x86_64-simulator'
,
'Flutter.framework'
,
);
'Flutter'
,
));
final
String
x86ArmSimulatorFramework
=
path
.
join
(
checkFileExists
(
path
.
join
(
outputPath
,
mode
,
'Flutter.xcframework'
,
'ios-arm64_x86_64-simulator'
,
'Flutter.framework'
,
);
final
bool
x86SimulatorBinaryExists
=
exists
(
File
(
path
.
join
(
x86SimulatorFramework
,
'Flutter'
)));
final
bool
x86ArmSimulatorBinaryExists
=
exists
(
File
(
path
.
join
(
x86ArmSimulatorFramework
,
'Flutter'
)));
if
(!
x86SimulatorBinaryExists
&&
!
x86ArmSimulatorBinaryExists
)
{
throw
TaskResult
.
failure
(
'Expected Flutter engine artifact binary to exist'
);
}
final
bool
x86SimulatorHeaderExists
=
exists
(
File
(
path
.
join
(
x86SimulatorFramework
,
'Headers'
,
'Flutter.h'
)));
final
bool
x86ArmSimulatorHeaderExists
=
exists
(
File
(
path
.
join
(
x86ArmSimulatorFramework
,
'Headers'
,
'Flutter.h'
)));
if
(!
x86SimulatorHeaderExists
&&
!
x86ArmSimulatorHeaderExists
)
{
throw
TaskResult
.
failure
(
'Expected Flutter.h engine artifact to exist'
);
}
'Headers'
,
'Flutter.h'
,
));
}
section
(
'Check all modes have plugins'
);
...
...
dev/devicelab/bin/tasks/gradle_non_android_plugin_test.dart
View file @
610ee89b
...
...
@@ -9,8 +9,7 @@ import 'package:flutter_devicelab/framework/task_result.dart';
Future
<
void
>
main
()
async
{
await
task
(()
async
{
// TODO(jmagman): Remove once gradle_non_android_plugin_test builder can be deleted
// when https://github.com/flutter/flutter/pull/80161 rolls to stable.
// TODO(jmagman): Remove once gradle_non_android_plugin_test builder can be deleted, https://github.com/flutter/flutter/issues/85347
return
TaskResult
.
success
(
null
);
});
}
dev/devicelab/bin/tasks/ios_app_with_extensions_test.dart
View file @
610ee89b
...
...
@@ -32,10 +32,6 @@ Future<void> main() async {
projectDir
,
);
// For some reason devicelab machines have really old spec snapshots.
// TODO(jmagman): Remove this if this test is moved to a machine that installs CocoaPods on every run.
await
eval
(
'pod'
,
<
String
>[
'repo'
,
'update'
,
'--verbose'
]);
section
(
'Create release build'
);
await
inDirectory
(
projectDir
,
()
async
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment