Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
6054eda8
Unverified
Commit
6054eda8
authored
Dec 29, 2021
by
Christopher Fujino
Committed by
GitHub
Dec 29, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix lateinitialization error in devicelab-runner (#94957)
parent
2d2cd1f5
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
4 deletions
+7
-4
module_test_ios.dart
dev/devicelab/bin/tasks/module_test_ios.dart
+3
-1
ios.dart
dev/devicelab/lib/framework/ios.dart
+4
-3
No files found.
dev/devicelab/bin/tasks/module_test_ios.dart
View file @
6054eda8
...
...
@@ -18,7 +18,9 @@ import 'package:path/path.dart' as path;
/// adding Flutter to an existing iOS app.
Future
<
void
>
main
()
async
{
await
task
(()
async
{
late
String
simulatorDeviceId
;
// this variable cannot be `late`, as we reference it in the `finally` block
// which may execute before this field has been initialized
String
?
simulatorDeviceId
;
section
(
'Create Flutter module project'
);
final
Directory
tempDir
=
Directory
.
systemTemp
.
createTempSync
(
'flutter_module_test.'
);
...
...
dev/devicelab/lib/framework/ios.dart
View file @
6054eda8
...
...
@@ -116,14 +116,14 @@ Future<void> testWithNewIOSSimulator(
}
/// Shuts down and deletes simulator with deviceId.
Future
<
void
>
removeIOSimulator
(
String
deviceId
)
async
{
Future
<
void
>
removeIOSimulator
(
String
?
deviceId
)
async
{
if
(
deviceId
!=
null
&&
deviceId
!=
''
)
{
await
eval
(
'xcrun'
,
<
String
>[
'simctl'
,
'shutdown'
,
deviceId
deviceId
,
],
canFail:
true
,
workingDirectory:
flutterDirectory
.
path
,
...
...
@@ -133,7 +133,8 @@ Future<void> removeIOSimulator(String deviceId) async {
<
String
>[
'simctl'
,
'delete'
,
deviceId
],
deviceId
,
],
canFail:
true
,
workingDirectory:
flutterDirectory
.
path
,
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment