Unverified Commit 5e8b5f4e authored by Taha Tesser's avatar Taha Tesser Committed by GitHub

Update `ColorScheme.fromSwatch` docs for Material 3 (#136816)

part of [Clarify ColorScheme fromSwatch/fromSeed usage](https://github.com/flutter/flutter/issues/132584)
parent e8691444
...@@ -455,10 +455,16 @@ class ColorScheme with Diagnosticable { ...@@ -455,10 +455,16 @@ class ColorScheme with Diagnosticable {
_inversePrimary = inversePrimary, _inversePrimary = inversePrimary,
_surfaceTint = surfaceTint; _surfaceTint = surfaceTint;
/// Create a color scheme from a [MaterialColor] swatch. /// Creates a color scheme from a [MaterialColor] swatch.
/// ///
/// This constructor is used by [ThemeData] to create its default /// In Material 3, this constructor is ignored by [ThemeData] when creating
/// color scheme. /// its default color scheme. Instead, [ThemeData] uses [ ColorScheme.fromSeed]
/// to create its default color scheme. This constructor shouldn't be used
/// to update the Material 3 color scheme. It will be phased out gradually;
/// see https://github.com/flutter/flutter/issues/91772 for more details.
///
/// If [ThemeData.useMaterial3] is false, then this constructor is used by
/// [ThemeData] to create its default color scheme.
factory ColorScheme.fromSwatch({ factory ColorScheme.fromSwatch({
MaterialColor primarySwatch = Colors.blue, MaterialColor primarySwatch = Colors.blue,
Color? accentColor, Color? accentColor,
...@@ -467,7 +473,6 @@ class ColorScheme with Diagnosticable { ...@@ -467,7 +473,6 @@ class ColorScheme with Diagnosticable {
Color? errorColor, Color? errorColor,
Brightness brightness = Brightness.light, Brightness brightness = Brightness.light,
}) { }) {
final bool isDark = brightness == Brightness.dark; final bool isDark = brightness == Brightness.dark;
final bool primaryIsDark = _brightnessFor(primarySwatch) == Brightness.dark; final bool primaryIsDark = _brightnessFor(primarySwatch) == Brightness.dark;
final Color secondary = accentColor ?? (isDark ? Colors.tealAccent[200]! : primarySwatch); final Color secondary = accentColor ?? (isDark ? Colors.tealAccent[200]! : primarySwatch);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment