Unverified Commit 58bd39cd authored by Alexandre Ardhuin's avatar Alexandre Ardhuin Committed by GitHub

Extract some onPress methods (#40678)

* Extract some onPress methods

* address review comments
parent c17086a0
...@@ -64,7 +64,54 @@ class _CupertinoAlertDemoState extends State<CupertinoAlertDemo> { ...@@ -64,7 +64,54 @@ class _CupertinoAlertDemoState extends State<CupertinoAlertDemo> {
children: <Widget>[ children: <Widget>[
CupertinoButton.filled( CupertinoButton.filled(
child: const Text('Alert'), child: const Text('Alert'),
onPressed: () => _onAlertPress(context),
),
const Padding(padding: EdgeInsets.all(8.0)),
CupertinoButton.filled(
child: const Text('Alert with Title'),
padding: const EdgeInsets.symmetric(vertical: 16.0, horizontal: 36.0),
onPressed: () => _onAlertWithTitlePress(context),
),
const Padding(padding: EdgeInsets.all(8.0)),
CupertinoButton.filled(
child: const Text('Alert with Buttons'),
padding: const EdgeInsets.symmetric(vertical: 16.0, horizontal: 36.0),
onPressed: () => _onAlertWithButtonsPress(context),
),
const Padding(padding: EdgeInsets.all(8.0)),
CupertinoButton.filled(
child: const Text('Alert Buttons Only'),
padding: const EdgeInsets.symmetric(vertical: 16.0, horizontal: 36.0),
onPressed: () { onPressed: () {
showDemoDialog(
context: context,
child: const CupertinoDessertDialog(),
);
},
),
const Padding(padding: EdgeInsets.all(8.0)),
CupertinoButton.filled(
child: const Text('Action Sheet'),
padding: const EdgeInsets.symmetric(vertical: 16.0, horizontal: 36.0),
onPressed: () => _onActionSheetPress(context),
),
],
),
),
if (lastSelectedValue != null)
Positioned(
bottom: 32.0,
child: Text('You selected: $lastSelectedValue'),
),
],
);
},
),
),
);
}
void _onAlertPress(BuildContext context) {
showDemoDialog( showDemoDialog(
context: context, context: context,
child: CupertinoAlertDialog( child: CupertinoAlertDialog(
...@@ -73,27 +120,19 @@ class _CupertinoAlertDemoState extends State<CupertinoAlertDemo> { ...@@ -73,27 +120,19 @@ class _CupertinoAlertDemoState extends State<CupertinoAlertDemo> {
CupertinoDialogAction( CupertinoDialogAction(
child: const Text('Discard'), child: const Text('Discard'),
isDestructiveAction: true, isDestructiveAction: true,
onPressed: () { onPressed: () => Navigator.pop(context, 'Discard'),
Navigator.pop(context, 'Discard');
},
), ),
CupertinoDialogAction( CupertinoDialogAction(
child: const Text('Cancel'), child: const Text('Cancel'),
isDefaultAction: true, isDefaultAction: true,
onPressed: () { onPressed: () => Navigator.pop(context, 'Cancel'),
Navigator.pop(context, 'Cancel');
},
), ),
], ],
), ),
); );
}, }
),
const Padding(padding: EdgeInsets.all(8.0)), void _onAlertWithTitlePress(BuildContext context) {
CupertinoButton.filled(
child: const Text('Alert with Title'),
padding: const EdgeInsets.symmetric(vertical: 16.0, horizontal: 36.0),
onPressed: () {
showDemoDialog( showDemoDialog(
context: context, context: context,
child: CupertinoAlertDialog( child: CupertinoAlertDialog(
...@@ -103,26 +142,18 @@ class _CupertinoAlertDemoState extends State<CupertinoAlertDemo> { ...@@ -103,26 +142,18 @@ class _CupertinoAlertDemoState extends State<CupertinoAlertDemo> {
actions: <Widget>[ actions: <Widget>[
CupertinoDialogAction( CupertinoDialogAction(
child: const Text('Don\'t Allow'), child: const Text('Don\'t Allow'),
onPressed: () { onPressed: () => Navigator.pop(context, 'Disallow'),
Navigator.pop(context, 'Disallow');
},
), ),
CupertinoDialogAction( CupertinoDialogAction(
child: const Text('Allow'), child: const Text('Allow'),
onPressed: () { onPressed: () => Navigator.pop(context, 'Allow'),
Navigator.pop(context, 'Allow');
},
), ),
], ],
), ),
); );
}, }
),
const Padding(padding: EdgeInsets.all(8.0)), void _onAlertWithButtonsPress(BuildContext context) {
CupertinoButton.filled(
child: const Text('Alert with Buttons'),
padding: const EdgeInsets.symmetric(vertical: 16.0, horizontal: 36.0),
onPressed: () {
showDemoDialog( showDemoDialog(
context: context, context: context,
child: const CupertinoDessertDialog( child: const CupertinoDessertDialog(
...@@ -132,24 +163,9 @@ class _CupertinoAlertDemoState extends State<CupertinoAlertDemo> { ...@@ -132,24 +163,9 @@ class _CupertinoAlertDemoState extends State<CupertinoAlertDemo> {
'list of eateries in your area.'), 'list of eateries in your area.'),
), ),
); );
}, }
),
const Padding(padding: EdgeInsets.all(8.0)), void _onActionSheetPress(BuildContext context) {
CupertinoButton.filled(
child: const Text('Alert Buttons Only'),
padding: const EdgeInsets.symmetric(vertical: 16.0, horizontal: 36.0),
onPressed: () {
showDemoDialog(
context: context,
child: const CupertinoDessertDialog(),
);
},
),
const Padding(padding: EdgeInsets.all(8.0)),
CupertinoButton.filled(
child: const Text('Action Sheet'),
padding: const EdgeInsets.symmetric(vertical: 16.0, horizontal: 36.0),
onPressed: () {
showDemoActionSheet( showDemoActionSheet(
context: context, context: context,
child: CupertinoActionSheet( child: CupertinoActionSheet(
...@@ -158,45 +174,21 @@ class _CupertinoAlertDemoState extends State<CupertinoAlertDemo> { ...@@ -158,45 +174,21 @@ class _CupertinoAlertDemoState extends State<CupertinoAlertDemo> {
actions: <Widget>[ actions: <Widget>[
CupertinoActionSheetAction( CupertinoActionSheetAction(
child: const Text('Profiteroles'), child: const Text('Profiteroles'),
onPressed: () { onPressed: () => Navigator.pop(context, 'Profiteroles'),
Navigator.pop(context, 'Profiteroles');
},
), ),
CupertinoActionSheetAction( CupertinoActionSheetAction(
child: const Text('Cannolis'), child: const Text('Cannolis'),
onPressed: () { onPressed: () => Navigator.pop(context, 'Cannolis'),
Navigator.pop(context, 'Cannolis');
},
), ),
CupertinoActionSheetAction( CupertinoActionSheetAction(
child: const Text('Trifle'), child: const Text('Trifle'),
onPressed: () { onPressed: () => Navigator.pop(context, 'Trifle'),
Navigator.pop(context, 'Trifle');
},
), ),
], ],
cancelButton: CupertinoActionSheetAction( cancelButton: CupertinoActionSheetAction(
child: const Text('Cancel'), child: const Text('Cancel'),
isDefaultAction: true, isDefaultAction: true,
onPressed: () { onPressed: () => Navigator.pop(context, 'Cancel'),
Navigator.pop(context, 'Cancel');
},
),
),
);
},
),
],
),
),
if (lastSelectedValue != null)
Positioned(
bottom: 32.0,
child: Text('You selected: $lastSelectedValue'),
),
],
);
},
), ),
), ),
); );
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment