Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
589dd802
Unverified
Commit
589dd802
authored
Jun 15, 2022
by
Christopher Fujino
Committed by
GitHub
Jun 15, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] print override storage warning to STDERR instead of STDOUT (#106068)
parent
261246b8
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
17 additions
and
1 deletion
+17
-1
cache.dart
packages/flutter_tools/lib/src/cache.dart
+1
-1
cache_test.dart
packages/flutter_tools/test/general.shard/cache_test.dart
+16
-0
No files found.
packages/flutter_tools/lib/src/cache.dart
View file @
589dd802
...
@@ -520,7 +520,7 @@ class Cache {
...
@@ -520,7 +520,7 @@ class Cache {
if
(
_hasWarnedAboutStorageOverride
)
{
if
(
_hasWarnedAboutStorageOverride
)
{
return
;
return
;
}
}
_logger
.
print
Status
(
_logger
.
print
Error
(
'Flutter assets will be downloaded from
$overrideUrl
. Make sure you trust this source!'
,
'Flutter assets will be downloaded from
$overrideUrl
. Make sure you trust this source!'
,
emphasis:
true
,
emphasis:
true
,
);
);
...
...
packages/flutter_tools/test/general.shard/cache_test.dart
View file @
589dd802
...
@@ -319,6 +319,22 @@ void main() {
...
@@ -319,6 +319,22 @@ void main() {
expect
(()
=>
cache
.
storageBaseUrl
,
throwsToolExit
());
expect
(()
=>
cache
.
storageBaseUrl
,
throwsToolExit
());
});
});
testWithoutContext
(
'overridden storage base url prints warning to STDERR'
,
()
async
{
final
BufferLogger
logger
=
BufferLogger
.
test
();
const
String
baseUrl
=
'https://storage.com'
;
final
Cache
cache
=
Cache
.
test
(
platform:
FakePlatform
(
environment:
<
String
,
String
>{
'FLUTTER_STORAGE_BASE_URL'
:
baseUrl
,
}),
processManager:
FakeProcessManager
.
any
(),
logger:
logger
,
);
expect
(
cache
.
storageBaseUrl
,
baseUrl
);
expect
(
logger
.
errorText
,
contains
(
'Flutter assets will be downloaded from
$baseUrl
'
));
expect
(
logger
.
statusText
,
isEmpty
);
});
});
});
testWithoutContext
(
'flattenNameSubdirs'
,
()
{
testWithoutContext
(
'flattenNameSubdirs'
,
()
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment