Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
579991cb
Unverified
Commit
579991cb
authored
Aug 18, 2023
by
Jason Simmons
Committed by
GitHub
Aug 18, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix the name of the local-engine-host flag in the warning message (#132808)
parent
f68d03f1
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
4 deletions
+4
-4
user_messages.dart
packages/flutter_tools/lib/src/base/user_messages.dart
+1
-1
local_engine_test.dart
...er_tools/test/general.shard/runner/local_engine_test.dart
+3
-3
No files found.
packages/flutter_tools/lib/src/base/user_messages.dart
View file @
579991cb
...
...
@@ -310,7 +310,7 @@ class UserMessages {
'You must specify --local-engine or --local-web-sdk if you are using a locally built engine or web sdk.'
;
// TODO(matanlurey): Make this an error, https://github.com/flutter/flutter/issues/132245.
String
runnerLocalEngineRequiresHostEngine
({
bool
warning
=
false
})
=>
'
${warning ? 'Warning! ' : ''}
You are using a locally built engine (--local-engine) but have not specified --local-
host-engine
.
\n
'
'
${warning ? 'Warning! ' : ''}
You are using a locally built engine (--local-engine) but have not specified --local-
engine-host
.
\n
'
'You may be building with a different engine than the one you are running with. '
'See https://github.com/flutter/flutter/issues/132245 for details (in the future this will become '
'an error).'
;
...
...
packages/flutter_tools/test/general.shard/runner/local_engine_test.dart
View file @
579991cb
...
...
@@ -119,7 +119,7 @@ void main() {
expect
(
logger
.
traceText
,
contains
(
'Local engine source at /arbitrary/engine/src'
));
});
testWithoutContext
(
'works but produces a warning if --local-engine is specified but not --local-
host-engine
'
,
()
async
{
testWithoutContext
(
'works but produces a warning if --local-engine is specified but not --local-
engine-host
'
,
()
async
{
final
FileSystem
fileSystem
=
MemoryFileSystem
.
test
();
final
Directory
localEngine
=
fileSystem
.
directory
(
'
$kArbitraryEngineRoot
/src/out/android_debug_unopt_arm64/'
)
...
...
@@ -142,7 +142,7 @@ void main() {
targetEngine:
'/arbitrary/engine/src/out/android_debug_unopt_arm64'
,
),
);
expect
(
logger
.
statusText
,
contains
(
'Warning! You are using a locally built engine (--local-engine) but have not specified --local-
host-engine
'
));
expect
(
logger
.
statusText
,
contains
(
'Warning! You are using a locally built engine (--local-engine) but have not specified --local-
engine-host
'
));
});
testWithoutContext
(
'fails if --local-engine-host is emitted and treatMissingLocalEngineHostAsFatal is set'
,
()
async
{
...
...
@@ -164,7 +164,7 @@ void main() {
await
expectLater
(
localEngineLocator
.
findEnginePath
(
localEngine:
localEngine
.
path
),
throwsToolExit
(
message:
'You are using a locally built engine (--local-engine) but have not specified --local-
host-engine
'
),
throwsToolExit
(
message:
'You are using a locally built engine (--local-engine) but have not specified --local-
engine-host
'
),
);
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment