Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
56c8e60b
Commit
56c8e60b
authored
Oct 02, 2015
by
Adam Barth
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Detecting just Pan events causes an exception in GestureDetector
Fixes #1320
parent
6fcdb64a
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
45 additions
and
4 deletions
+45
-4
recognizer.dart
packages/flutter/lib/src/gestures/recognizer.dart
+3
-1
gesture_detector.dart
packages/flutter/lib/src/widgets/gesture_detector.dart
+1
-1
fractionally_sized_box_test.dart
packages/unit/test/widget/fractionally_sized_box_test.dart
+3
-1
gesture_detector_test.dart
packages/unit/test/widget/gesture_detector_test.dart
+34
-0
widget_tester.dart
packages/unit/test/widget/widget_tester.dart
+4
-1
No files found.
packages/flutter/lib/src/gestures/recognizer.dart
View file @
56c8e60b
...
...
@@ -12,7 +12,9 @@ import 'package:sky/src/gestures/pointer_router.dart';
export
'package:sky/src/gestures/pointer_router.dart'
show
PointerRouter
;
abstract
class
GestureRecognizer
extends
GestureArenaMember
{
GestureRecognizer
({
PointerRouter
router
})
:
_router
=
router
;
GestureRecognizer
({
PointerRouter
router
})
:
_router
=
router
{
assert
(
_router
!=
null
);
}
PointerRouter
_router
;
...
...
packages/flutter/lib/src/widgets/gesture_detector.dart
View file @
56c8e60b
...
...
@@ -190,7 +190,7 @@ class GestureDetectorState extends State<GestureDetector> {
void
_syncScale
()
{
if
(
config
.
onScaleStart
==
null
&&
config
.
onScaleUpdate
==
null
&&
config
.
onScaleEnd
==
null
)
{
_scale
=
_ensureDisposed
(
_
pan
);
_scale
=
_ensureDisposed
(
_
scale
);
}
else
{
_ensureScale
()
..
onStart
=
config
.
onScaleStart
...
...
packages/unit/test/widget/fractionally_sized_box_test.dart
View file @
56c8e60b
import
'package:sky/rendering.dart'
;
import
'package:sky/widgets.dart'
;
import
'package:test/test.dart'
;
...
...
@@ -29,7 +30,8 @@ void main() {
)
));
expect
(
detectedSize
,
equals
(
const
Size
(
50.0
,
25.0
)));
expect
(
inner
.
currentContext
.
findRenderObject
().
localToGlobal
(
Point
.
origin
),
equals
(
const
Point
(
25.0
,
37.5
)));
RenderBox
box
=
inner
.
currentContext
.
findRenderObject
();
expect
(
box
.
localToGlobal
(
Point
.
origin
),
equals
(
const
Point
(
25.0
,
37.5
)));
});
});
}
packages/unit/test/widget/gesture_detector_test.dart
View file @
56c8e60b
...
...
@@ -88,4 +88,38 @@ void main() {
tester
.
pumpWidget
(
new
Container
());
});
});
test
(
'Pan doesn
\'
t crash'
,
()
{
testWidgets
((
WidgetTester
tester
)
{
bool
didStartPan
=
false
;
Offset
panDelta
;
bool
didEndPan
=
false
;
tester
.
pumpWidget
(
new
GestureDetector
(
onPanStart:
()
{
didStartPan
=
true
;
},
onPanUpdate:
(
Offset
delta
)
{
panDelta
=
delta
;
},
onPanEnd:
(
_
)
{
didEndPan
=
true
;
},
child:
new
Container
()
)
);
expect
(
didStartPan
,
isFalse
);
expect
(
panDelta
,
isNull
);
expect
(
didEndPan
,
isFalse
);
tester
.
scrollAt
(
new
Point
(
10.0
,
10.0
),
new
Offset
(
20.0
,
30.0
));
expect
(
didStartPan
,
isTrue
);
expect
(
panDelta
.
dx
,
20.0
);
expect
(
panDelta
.
dy
,
30.0
);
expect
(
didEndPan
,
isTrue
);
});
});
}
packages/unit/test/widget/widget_tester.dart
View file @
56c8e60b
...
...
@@ -145,7 +145,10 @@ class WidgetTester {
}
void
scroll
(
Element
element
,
Offset
offset
,
{
int
pointer:
1
})
{
Point
startLocation
=
getCenter
(
element
);
scrollAt
(
getCenter
(
element
),
offset
,
pointer:
pointer
);
}
void
scrollAt
(
Point
startLocation
,
Offset
offset
,
{
int
pointer:
1
})
{
Point
endLocation
=
startLocation
+
offset
;
TestPointer
p
=
new
TestPointer
(
pointer
);
// Events for the entire press-drag-release gesture are dispatched
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment