Unverified Commit 56c0002c authored by Jenn Magder's avatar Jenn Magder Committed by GitHub

Adopt FakeProcessManager.empty (#80480)

parent 776ea021
......@@ -60,7 +60,7 @@ void main() {
setUp(() {
flutterVersion = FakeFlutterVersion();
logger = BufferLogger.test();
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
});
testWithoutContext('ValidationMessage equality and hashCode includes contextUrl', () {
......
......@@ -444,7 +444,7 @@ void main() {
FakeStdio mockStdio;
setUp(() {
processManager = FakeProcessManager.list(<FakeCommand>[]);
processManager = FakeProcessManager.empty();
mockStdio = FakeStdio()..stdout.terminalColumns = 80;
});
......
......@@ -39,7 +39,7 @@ void main() {
setUp(() {
fakeCommandRunner = FakeUpgradeCommandRunner();
realCommandRunner = UpgradeCommandRunner();
processManager = FakeProcessManager.list(<FakeCommand>[]);
processManager = FakeProcessManager.empty();
fakeCommandRunner.willHaveUncommittedChanges = false;
fakePlatform = FakePlatform()..environment = Map<String, String>.unmodifiable(<String, String>{
'ENV1': 'irrelevant',
......
......@@ -38,7 +38,7 @@ void main() {
featureFlags: TestFeatureFlags(),
operatingSystemUtils: FakeOperatingSystemUtils(),
),
processManager: FakeProcessManager.list(<FakeCommand>[]),
processManager: FakeProcessManager.empty(),
fileSystem: MemoryFileSystem.test(),
platform: FakePlatform(),
userMessages: UserMessages(),
......@@ -49,7 +49,7 @@ void main() {
});
testWithoutContext('AndroidDevices returns empty device list and diagnostics when adb cannot be run', () async {
final FakeProcessManager fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
final FakeProcessManager fakeProcessManager = FakeProcessManager.empty();
fakeProcessManager.excludedExecutables.add('adb');
final AndroidDevices androidDevices = AndroidDevices(
androidSdk: FakeAndroidSdk(),
......@@ -79,7 +79,7 @@ void main() {
featureFlags: TestFeatureFlags(),
operatingSystemUtils: FakeOperatingSystemUtils(),
),
processManager: FakeProcessManager.list(<FakeCommand>[]),
processManager: FakeProcessManager.empty(),
fileSystem: MemoryFileSystem.test(),
platform: FakePlatform(),
userMessages: UserMessages(),
......
......@@ -47,7 +47,7 @@ void main() {
AndroidSdk androidSdk;
setUp(() {
processManager = FakeProcessManager.list(<FakeCommand>[]);
processManager = FakeProcessManager.empty();
fileSystem = MemoryFileSystem.test();
androidSdk = FakeAndroidSdk();
});
......
......@@ -33,7 +33,7 @@ void main() {
FakeProcessManager processManager;
setUp(() {
processManager = FakeProcessManager.list(<FakeCommand>[]);
processManager = FakeProcessManager.empty();
logger = BufferLogger.test();
testUsage = TestUsage();
fileSystem = MemoryFileSystem.test();
......
......@@ -23,7 +23,7 @@ void main() {
setUp(() {
fileSystem = MemoryFileSystem.test();
processManager = FakeProcessManager.list(<FakeCommand>[]);
processManager = FakeProcessManager.empty();
config = Config.test();
});
......
......@@ -30,7 +30,7 @@ void main() {
setUp(() {
fileSystem = MemoryFileSystem.test();
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
});
testWithoutContext('NoAndroidStudioValidator shows Android Studio as "not available" when not available.', () async {
......
......@@ -527,7 +527,7 @@ Command: /home/android/gradlew assembleRelease
FakeProcessManager fakeProcessManager;
setUp(() {
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
});
testWithoutContext('pattern', () {
......
......@@ -634,7 +634,7 @@ flutter:
setUp(() {
logger = BufferLogger.test();
fs = MemoryFileSystem.test();
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
androidSdk = FakeAndroidSdk();
builder = AndroidGradleBuilder(
logger: logger,
......
......@@ -51,7 +51,7 @@ void main() {
setUp(() async {
sdk = MockitoAndroidSdk();
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
fs = MemoryFileSystem.test();
cache = Cache.test(
processManager: FakeProcessManager.any(),
......
......@@ -187,7 +187,7 @@ void main() {
setUp(() async {
fileSystem = MemoryFileSystem.test();
artifacts = Artifacts.test();
processManager = FakeProcessManager.list(<FakeCommand>[]);
processManager = FakeProcessManager.empty();
snapshotter = AOTSnapshotter(
fileSystem: fileSystem,
logger: BufferLogger.test(),
......
......@@ -21,7 +21,7 @@ void main() {
late FakeProcessManager fakeProcessManager;
setUp(() {
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
});
OperatingSystemUtils createOSUtils(Platform platform) {
......
......@@ -25,7 +25,7 @@ void main() {
ProcessUtils processUtils;
setUp(() {
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
processUtils = ProcessUtils(
processManager: fakeProcessManager,
logger: BufferLogger.test(),
......@@ -114,7 +114,7 @@ void main() {
// MockProcessManager has an implementation of start() that returns the
// result of processFactory.
flakyProcessManager = MockProcessManager();
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
processUtils = ProcessUtils(
processManager: fakeProcessManager,
logger: BufferLogger.test(),
......@@ -258,7 +258,7 @@ void main() {
BufferLogger testLogger;
setUp(() {
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
testLogger = BufferLogger(
terminal: AnsiTerminal(
stdio: FakeStdio(),
......
......@@ -33,7 +33,7 @@ void main() {
setUp(() {
logger = BufferLogger.test();
fileSystem = MemoryFileSystem.test();
processManager = FakeProcessManager.list(<FakeCommand>[]);
processManager = FakeProcessManager.empty();
artifacts = Artifacts.test();
});
......@@ -173,7 +173,7 @@ void main() {
});
testUsingContext('AndroidAot can build provided target platform', () async {
processManager = FakeProcessManager.list(<FakeCommand>[]);
processManager = FakeProcessManager.empty();
final Environment environment = Environment.test(
fileSystem.currentDirectory,
outputDir: fileSystem.directory('out')..createSync(),
......@@ -212,7 +212,7 @@ void main() {
});
testUsingContext('AndroidAot provide code size information.', () async {
processManager = FakeProcessManager.list(<FakeCommand>[]);
processManager = FakeProcessManager.empty();
final Environment environment = Environment.test(
fileSystem.currentDirectory,
outputDir: fileSystem.directory('out')..createSync(),
......@@ -254,7 +254,7 @@ void main() {
});
testUsingContext('kExtraGenSnapshotOptions passes values to gen_snapshot', () async {
processManager = FakeProcessManager.list(<FakeCommand>[]);
processManager = FakeProcessManager.empty();
final Environment environment = Environment.test(
fileSystem.currentDirectory,
outputDir: fileSystem.directory('out')..createSync(),
......@@ -297,7 +297,7 @@ void main() {
});
testUsingContext('--no-strip in kExtraGenSnapshotOptions suppresses --strip gen_snapshot flag', () async {
processManager = FakeProcessManager.list(<FakeCommand>[]);
processManager = FakeProcessManager.empty();
final Environment environment = Environment.test(
fileSystem.currentDirectory,
outputDir: fileSystem.directory('out')..createSync(),
......
......@@ -34,7 +34,7 @@ void main() {
Logger logger;
setUp(() {
processManager = FakeProcessManager.list(<FakeCommand>[]);
processManager = FakeProcessManager.empty();
logger = BufferLogger.test();
artifacts = Artifacts.test();
fileSystem = MemoryFileSystem.test(style: FileSystemStyle.posix);
......
......@@ -49,7 +49,7 @@ void main() {
setUp(() {
fileSystem = MemoryFileSystem.test();
processManager = FakeProcessManager.list(<FakeCommand>[]);
processManager = FakeProcessManager.empty();
logger = BufferLogger.test();
artifacts = Artifacts.test();
environment = Environment.test(
......
......@@ -46,7 +46,7 @@ void main() {
..createSync(recursive: true)
..writeAsStringSync('foo:foo/lib/\n');
globals.fs.currentDirectory.childDirectory('bar').createSync();
processManager = FakeProcessManager.list(<FakeCommand>[]);
processManager = FakeProcessManager.empty();
environment = Environment.test(
globals.fs.currentDirectory,
......
......@@ -43,7 +43,7 @@ void main() {
FakeProcessManager fakeProcessManager;
setUp(() {
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
});
Cache createCache(Platform platform) {
......@@ -907,7 +907,7 @@ void main() {
}, overrides: <Type, Generator>{
Cache: () => cache,
FileSystem: () => memoryFileSystem,
ProcessManager: () => FakeProcessManager.list(<FakeCommand>[]),
ProcessManager: () => FakeProcessManager.empty(),
AndroidSdk: () => null // Android SDK was not located.
});
});
......
......@@ -21,7 +21,7 @@ void main() {
FakeProcessManager fakeProcessManager;
setUp(() {
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
});
setUpAll(() {
......
......@@ -51,7 +51,7 @@ void main() {
testLogger = BufferLogger.test();
frontendServerStdIn = MemoryIOSink();
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
generatorStdoutHandler = StdoutHandler(logger: testLogger, fileSystem: MemoryFileSystem.test());
generatorWithSchemeStdoutHandler = StdoutHandler(logger: testLogger, fileSystem: MemoryFileSystem.test());
generator = DefaultResidentCompiler(
......
......@@ -26,7 +26,7 @@ void main() {
testWithoutContext('checkUpToDate skips pub get if the package config is newer than the pubspec '
'and the current framework version is the same as the last version', () async {
final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[]);
final FakeProcessManager processManager = FakeProcessManager.empty();
final BufferLogger logger = BufferLogger.test();
final MemoryFileSystem fileSystem = MemoryFileSystem.test();
......
......@@ -48,7 +48,7 @@ void main() {
response: const FakeResponse(statusCode: HttpStatus.internalServerError),
),
]),
processManager: FakeProcessManager.list(<FakeCommand>[]),
processManager: FakeProcessManager.empty(),
);
final DevToolsServerAddress address = await launcher.serve();
......@@ -70,7 +70,7 @@ void main() {
response: const FakeResponse(statusCode: HttpStatus.internalServerError),
),
]),
processManager: FakeProcessManager.list(<FakeCommand>[]),
processManager: FakeProcessManager.empty(),
);
final DevToolsServerAddress address = await launcher.serve();
......@@ -86,7 +86,7 @@ void main() {
}),
persistentToolState: persistentToolState,
httpClient: FakeHttpClient.list(<FakeRequest>[]),
processManager: FakeProcessManager.list(<FakeCommand>[]),
processManager: FakeProcessManager.empty(),
);
final DevToolsServerAddress address = await launcher.serve();
......
......@@ -246,7 +246,7 @@ void main() {
final FakeVmServiceHost fakeVmServiceHost = FakeVmServiceHost(requests: <FakeVmServiceRequest>[
getVM,
]);
final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[]);
final FakeProcessManager processManager = FakeProcessManager.empty();
final DriverService driverService = setUpDriverService(processManager: processManager, vmService: fakeVmServiceHost.vmService);
final FakeDevice device = FakeDevice(LaunchResult.succeeded(
observatoryUri: Uri.parse('http://127.0.0.1:63426/1UasC_ihpXY=/'),
......@@ -278,7 +278,7 @@ void main() {
}
),
]);
final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[]);
final FakeProcessManager processManager = FakeProcessManager.empty();
final DriverService driverService = setUpDriverService(processManager: processManager, vmService: fakeVmServiceHost.vmService);
final FakeDevice device = FakeDevice(LaunchResult.succeeded(
observatoryUri: Uri.parse('http://127.0.0.1:63426/1UasC_ihpXY=/'),
......@@ -312,7 +312,7 @@ void main() {
}
)
]);
final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[]);
final FakeProcessManager processManager = FakeProcessManager.empty();
final DriverService driverService = setUpDriverService(processManager: processManager, vmService: fakeVmServiceHost.vmService);
final FakeDevice device = FakeDevice(LaunchResult.failed());
......@@ -336,7 +336,7 @@ void main() {
}
)
]);
final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[]);
final FakeProcessManager processManager = FakeProcessManager.empty();
final DriverService driverService = setUpDriverService(processManager: processManager, vmService: fakeVmServiceHost.vmService);
final FakeDevice device = FakeDevice(LaunchResult.failed());
......@@ -354,7 +354,7 @@ void main() {
final FakeVmServiceHost fakeVmServiceHost = FakeVmServiceHost(requests: <FakeVmServiceRequest>[
getVM,
]);
final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[]);
final FakeProcessManager processManager = FakeProcessManager.empty();
final DriverService driverService = setUpDriverService(processManager: processManager, vmService: fakeVmServiceHost.vmService);
final FakeDevice device = FakeDevice(LaunchResult.failed(), supportsFlutterExit: false);
......
......@@ -51,7 +51,7 @@ void main() {
setUp(() {
fileSystem = MemoryFileSystem.test();
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
mockSdk = MockAndroidSdk();
xcode = Xcode.test(processManager: fakeProcessManager, fileSystem: fileSystem);
......
......@@ -54,7 +54,7 @@ void main() {
group('The FLUTTER_TEST environment variable is passed to the test process', () {
setUp(() {
processManager = FakeProcessManager.list(<FakeCommand>[]);
processManager = FakeProcessManager.empty();
device = createDevice();
fileSystem
......
......@@ -90,7 +90,7 @@ void main() {
artifacts: Artifacts.test(),
fileSystem: MemoryFileSystem.test(),
operatingSystemUtils: FakeOperatingSystemUtils(name: 'Windows'),
processManager: FakeProcessManager.list(<FakeCommand>[]),
processManager: FakeProcessManager.empty(),
flutterRoot: () => 'sdk/flutter',
);
......@@ -111,7 +111,7 @@ void main() {
artifacts: Artifacts.test(),
fileSystem: MemoryFileSystem.test(),
operatingSystemUtils: FakeOperatingSystemUtils(name: 'Windows'),
processManager: FakeProcessManager.list(<FakeCommand>[]),
processManager: FakeProcessManager.empty(),
flutterRoot: () => 'sdk/flutter',
);
......
......@@ -31,7 +31,7 @@ void main() {
String ideviceSyslogPath;
setUp(() {
processManager = FakeProcessManager.list(<FakeCommand>[]);
processManager = FakeProcessManager.empty();
fakeCache = Cache.test(processManager: FakeProcessManager.any());
artifacts = Artifacts.test();
logger = BufferLogger.test();
......
......@@ -88,7 +88,7 @@ void main() {
setUp(() {
logger = BufferLogger.test();
fileSystem = MemoryFileSystem.test();
processManager = FakeProcessManager.list(<FakeCommand>[]);
processManager = FakeProcessManager.empty();
mockXcodeProjectInterpreter = MockXcodeProjectInterpreter();
when(mockXcodeProjectInterpreter.isInstalled).thenReturn(true);
......
......@@ -49,7 +49,7 @@ void main() {
File outputFile;
setUp(() {
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
outputFile = MemoryFileSystem.test().file('image.png');
});
......
......@@ -380,7 +380,7 @@ void main() {
MockSimControl mockSimControl;
setUp(() {
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
mockSimControl = MockSimControl();
});
......@@ -486,7 +486,7 @@ void main() {
Xcode xcode;
setUp(() {
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
mockIosProject = FakeIosProject();
mockSimControl = MockSimControl();
xcode = Xcode.test(processManager: FakeProcessManager.any());
......@@ -717,7 +717,7 @@ Dec 20 17:04:32 md32-11-vm1 Another App[88374]: Ignore this text'''
const String appId = 'flutterApp';
setUp(() {
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
xcode = Xcode.test(processManager: FakeProcessManager.any());
simControl = SimControl(
logger: BufferLogger.test(),
......
......@@ -90,7 +90,7 @@ void main() {
BufferLogger logger;
setUp(() {
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
platform = FakePlatform(operatingSystem: 'macos');
fileSystem = MemoryFileSystem.test();
fileSystem.file(xcodebuild).createSync(recursive: true);
......
......@@ -68,7 +68,7 @@ void main() {
setUp(() async {
Cache.flutterRoot = 'flutter';
fileSystem = MemoryFileSystem.test();
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
logger = BufferLogger.test();
usage = TestUsage();
cocoaPodsUnderTest = CocoaPods(
......
......@@ -33,7 +33,7 @@ void main() {
FakeProcessManager fakeProcessManager;
setUp(() {
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
});
group('Xcode', () {
......
......@@ -100,7 +100,7 @@ void main() {
testWithoutContext('Can use devtools with existing devtools URI', () async {
final DevtoolsServerLauncher launcher = DevtoolsServerLauncher(
processManager: FakeProcessManager.list(<FakeCommand>[]),
processManager: FakeProcessManager.empty(),
pubExecutable: 'pub',
logger: BufferLogger.test(),
platform: FakePlatform(),
......
......@@ -92,7 +92,7 @@ void main() {
setUp(() {
buildSystem = TestBuildSystem.all(BuildResult(success: true));
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
device = FlutterTesterDevice('flutter-tester',
fileSystem: fileSystem,
processManager: fakeProcessManager,
......
......@@ -32,7 +32,7 @@ void main() {
FakeProcessManager processManager;
setUp(() {
processManager = FakeProcessManager.list(<FakeCommand>[]);
processManager = FakeProcessManager.empty();
mockProcessManager = MockProcessManager();
mockCache = MockCache();
});
......
......@@ -44,7 +44,7 @@ void main() {
kChromeEnvironment: 'example_chrome',
});
fileSystem = MemoryFileSystem.test(opHandle: exceptionHandler.opHandle);
processManager = FakeProcessManager.list(<FakeCommand>[]);
processManager = FakeProcessManager.empty();
chromeLauncher = ChromiumLauncher(
fileSystem: fileSystem,
platform: platform,
......
......@@ -125,7 +125,7 @@ void main() {
});
testWithoutContext('Chrome device is not listed when Chrome cannot be run', () async {
final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[]);
final FakeProcessManager processManager = FakeProcessManager.empty();
processManager.excludedExecutables = <String>{kLinuxExecutable};
final WebDevices webDevices = WebDevices(
featureFlags: TestFeatureFlags(isWebEnabled: true),
......@@ -256,7 +256,7 @@ void main() {
});
testWithoutContext('Chrome and Edge version check handles missing registry on Windows', () async {
final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[]);
final FakeProcessManager processManager = FakeProcessManager.empty();
processManager.excludedExecutables.add('reg');
final Platform platform = FakePlatform(
......@@ -327,7 +327,7 @@ void main() {
operatingSystem: 'linux',
environment: <String, String>{}
),
processManager: FakeProcessManager.list(<FakeCommand>[]),
processManager: FakeProcessManager.empty(),
);
expect((await webDevices.pollingGetDevices()).whereType<MicrosoftEdgeDevice>(), isEmpty);
......@@ -340,7 +340,7 @@ void main() {
operatingSystem: 'macos',
environment: <String, String>{}
),
processManager: FakeProcessManager.list(<FakeCommand>[]),
processManager: FakeProcessManager.empty(),
);
expect((await macosWebDevices.pollingGetDevices()).whereType<MicrosoftEdgeDevice>(), isEmpty);
......
......@@ -23,7 +23,7 @@ void main() {
setUp(() {
fileSystem = MemoryFileSystem.test();
fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
fakeProcessManager = FakeProcessManager.empty();
platform = FakePlatform(
operatingSystem: 'macos',
environment: <String, String>{},
......
......@@ -300,7 +300,7 @@ ERROR: The system was unable to find the specified registry key or value.
// Create a visual studio instance with a FakeProcessManager.
VisualStudioFixture setUpVisualStudio() {
final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[]);
final FakeProcessManager processManager = FakeProcessManager.empty();
final FileSystem fileSystem = MemoryFileSystem.test(style: FileSystemStyle.windows);
final BufferLogger logger = BufferLogger.test();
final VisualStudio visualStudio = VisualStudio(
......@@ -355,7 +355,7 @@ void main() {
testWithoutContext('isInstalled and cmakePath correct when vswhere is missing', () {
final FileSystem fileSystem = MemoryFileSystem.test(style: FileSystemStyle.windows);
const Exception exception = ProcessException('vswhere', <String>[]);
final FakeProcessManager fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
final FakeProcessManager fakeProcessManager = FakeProcessManager.empty();
setMockCompatibleVisualStudioInstallation(null, fileSystem, fakeProcessManager, null, exception);
setMockCompatibleVisualStudioBuildToolsInstallation(null, fileSystem, fakeProcessManager, null, exception);
......@@ -377,7 +377,7 @@ void main() {
testWithoutContext(
'isInstalled returns false when vswhere returns non-zero', () {
final FileSystem fileSystem = MemoryFileSystem.test(style: FileSystemStyle.windows);
final FakeProcessManager fakeProcessManager = FakeProcessManager.list(<FakeCommand>[]);
final FakeProcessManager fakeProcessManager = FakeProcessManager.empty();
setMockCompatibleVisualStudioInstallation(null, fileSystem, fakeProcessManager, 1);
setMockCompatibleVisualStudioBuildToolsInstallation(null, fileSystem, fakeProcessManager, 1);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment