Revert "fix install checks in flavors devicelab tests" (#133894)

Reverts flutter/flutter#133719

`Windows_android flavors_test_win` failed twice in a row in the tree

dev/devicelab/bin/tasks/flavors_test.dart

@@ -13,10 +13,8 @@ Future<void> main() async {
   await task(() async {
     await createFlavorsTest().call();
     await createIntegrationTestFlavorsTest().call();
-
-    final TaskResult installTestsResult = await inDirectory(
-      '${flutterDirectory.path}/dev/integration_tests/flavors',
-      () async {
+    // test install and uninstall of flavors app
+    await inDirectory('${flutterDirectory.path}/dev/integration_tests/flavors', () async {
       await flutter(
         'install',
         options: <String>['--debug', '--flavor', 'paid'],
@@ -25,7 +23,6 @@ Future<void> main() async {
         'install',
         options: <String>['--debug', '--flavor', 'paid', '--uninstall-only'],
       );
-
       final StringBuffer stderr = StringBuffer();
       await evalFlutter(
         'install',
@@ -35,15 +32,12 @@ Future<void> main() async {
       );
 
       final String stderrString = stderr.toString();
-        if (!stderrString.contains('"build/app/outputs/flutter-apk/app-bogus-release.apk" does not exist.')) {
+      if (!stderrString.contains('The Xcode project defines schemes: free, paid')) {
         print(stderrString);
         return TaskResult.failure('Should not succeed with bogus flavor');
       }
+    });
 
     return TaskResult.success(null);
-      },
-    );
-
-    return installTestsResult;
   });
 }

dev/devicelab/bin/tasks/flavors_test_ios.dart

@@ -14,9 +14,7 @@ Future<void> main() async {
     await createFlavorsTest().call();
     await createIntegrationTestFlavorsTest().call();
     // test install and uninstall of flavors app
-    final TaskResult installTestsResult = await inDirectory(
-      '${flutterDirectory.path}/dev/integration_tests/flavors',
-      () async {
+    await inDirectory('${flutterDirectory.path}/dev/integration_tests/flavors', () async {
       await flutter(
         'install',
         options: <String>['--flavor', 'paid'],
@@ -34,15 +32,12 @@ Future<void> main() async {
       );
 
       final String stderrString = stderr.toString();
-        if (!stderrString.contains('The Xcode project defines schemes: free, paid')) {
+      if (!stderrString.contains('install failed, bogus flavor not found')) {
         print(stderrString);
         return TaskResult.failure('Should not succeed with bogus flavor');
       }
+    });
 
     return TaskResult.success(null);
-      },
-    );
-
-    return installTestsResult;
   });
 }

dev/devicelab/bin/tasks/flavors_test_macos.dart

@@ -14,9 +14,7 @@ Future<void> main() async {
     await createFlavorsTest().call();
     await createIntegrationTestFlavorsTest().call();
 
-    final TaskResult installTestsResult = await inDirectory(
-      '${flutterDirectory.path}/dev/integration_tests/flavors',
-      () async {
+    await inDirectory('${flutterDirectory.path}/dev/integration_tests/flavors', () async {
       final StringBuffer stderr = StringBuffer();
 
       await evalFlutter(
@@ -34,11 +32,8 @@ Future<void> main() async {
         print(stderrString);
         return TaskResult.failure('Installing a macOS app on macOS should no-op');
       }
+    });
 
     return TaskResult.success(null);
-      },
-    );
-
-    return installTestsResult;
   });
 }