Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
560c7228
Unverified
Commit
560c7228
authored
Mar 31, 2020
by
Kate Lovett
Committed by
GitHub
Mar 31, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
TODO Audits - 1 (#53604)
parent
9b6fd7cb
Changes
6
Show whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
4 additions
and
22 deletions
+4
-22
build.gradle
dev/benchmarks/complex_layout/android/app/build.gradle
+0
-8
build.gradle
...benchmarks/platform_views_layout/android/app/build.gradle
+0
-8
stock_data.dart
dev/benchmarks/test_apps/stocks/lib/stock_data.dart
+1
-1
framework.dart
dev/devicelab/lib/framework/framework.dart
+0
-1
running_processes.dart
dev/devicelab/lib/framework/running_processes.dart
+2
-3
manifest.yaml
dev/devicelab/manifest.yaml
+1
-1
No files found.
dev/benchmarks/complex_layout/android/app/build.gradle
View file @
560c7228
...
...
@@ -39,14 +39,6 @@ android {
signingConfig
signingConfigs
.
debug
}
}
aaptOptions
{
// TODO(goderbauer): remove when https://github.com/flutter/flutter/issues/8986 is resolved.
if
(
System
.
getenv
(
"FLUTTER_CI_WIN"
))
{
println
"AAPT cruncher disabled when running on CI, see https://github.com/flutter/flutter/issues/8986"
cruncherEnabled
false
}
}
}
flutter
{
...
...
dev/benchmarks/platform_views_layout/android/app/build.gradle
View file @
560c7228
...
...
@@ -39,14 +39,6 @@ android {
signingConfig
signingConfigs
.
debug
}
}
aaptOptions
{
// TODO(goderbauer): remove when https://github.com/flutter/flutter/issues/8986 is resolved.
if
(
System
.
getenv
(
"FLUTTER_CI_WIN"
))
{
println
"AAPT cruncher disabled when running on CI, see https://github.com/flutter/flutter/issues/8986"
cruncherEnabled
false
}
}
}
flutter
{
...
...
dev/benchmarks/test_apps/stocks/lib/stock_data.dart
View file @
560c7228
...
...
@@ -19,7 +19,7 @@ class Stock {
Stock
(
this
.
symbol
,
this
.
name
,
this
.
lastSale
,
this
.
marketCap
,
this
.
percentChange
);
Stock
.
fromFields
(
List
<
String
>
fields
)
{
//
FIXME
: This class should only have static data, not lastSale, etc.
//
TODO(jackson)
: This class should only have static data, not lastSale, etc.
// "Symbol","Name","LastSale","MarketCap","IPOyear","Sector","industry","Summary Quote",
lastSale
=
0.0
;
try
{
...
...
dev/devicelab/lib/framework/framework.dart
View file @
560c7228
...
...
@@ -97,7 +97,6 @@ class _TaskRunner {
for
(
final
RunningProcessInfo
info
in
afterRunningDartInstances
)
{
if
(!
beforeRunningDartInstances
.
contains
(
info
))
{
print
(
'
$info
was leaked by this test.'
);
// TODO(dnfield): remove this special casing after https://github.com/flutter/flutter/issues/29141 is resolved.
if
(
result
is
TaskResultCheckProcesses
)
{
result
=
TaskResult
.
failure
(
'This test leaked dart processes'
);
}
...
...
dev/devicelab/lib/framework/running_processes.dart
View file @
560c7228
...
...
@@ -27,7 +27,7 @@ class RunningProcessInfo {
@override
int
get
hashCode
{
// TODO(dnfield): Replace this when Object.hashValues lands
.
// TODO(dnfield): Replace this when Object.hashValues lands
, https://github.com/dart-lang/sdk/issues/11617
int
hash
=
17
;
if
(
pid
!=
null
)
{
hash
=
hash
*
23
+
pid
.
hashCode
;
...
...
@@ -88,8 +88,7 @@ Stream<RunningProcessInfo> windowsRunningProcesses(String processName) async* {
?
'"Get-CimInstance Win32_Process -Filter
\\
"name=
\'
$processName
\'\\
" | Select-Object ProcessId,CreationDate,CommandLine | Format-Table -AutoSize | Out-String -Width 4096"'
:
'"Get-CimInstance Win32_Process | Select-Object ProcessId,CreationDate,CommandLine | Format-Table -AutoSize | Out-String -Width 4096"'
;
// Unfortunately, there doesn't seem to be a good way to get ProcessManager to
// run this. May be a bug in Dart.
// TODO(dnfield): fix this when https://github.com/dart-lang/sdk/issues/36175 is resolved.
// run this.
final
ProcessResult
result
=
await
Process
.
run
(
'powershell -command
$script
'
,
<
String
>[],
...
...
dev/devicelab/manifest.yaml
View file @
560c7228
...
...
@@ -584,7 +584,7 @@ tasks:
stage
:
devicelab_ios
required_agent_capabilities
:
[
"
mac/ios"
]
# TODO(fujino): does not pass on iOS13 https://github.com/flutter/flutter/issues/4
1133
# TODO(fujino): does not pass on iOS13 https://github.com/flutter/flutter/issues/4
3029
# system_debug_ios:
# description: >
# Tests that the Engine correctly initializes the system debugger for debug-mode iOS apps.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment