Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
54a9d652
Unverified
Commit
54a9d652
authored
Feb 19, 2022
by
Zachary Anderson
Committed by
GitHub
Feb 19, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "Reland "Enable caching of CPU samples collected at application startup (#89600)"" (#98803)
parent
c849844f
Changes
7
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
3 additions
and
15 deletions
+3
-15
dds.dart
packages/flutter_tools/lib/src/base/dds.dart
+0
-4
fuchsia_device.dart
packages/flutter_tools/lib/src/fuchsia/fuchsia_device.dart
+0
-1
resident_runner.dart
packages/flutter_tools/lib/src/resident_runner.dart
+0
-1
attach_test.dart
...utter_tools/test/commands.shard/hermetic/attach_test.dart
+0
-1
drive_service_test.dart
...er_tools/test/general.shard/drive/drive_service_test.dart
+0
-1
fuchsia_device_test.dart
...tools/test/general.shard/fuchsia/fuchsia_device_test.dart
+0
-1
resident_runner_test.dart
...lutter_tools/test/general.shard/resident_runner_test.dart
+3
-6
No files found.
packages/flutter_tools/lib/src/base/dds.dart
View file @
54a9d652
...
...
@@ -17,7 +17,6 @@ Future<dds.DartDevelopmentService> Function(
bool
enableAuthCodes
,
bool
ipv6
,
Uri
?
serviceUri
,
List
<
String
>
cachedUserTags
,
})
ddsLauncherCallback
=
dds
.
DartDevelopmentService
.
startDartDevelopmentService
;
/// Helper class to launch a [dds.DartDevelopmentService]. Allows for us to
...
...
@@ -37,7 +36,6 @@ class DartDevelopmentService {
int
?
hostPort
,
bool
?
ipv6
,
bool
?
disableServiceAuthCodes
,
bool
cacheStartupProfile
=
false
,
})
async
{
final
Uri
ddsUri
=
Uri
(
scheme:
'http'
,
...
...
@@ -54,8 +52,6 @@ class DartDevelopmentService {
serviceUri:
ddsUri
,
enableAuthCodes:
disableServiceAuthCodes
!=
true
,
ipv6:
ipv6
==
true
,
// Enables caching of CPU samples collected during application startup.
cachedUserTags:
cacheStartupProfile
?
const
<
String
>[
'AppStartUp'
]
:
const
<
String
>[],
);
unawaited
(
_ddsInstance
?.
done
.
whenComplete
(()
{
if
(!
_completer
.
isCompleted
)
{
...
...
packages/flutter_tools/lib/src/fuchsia/fuchsia_device.dart
View file @
54a9d652
...
...
@@ -63,7 +63,6 @@ Future<void> _kDefaultDartDevelopmentServiceStarter(
ipv6:
true
,
disableServiceAuthCodes:
disableServiceAuthCodes
,
logger:
globals
.
logger
,
cacheStartupProfile:
true
,
);
}
...
...
packages/flutter_tools/lib/src/resident_runner.dart
View file @
54a9d652
...
...
@@ -267,7 +267,6 @@ class FlutterDevice {
ipv6:
ipv6
,
disableServiceAuthCodes:
disableServiceAuthCodes
,
logger:
globals
.
logger
,
cacheStartupProfile:
true
,
);
}
on
dds
.
DartDevelopmentServiceException
catch
(
e
,
st
)
{
if
(!
allowExistingDdsInstance
||
...
...
packages/flutter_tools/test/commands.shard/hermetic/attach_test.dart
View file @
54a9d652
...
...
@@ -798,7 +798,6 @@ class FakeDartDevelopmentService extends Fake implements DartDevelopmentService
int
hostPort
,
bool
ipv6
,
bool
disableServiceAuthCodes
,
bool
cacheStartupProfile
=
false
,
})
async
{}
@override
...
...
packages/flutter_tools/test/general.shard/drive/drive_service_test.dart
View file @
54a9d652
...
...
@@ -590,7 +590,6 @@ class FakeDartDevelopmentService extends Fake implements DartDevelopmentService
int
hostPort
,
bool
ipv6
,
bool
disableServiceAuthCodes
,
bool
cacheStartupProfile
=
false
,
})
async
{
started
=
true
;
}
...
...
packages/flutter_tools/test/general.shard/fuchsia/fuchsia_device_test.dart
View file @
54a9d652
...
...
@@ -944,7 +944,6 @@ class FakeDartDevelopmentService extends Fake implements DartDevelopmentService
int
hostPort
,
bool
ipv6
,
bool
disableServiceAuthCodes
,
bool
cacheStartupProfile
=
false
,
})
async
{}
@override
...
...
packages/flutter_tools/test/general.shard/resident_runner_test.dart
View file @
54a9d652
...
...
@@ -1892,12 +1892,11 @@ flutter:
fakeVmServiceHost
=
FakeVmServiceHost
(
requests:
<
VmServiceExpectation
>[]);
final
FakeDevice
device
=
FakeDevice
()
..
dds
=
DartDevelopmentService
();
ddsLauncherCallback
=
(
Uri
uri
,
{
bool
enableAuthCodes
,
bool
ipv6
,
Uri
serviceUri
,
List
<
String
>
cachedUserTags
})
{
ddsLauncherCallback
=
(
Uri
uri
,
{
bool
enableAuthCodes
,
bool
ipv6
,
Uri
serviceUri
})
{
expect
(
uri
,
Uri
(
scheme:
'foo'
,
host:
'bar'
));
expect
(
enableAuthCodes
,
isTrue
);
expect
(
ipv6
,
isFalse
);
expect
(
serviceUri
,
Uri
(
scheme:
'http'
,
host:
'127.0.0.1'
,
port:
0
));
expect
(
cachedUserTags
,
<
String
>[
'AppStartUp'
]);
throw
FakeDartDevelopmentServiceException
(
message:
'Existing VM service clients prevent DDS from taking control.'
,
);
...
...
@@ -1940,12 +1939,11 @@ flutter:
final
FakeDevice
device
=
FakeDevice
()
..
dds
=
DartDevelopmentService
();
final
Completer
<
void
>
done
=
Completer
<
void
>();
ddsLauncherCallback
=
(
Uri
uri
,
{
bool
enableAuthCodes
,
bool
ipv6
,
Uri
serviceUri
,
List
<
String
>
cachedUserTags
})
async
{
ddsLauncherCallback
=
(
Uri
uri
,
{
bool
enableAuthCodes
,
bool
ipv6
,
Uri
serviceUri
})
async
{
expect
(
uri
,
Uri
(
scheme:
'foo'
,
host:
'bar'
));
expect
(
enableAuthCodes
,
isFalse
);
expect
(
ipv6
,
isTrue
);
expect
(
serviceUri
,
Uri
(
scheme:
'http'
,
host:
'::1'
,
port:
0
));
expect
(
cachedUserTags
,
<
String
>[
'AppStartUp'
]);
done
.
complete
();
return
null
;
};
...
...
@@ -1972,12 +1970,11 @@ flutter:
// See https://github.com/flutter/flutter/issues/72385 for context.
final
FakeDevice
device
=
FakeDevice
()
..
dds
=
DartDevelopmentService
();
ddsLauncherCallback
=
(
Uri
uri
,
{
bool
enableAuthCodes
,
bool
ipv6
,
Uri
serviceUri
,
List
<
String
>
cachedUserTags
})
{
ddsLauncherCallback
=
(
Uri
uri
,
{
bool
enableAuthCodes
,
bool
ipv6
,
Uri
serviceUri
})
{
expect
(
uri
,
Uri
(
scheme:
'foo'
,
host:
'bar'
));
expect
(
enableAuthCodes
,
isTrue
);
expect
(
ipv6
,
isFalse
);
expect
(
serviceUri
,
Uri
(
scheme:
'http'
,
host:
'127.0.0.1'
,
port:
0
));
expect
(
cachedUserTags
,
<
String
>[
'AppStartUp'
]);
throw
FakeDartDevelopmentServiceException
(
message:
'No URI'
);
};
final
TestFlutterDevice
flutterDevice
=
TestFlutterDevice
(
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment