Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
5391447f
Commit
5391447f
authored
Nov 30, 2018
by
Ian Hickson
Committed by
Todd Volkert
Nov 30, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Clarify dart:ui dependencies in foundation library (#24868)
parent
58c8489f
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
1 deletion
+10
-1
README.md
packages/flutter/lib/src/foundation/README.md
+9
-0
profile.dart
packages/flutter/lib/src/foundation/profile.dart
+1
-1
No files found.
packages/flutter/lib/src/foundation/README.md
View file @
5391447f
...
@@ -2,3 +2,12 @@ The rule for packages in this directory is that they can depend on
...
@@ -2,3 +2,12 @@ The rule for packages in this directory is that they can depend on
nothing but core Dart packages. They can't depend on
`dart:ui`
, they
nothing but core Dart packages. They can't depend on
`dart:ui`
, they
can't depend on any
`package:`
, and they can't depend on anything
can't depend on any
`package:`
, and they can't depend on anything
outside this directory.
outside this directory.
Currently they do depend on dart:ui, but only for
`VoidCallback`
and
`hashValues`
(and maybe one day
`hashList`
and
`lerpDouble`
), which
are all intended to be moved out of
`dart:ui`
and into
`dart:core`
.
See also:
*
https://github.com/dart-lang/sdk/issues/27791 (
`VoidCallback`
)
*
https://github.com/dart-lang/sdk/issues/25217 (
`hashValues`
,
`hashList`
, and
`lerpDouble`
)
packages/flutter/lib/src/foundation/profile.dart
View file @
5391447f
...
@@ -2,7 +2,7 @@
...
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// found in the LICENSE file.
import
'dart:ui'
;
import
'dart:ui'
show
VoidCallback
;
/// Whether we've been built in release mode.
/// Whether we've been built in release mode.
const
bool
_kReleaseMode
=
bool
.
fromEnvironment
(
'dart.vm.product'
);
const
bool
_kReleaseMode
=
bool
.
fromEnvironment
(
'dart.vm.product'
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment