Unverified Commit 536de5ed authored by Taha Tesser's avatar Taha Tesser Committed by GitHub

Update `RouteObserver` example and fix an error thrown (#141166)

fixes [`RouteObserver` example throws an error](https://github.com/flutter/flutter/issues/141078)

### Description
This updates the `RouteObserver` example from snippet to Dartpad example and fixes the error when running the code snippet
parent 1f3103e5
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:flutter/material.dart';
/// Flutter code sample for [RouteObserver].
final RouteObserver<ModalRoute<void>> routeObserver = RouteObserver<ModalRoute<void>>();
void main() {
runApp(const RouteObserverApp());
}
class RouteObserverApp extends StatelessWidget {
const RouteObserverApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
navigatorObservers: <NavigatorObserver>[ routeObserver ],
home: const RouteObserverExample(),
);
}
}
class RouteObserverExample extends StatefulWidget {
const RouteObserverExample({super.key});
@override
State<RouteObserverExample> createState() => _RouteObserverExampleState();
}
class _RouteObserverExampleState extends State<RouteObserverExample> with RouteAware {
List<String> log = <String>[];
@override
void didChangeDependencies() {
super.didChangeDependencies();
routeObserver.subscribe(this, ModalRoute.of(context)!);
}
@override
void dispose() {
routeObserver.unsubscribe(this);
super.dispose();
}
@override
void didPush() {
// Route was pushed onto navigator and is now the topmost route.
log.add('didPush');
}
@override
void didPopNext() {
// Covering route was popped off the navigator.
log.add('didPopNext');
}
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: Column(
mainAxisSize: MainAxisSize.min,
children: <Widget>[
Text(
'RouteObserver log:',
style: Theme.of(context).textTheme.headlineSmall,
),
ConstrainedBox(
constraints: const BoxConstraints(maxHeight: 300.0),
child: ListView.builder(
itemCount: log.length,
itemBuilder: (BuildContext context, int index) {
if (log.isEmpty) {
return const SizedBox.shrink();
}
return Text(
log[index],
textAlign: TextAlign.center,
);
},
),
),
OutlinedButton(
onPressed: () {
Navigator.of(context).push<void>(
MaterialPageRoute<void>(
builder: (BuildContext context) => const NextPage(),
),
);
},
child: const Text('Go to next page'),
),
],
),
),
);
}
}
class NextPage extends StatelessWidget {
const NextPage({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: FilledButton(
onPressed: () {
Navigator.of(context).pop();
},
child: const Text('Go back to RouteAware page'),
)
),
);
}
}
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:flutter_api_samples/widgets/routes/route_observer.0.dart' as example;
import 'package:flutter_test/flutter_test.dart';
void main() {
testWidgets('RouteObserver notifies RouteAware widget', (WidgetTester tester) async {
await tester.pumpWidget(
const example.RouteObserverApp(),
);
// Check the initial RouteObserver logs.
expect(find.text('didPush'), findsOneWidget);
// Tap on the button to push a new route.
await tester.tap(find.text('Go to next page'));
await tester.pumpAndSettle();
// Tap on the button to go back to the previous route.
await tester.tap(find.text('Go back to RouteAware page'));
await tester.pumpAndSettle();
// Check the RouteObserver logs after the route is popped.
expect(find.text('didPush'), findsOneWidget);
expect(find.text('didPopNext'), findsOneWidget);
// Tap on the button to push a new route again.
await tester.tap(find.text('Go to next page'));
await tester.pumpAndSettle();
// Tap on the button to go back to the previous route again.
await tester.tap(find.text('Go back to RouteAware page'));
await tester.pumpAndSettle();
// Check the RouteObserver logs after the route is popped again.
expect(find.text('didPush'), findsOneWidget);
expect(find.text('didPopNext'), findsNWidgets(2));
});
}
...@@ -1910,60 +1910,16 @@ abstract class PopupRoute<T> extends ModalRoute<T> { ...@@ -1910,60 +1910,16 @@ abstract class PopupRoute<T> extends ModalRoute<T> {
/// than only specific subtypes. For example, to watch for all [ModalRoute] /// than only specific subtypes. For example, to watch for all [ModalRoute]
/// variants, the `RouteObserver<ModalRoute<dynamic>>` type may be used. /// variants, the `RouteObserver<ModalRoute<dynamic>>` type may be used.
/// ///
/// {@tool snippet} /// {@tool dartpad}
/// /// This example demonstrates how to implement a [RouteObserver] that notifies
/// To make a [StatefulWidget] aware of its current [Route] state, implement /// [RouteAware] widget of changes to the state of their [Route].
/// [RouteAware] in its [State] and subscribe it to a [RouteObserver]:
///
/// ```dart
/// // Register the RouteObserver as a navigation observer.
/// final RouteObserver<ModalRoute<void>> routeObserver = RouteObserver<ModalRoute<void>>();
///
/// void main() {
/// runApp(MaterialApp(
/// home: Container(),
/// navigatorObservers: <RouteObserver<ModalRoute<void>>>[ routeObserver ],
/// ));
/// }
///
/// class RouteAwareWidget extends StatefulWidget {
/// const RouteAwareWidget({super.key});
///
/// @override
/// State<RouteAwareWidget> createState() => RouteAwareWidgetState();
/// }
///
/// // Implement RouteAware in a widget's state and subscribe it to the RouteObserver.
/// class RouteAwareWidgetState extends State<RouteAwareWidget> with RouteAware {
///
/// @override
/// void didChangeDependencies() {
/// super.didChangeDependencies();
/// routeObserver.subscribe(this, ModalRoute.of(context)!);
/// }
///
/// @override
/// void dispose() {
/// routeObserver.unsubscribe(this);
/// super.dispose();
/// }
///
/// @override
/// void didPush() {
/// // Route was pushed onto navigator and is now topmost route.
/// }
///
/// @override
/// void didPopNext() {
/// // Covering route was popped off the navigator.
/// }
///
/// @override
/// Widget build(BuildContext context) => Container();
/// ///
/// } /// ** See code in examples/api/lib/widgets/routes/route_observer.0.dart **
/// ```
/// {@end-tool} /// {@end-tool}
///
/// See also:
/// * [RouteAware], this is used with [RouteObserver] to make a widget aware
/// of changes to the [Navigator]'s session history.
class RouteObserver<R extends Route<dynamic>> extends NavigatorObserver { class RouteObserver<R extends Route<dynamic>> extends NavigatorObserver {
final Map<R, Set<RouteAware>> _listeners = <R, Set<RouteAware>>{}; final Map<R, Set<RouteAware>> _listeners = <R, Set<RouteAware>>{};
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment