Commit 522030bd authored by Adam Barth's avatar Adam Barth

Remove two `flutter analyze` regular expressions

We can work around these in code rather than by post-processing the analyzer
output.
parent 6ffee20b
...@@ -942,6 +942,12 @@ abstract class RenderObject extends AbstractNode implements HitTestTarget { ...@@ -942,6 +942,12 @@ abstract class RenderObject extends AbstractNode implements HitTestTarget {
@override @override
PipelineOwner get owner => super.owner; PipelineOwner get owner => super.owner;
// Workaround for https://github.com/dart-lang/sdk/issues/25232
@override
void attach(PipelineOwner owner) {
super.attach(owner);
}
bool _needsLayout = true; bool _needsLayout = true;
/// Whether this render object's layout information is dirty. /// Whether this render object's layout information is dirty.
bool get needsLayout => _needsLayout; bool get needsLayout => _needsLayout;
......
...@@ -336,6 +336,12 @@ class RenderViewport extends RenderViewportBase with RenderObjectWithChildMixin< ...@@ -336,6 +336,12 @@ class RenderViewport extends RenderViewportBase with RenderObjectWithChildMixin<
return null; return null;
} }
// Workaround for https://github.com/dart-lang/sdk/issues/25232
@override
void applyPaintTransform(RenderBox child, Matrix4 transform) {
super.applyPaintTransform(child, transform);
}
@override @override
bool hitTestChildren(HitTestResult result, { Point position }) { bool hitTestChildren(HitTestResult result, { Point position }) {
if (child != null) { if (child != null) {
...@@ -401,6 +407,12 @@ abstract class RenderVirtualViewport<T extends ContainerBoxParentDataMixin<Rende ...@@ -401,6 +407,12 @@ abstract class RenderVirtualViewport<T extends ContainerBoxParentDataMixin<Rende
@override @override
Rect describeApproximatePaintClip(RenderObject child) => Point.origin & size; Rect describeApproximatePaintClip(RenderObject child) => Point.origin & size;
// Workaround for https://github.com/dart-lang/sdk/issues/25232
@override
void applyPaintTransform(RenderBox child, Matrix4 transform) {
super.applyPaintTransform(child, transform);
}
@override @override
void debugFillDescription(List<String> description) { void debugFillDescription(List<String> description) {
super.debugFillDescription(description); super.debugFillDescription(description);
......
...@@ -346,8 +346,6 @@ class AnalyzeCommand extends FlutterCommand { ...@@ -346,8 +346,6 @@ class AnalyzeCommand extends FlutterCommand {
'Analyzing [${mainFile.path}]...', 'Analyzing [${mainFile.path}]...',
new RegExp('^\\[(hint|error)\\] Unused import \\(${mainFile.path},'), new RegExp('^\\[(hint|error)\\] Unused import \\(${mainFile.path},'),
new RegExp(r'^\[.+\] .+ \(.+/\.pub-cache/.+'), new RegExp(r'^\[.+\] .+ \(.+/\.pub-cache/.+'),
new RegExp('\\[warning\\] Missing concrete implementation of \'RenderObject\\.applyPaintTransform\''), // https://github.com/dart-lang/sdk/issues/25232
new RegExp('\\[warning\\] Missing concrete implementation of \'AbstractNode\\.attach\''), // https://github.com/dart-lang/sdk/issues/25232
new RegExp(r'[0-9]+ (error|warning|hint|lint).+found\.'), new RegExp(r'[0-9]+ (error|warning|hint|lint).+found\.'),
new RegExp(r'^$'), new RegExp(r'^$'),
]; ];
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment