Unverified Commit 51588ab8 authored by Jenn Magder's avatar Jenn Magder Committed by GitHub

Set plugin template minimum Flutter SDK to 2.5 (#89695)

parent 18f8b63e
...@@ -16,7 +16,7 @@ Pod::Spec.new do |s| ...@@ -16,7 +16,7 @@ Pod::Spec.new do |s|
s.source_files = 'Classes/**/*' s.source_files = 'Classes/**/*'
s.public_header_files = 'Classes/**/*.h' s.public_header_files = 'Classes/**/*.h'
s.dependency 'Flutter' s.dependency 'Flutter'
s.platform = :ios, '8.0' s.platform = :ios, '9.0'
# Flutter.framework does not contain a i386 slice. # Flutter.framework does not contain a i386 slice.
s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES', 'EXCLUDED_ARCHS[sdk=iphonesimulator*]' => 'i386' } s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES', 'EXCLUDED_ARCHS[sdk=iphonesimulator*]' => 'i386' }
......
...@@ -15,7 +15,7 @@ Pod::Spec.new do |s| ...@@ -15,7 +15,7 @@ Pod::Spec.new do |s|
s.source = { :path => '.' } s.source = { :path => '.' }
s.source_files = 'Classes/**/*' s.source_files = 'Classes/**/*'
s.dependency 'Flutter' s.dependency 'Flutter'
s.platform = :ios, '8.0' s.platform = :ios, '9.0'
# Flutter.framework does not contain a i386 slice. # Flutter.framework does not contain a i386 slice.
s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES', 'EXCLUDED_ARCHS[sdk=iphonesimulator*]' => 'i386' } s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES', 'EXCLUDED_ARCHS[sdk=iphonesimulator*]' => 'i386' }
......
...@@ -5,7 +5,7 @@ homepage: ...@@ -5,7 +5,7 @@ homepage:
environment: environment:
sdk: {{dartSdkVersionBounds}} sdk: {{dartSdkVersionBounds}}
flutter: ">=1.20.0" flutter: ">=2.5.0"
dependencies: dependencies:
flutter: flutter:
......
...@@ -2325,7 +2325,7 @@ void main() { ...@@ -2325,7 +2325,7 @@ void main() {
Logger: () => logger, Logger: () => logger,
}); });
testUsingContext('newly created plugin has min flutter sdk version as 1.20.0', () async { testUsingContext('newly created plugin has min flutter sdk version as 2.5.0', () async {
Cache.flutterRoot = '../..'; Cache.flutterRoot = '../..';
final CreateCommand command = CreateCommand(); final CreateCommand command = CreateCommand();
...@@ -2334,8 +2334,8 @@ void main() { ...@@ -2334,8 +2334,8 @@ void main() {
final String rawPubspec = await projectDir.childFile('pubspec.yaml').readAsString(); final String rawPubspec = await projectDir.childFile('pubspec.yaml').readAsString();
final Pubspec pubspec = Pubspec.parse(rawPubspec); final Pubspec pubspec = Pubspec.parse(rawPubspec);
final Map<String, VersionConstraint> env = pubspec.environment; final Map<String, VersionConstraint> env = pubspec.environment;
expect(env['flutter'].allows(Version(1, 20, 0)), true); expect(env['flutter'].allows(Version(2, 5, 0)), true);
expect(env['flutter'].allows(Version(1, 19, 0)), false); expect(env['flutter'].allows(Version(2, 4, 9)), false);
}); });
testUsingContext('default app uses Android SDK 30', () async { testUsingContext('default app uses Android SDK 30', () async {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment