Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
510c0eea
Unverified
Commit
510c0eea
authored
Aug 25, 2018
by
amirh
Committed by
GitHub
Aug 25, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Don't ignore the ByteData buffer offset in StringCodec.decode(). (#21011)
parent
977da4fb
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
14 additions
and
1 deletion
+14
-1
message_codecs.dart
packages/flutter/lib/src/services/message_codecs.dart
+1
-1
message_codecs_test.dart
packages/flutter/test/services/message_codecs_test.dart
+13
-0
No files found.
packages/flutter/lib/src/services/message_codecs.dart
View file @
510c0eea
...
...
@@ -41,7 +41,7 @@ class StringCodec implements MessageCodec<String> {
String
decodeMessage
(
ByteData
message
)
{
if
(
message
==
null
)
return
null
;
return
utf8
.
decoder
.
convert
(
message
.
buffer
.
asUint8List
());
return
utf8
.
decoder
.
convert
(
message
.
buffer
.
asUint8List
(
message
.
offsetInBytes
,
message
.
lengthInBytes
));
}
@override
...
...
packages/flutter/test/services/message_codecs_test.dart
View file @
510c0eea
...
...
@@ -24,6 +24,19 @@ void main() {
_checkEncodeDecode
<
String
>(
string
,
'hello'
);
_checkEncodeDecode
<
String
>(
string
,
'special chars >
\
u263A
\
u{1F602}<'
);
});
test
(
'ByteData with offset'
,
()
{
const
MessageCodec
<
String
>
string
=
StringCodec
();
final
ByteData
helloWorldByteData
=
string
.
encodeMessage
(
'hello world'
);
final
ByteData
helloByteData
=
string
.
encodeMessage
(
'hello'
);
final
ByteData
offsetByteData
=
new
ByteData
.
view
(
helloWorldByteData
.
buffer
,
helloByteData
.
lengthInBytes
,
helloWorldByteData
.
lengthInBytes
-
helloByteData
.
lengthInBytes
);
expect
(
string
.
decodeMessage
(
offsetByteData
),
' world'
);
});
});
group
(
'JSON message codec'
,
()
{
const
MessageCodec
<
dynamic
>
json
=
JSONMessageCodec
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment