Unverified Commit 4f302dc1 authored by Jason Simmons's avatar Jason Simmons Committed by GitHub

Remove unused no-build flag from the flutter run command (#37735)

The use-application-binary flag can be used to run a previously built
app package.
parent 38e3e109
...@@ -473,7 +473,6 @@ class RunCommand extends RunCommandBase { ...@@ -473,7 +473,6 @@ class RunCommand extends RunCommandBase {
final int result = await runner.run( final int result = await runner.run(
appStartedCompleter: appStartedTimeRecorder, appStartedCompleter: appStartedTimeRecorder,
route: route, route: route,
shouldBuild: !runningWithPrebuiltApplication && argResults['build'],
); );
if (result != 0) { if (result != 0) {
throwToolExit(null, exitCode: result); throwToolExit(null, exitCode: result);
......
...@@ -350,7 +350,6 @@ class FlutterDevice { ...@@ -350,7 +350,6 @@ class FlutterDevice {
Future<int> runHot({ Future<int> runHot({
HotRunner hotRunner, HotRunner hotRunner,
String route, String route,
bool shouldBuild,
}) async { }) async {
final bool prebuiltMode = hotRunner.applicationBinary != null; final bool prebuiltMode = hotRunner.applicationBinary != null;
final String modeName = hotRunner.debuggingOptions.buildInfo.friendlyModeName; final String modeName = hotRunner.debuggingOptions.buildInfo.friendlyModeName;
...@@ -406,7 +405,6 @@ class FlutterDevice { ...@@ -406,7 +405,6 @@ class FlutterDevice {
Future<int> runCold({ Future<int> runCold({
ColdRunner coldRunner, ColdRunner coldRunner,
String route, String route,
bool shouldBuild = true,
}) async { }) async {
final TargetPlatform targetPlatform = await device.targetPlatform; final TargetPlatform targetPlatform = await device.targetPlatform;
package = await ApplicationPackageFactory.instance.getPackageForPlatform( package = await ApplicationPackageFactory.instance.getPackageForPlatform(
...@@ -623,7 +621,6 @@ abstract class ResidentRunner { ...@@ -623,7 +621,6 @@ abstract class ResidentRunner {
Completer<DebugConnectionInfo> connectionInfoCompleter, Completer<DebugConnectionInfo> connectionInfoCompleter,
Completer<void> appStartedCompleter, Completer<void> appStartedCompleter,
String route, String route,
bool shouldBuild = true,
}); });
Future<int> attach({ Future<int> attach({
......
...@@ -110,7 +110,6 @@ class ResidentWebRunner extends ResidentRunner { ...@@ -110,7 +110,6 @@ class ResidentWebRunner extends ResidentRunner {
Completer<DebugConnectionInfo> connectionInfoCompleter, Completer<DebugConnectionInfo> connectionInfoCompleter,
Completer<void> appStartedCompleter, Completer<void> appStartedCompleter,
String route, String route,
bool shouldBuild = true,
}) async { }) async {
final ApplicationPackage package = await ApplicationPackageFactory.instance.getPackageForPlatform( final ApplicationPackage package = await ApplicationPackageFactory.instance.getPackageForPlatform(
TargetPlatform.web_javascript, TargetPlatform.web_javascript,
......
...@@ -49,7 +49,6 @@ class ColdRunner extends ResidentRunner { ...@@ -49,7 +49,6 @@ class ColdRunner extends ResidentRunner {
Completer<DebugConnectionInfo> connectionInfoCompleter, Completer<DebugConnectionInfo> connectionInfoCompleter,
Completer<void> appStartedCompleter, Completer<void> appStartedCompleter,
String route, String route,
bool shouldBuild = true,
}) async { }) async {
final bool prebuiltMode = applicationBinary != null; final bool prebuiltMode = applicationBinary != null;
if (!prebuiltMode) { if (!prebuiltMode) {
...@@ -66,7 +65,6 @@ class ColdRunner extends ResidentRunner { ...@@ -66,7 +65,6 @@ class ColdRunner extends ResidentRunner {
final int result = await device.runCold( final int result = await device.runCold(
coldRunner: this, coldRunner: this,
route: route, route: route,
shouldBuild: shouldBuild,
); );
if (result != 0) if (result != 0)
return result; return result;
......
...@@ -238,7 +238,6 @@ class HotRunner extends ResidentRunner { ...@@ -238,7 +238,6 @@ class HotRunner extends ResidentRunner {
Completer<DebugConnectionInfo> connectionInfoCompleter, Completer<DebugConnectionInfo> connectionInfoCompleter,
Completer<void> appStartedCompleter, Completer<void> appStartedCompleter,
String route, String route,
bool shouldBuild = true,
}) async { }) async {
if (!fs.isFileSync(mainPath)) { if (!fs.isFileSync(mainPath)) {
String message = 'Tried to run $mainPath, but that file does not exist.'; String message = 'Tried to run $mainPath, but that file does not exist.';
...@@ -254,7 +253,6 @@ class HotRunner extends ResidentRunner { ...@@ -254,7 +253,6 @@ class HotRunner extends ResidentRunner {
final int result = await device.runHot( final int result = await device.runHot(
hotRunner: this, hotRunner: this,
route: route, route: route,
shouldBuild: shouldBuild,
); );
if (result != 0) { if (result != 0) {
return result; return result;
......
...@@ -416,7 +416,6 @@ class TestRunner extends ResidentRunner { ...@@ -416,7 +416,6 @@ class TestRunner extends ResidentRunner {
Completer<DebugConnectionInfo> connectionInfoCompleter, Completer<DebugConnectionInfo> connectionInfoCompleter,
Completer<void> appStartedCompleter, Completer<void> appStartedCompleter,
String route, String route,
bool shouldBuild = true,
}) async => null; }) async => null;
@override @override
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment