Commit 4dcb64a9 authored by Rafael Weinstein's avatar Rafael Weinstein

Effen: willUmount->didUnmount, allow setState after didUnmount

This patch changes the timing of the unmount call until after the component is removed (and marked as such) and allows setState to be called after this point. If this happens, setState will still invoke the closer to do any neccesary cleanup, but doesn't schedule the component for render

R=eseidel@chromium.org, eseidel
BUG=

Review URL: https://codereview.chromium.org/985853002
parent 196fd752
...@@ -64,7 +64,7 @@ abstract class FixedHeightScrollable extends Component { ...@@ -64,7 +64,7 @@ abstract class FixedHeightScrollable extends Component {
..events.listen('wheel', _handleWheel); ..events.listen('wheel', _handleWheel);
} }
void willUnmount() { void didUnmount() {
_stopFling(); _stopFling();
} }
......
...@@ -61,7 +61,7 @@ abstract class MaterialComponent extends Component { ...@@ -61,7 +61,7 @@ abstract class MaterialComponent extends Component {
}); });
} }
void willUnmount() { void didUnmount() {
_cancelSplashes(null); _cancelSplashes(null);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment