Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
4d0fd4f8
Unverified
Commit
4d0fd4f8
authored
Jul 14, 2022
by
Jim Graham
Committed by
GitHub
Jul 14, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix some issues with launching E2E benchmarks and add page delays in textfield benchmarks (#107500)
parent
bf104974
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
17 additions
and
12 deletions
+17
-12
text.dart
dev/benchmarks/macrobenchmarks/lib/src/text.dart
+1
-0
textfield_perf_e2e.dart
dev/benchmarks/macrobenchmarks/test/textfield_perf_e2e.dart
+1
-5
util.dart
dev/benchmarks/macrobenchmarks/test/util.dart
+10
-3
textfield_perf_test.dart
...arks/macrobenchmarks/test_driver/textfield_perf_test.dart
+1
-0
util.dart
dev/benchmarks/macrobenchmarks/test_driver/util.dart
+4
-4
No files found.
dev/benchmarks/macrobenchmarks/lib/src/text.dart
View file @
4d0fd4f8
...
@@ -11,6 +11,7 @@ class TextPage extends StatelessWidget {
...
@@ -11,6 +11,7 @@ class TextPage extends StatelessWidget {
Widget
build
(
BuildContext
context
)
{
Widget
build
(
BuildContext
context
)
{
return
Material
(
return
Material
(
child:
Column
(
child:
Column
(
mainAxisAlignment:
MainAxisAlignment
.
center
,
children:
const
<
Widget
>[
children:
const
<
Widget
>[
SizedBox
(
SizedBox
(
width:
200
,
width:
200
,
...
...
dev/benchmarks/macrobenchmarks/test/textfield_perf_e2e.dart
View file @
4d0fd4f8
...
@@ -12,11 +12,7 @@ void main() {
...
@@ -12,11 +12,7 @@ void main() {
macroPerfTestE2E
(
macroPerfTestE2E
(
'textfield_perf'
,
'textfield_perf'
,
kTextRouteName
,
kTextRouteName
,
// The driver version doesn't have this delay because the delay caused
pageDelay:
const
Duration
(
seconds:
1
),
// by the communication between the host and the test device is long enough
// for the driver test, but there isn't such delay in this host independent
// test.
pageDelay:
const
Duration
(
milliseconds:
50
),
body:
(
WidgetController
controller
)
async
{
body:
(
WidgetController
controller
)
async
{
final
Finder
textfield
=
find
.
byKey
(
const
ValueKey
<
String
>(
'basic-textfield'
));
final
Finder
textfield
=
find
.
byKey
(
const
ValueKey
<
String
>(
'basic-textfield'
));
controller
.
tap
(
textfield
);
controller
.
tap
(
textfield
);
...
...
dev/benchmarks/macrobenchmarks/test/util.dart
View file @
4d0fd4f8
...
@@ -25,9 +25,16 @@ void macroPerfTestE2E(
...
@@ -25,9 +25,16 @@ void macroPerfTestE2E(
ControlCallback
?
body
,
ControlCallback
?
body
,
ControlCallback
?
setup
,
ControlCallback
?
setup
,
})
{
})
{
macroPerfTestMultiPageE2E
(
testName
,
<
ScrollableButtonRoute
>[
macroPerfTestMultiPageE2E
(
ScrollableButtonRoute
(
kScrollableName
,
routeName
),
testName
,
]);
<
ScrollableButtonRoute
>[
ScrollableButtonRoute
(
kScrollableName
,
routeName
),
],
pageDelay:
pageDelay
,
duration:
duration
,
body:
body
,
setup:
setup
,
);
}
}
void
macroPerfTestMultiPageE2E
(
void
macroPerfTestMultiPageE2E
(
...
...
dev/benchmarks/macrobenchmarks/test_driver/textfield_perf_test.dart
View file @
4d0fd4f8
...
@@ -11,6 +11,7 @@ void main() {
...
@@ -11,6 +11,7 @@ void main() {
macroPerfTest
(
macroPerfTest
(
'textfield_perf'
,
'textfield_perf'
,
kTextRouteName
,
kTextRouteName
,
pageDelay:
const
Duration
(
seconds:
1
),
driverOps:
(
FlutterDriver
driver
)
async
{
driverOps:
(
FlutterDriver
driver
)
async
{
final
SerializableFinder
textfield
=
find
.
byValueKey
(
'basic-textfield'
);
final
SerializableFinder
textfield
=
find
.
byValueKey
(
'basic-textfield'
);
driver
.
tap
(
textfield
);
driver
.
tap
(
textfield
);
...
...
dev/benchmarks/macrobenchmarks/test_driver/util.dart
View file @
4d0fd4f8
...
@@ -52,10 +52,10 @@ void macroPerfTest(
...
@@ -52,10 +52,10 @@ void macroPerfTest(
}
}
timeline
=
await
driver
.
traceAction
(()
async
{
timeline
=
await
driver
.
traceAction
(()
async
{
final
Future
<
void
>
durationFuture
=
Future
<
void
>.
delayed
(
duration
);
final
Future
<
void
>
durationFuture
=
Future
<
void
>.
delayed
(
duration
);
if
(
driverOps
!=
null
)
{
if
(
driverOps
!=
null
)
{
await
driverOps
(
driver
);
await
driverOps
(
driver
);
}
}
await
durationFuture
;
await
durationFuture
;
});
});
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment