Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
4d0debd4
Commit
4d0debd4
authored
Aug 22, 2017
by
Devon Carew
Committed by
GitHub
Aug 22, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix some call sites of printError (#11724)
* fix some call sites of printError * review comments
parent
5f9acc41
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
7 deletions
+7
-7
resident_runner.dart
packages/flutter_tools/lib/src/resident_runner.dart
+2
-2
run_cold.dart
packages/flutter_tools/lib/src/run_cold.dart
+1
-1
services.dart
packages/flutter_tools/lib/src/services.dart
+4
-4
No files found.
packages/flutter_tools/lib/src/resident_runner.dart
View file @
4d0debd4
...
...
@@ -468,7 +468,7 @@ abstract class ResidentRunner {
await
view
.
uiIsolate
.
flutterDebugAllowBanner
(
false
);
}
catch
(
error
)
{
status
.
stop
();
printError
(
error
);
printError
(
'Error communicating with Flutter on the device:
$error
'
);
}
}
try
{
...
...
@@ -480,7 +480,7 @@ abstract class ResidentRunner {
await
view
.
uiIsolate
.
flutterDebugAllowBanner
(
true
);
}
catch
(
error
)
{
status
.
stop
();
printError
(
error
);
printError
(
'Error communicating with Flutter on the device:
$error
'
);
}
}
}
...
...
packages/flutter_tools/lib/src/run_cold.dart
View file @
4d0debd4
...
...
@@ -88,7 +88,7 @@ class ColdRunner extends ResidentRunner {
try
{
await
downloadStartupTrace
(
device
.
vmServices
.
first
);
}
catch
(
error
)
{
printError
(
error
);
printError
(
'Error downloading startup trace:
$error
'
);
return
2
;
}
}
...
...
packages/flutter_tools/lib/src/services.dart
View file @
4d0debd4
...
...
@@ -31,8 +31,8 @@ Future<Null> parseServiceConfigs(
Map
<
String
,
Uri
>
packageMap
;
try
{
packageMap
=
new
PackageMap
(
PackageMap
.
globalPackagesPath
).
map
;
}
on
FormatException
catch
(
e
)
{
printTrace
(
'Invalid ".packages" file while parsing service configs:
\n
$e
'
);
}
on
FormatException
catch
(
error
)
{
printTrace
(
'Invalid ".packages" file while parsing service configs:
\n
$e
rror
'
);
return
;
}
...
...
@@ -40,9 +40,9 @@ Future<Null> parseServiceConfigs(
try
{
manifest
=
_loadYamlFile
(
_kFlutterManifestPath
);
manifest
=
manifest
[
'flutter'
];
}
catch
(
e
)
{
}
catch
(
e
rror
)
{
printStatus
(
'Error detected in pubspec.yaml:'
,
emphasis:
true
);
printError
(
e
);
printError
(
'
$error
'
);
return
;
}
if
(
manifest
==
null
||
manifest
[
'services'
]
==
null
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment