Unverified Commit 49900477 authored by Todd Volkert's avatar Todd Volkert Committed by GitHub

Revert "Add Form.onSaved (#30643)" (#30793)

This reverts commit 949023b2.
parent f34c2ef0
...@@ -72,7 +72,6 @@ class Form extends StatefulWidget { ...@@ -72,7 +72,6 @@ class Form extends StatefulWidget {
this.autovalidate = false, this.autovalidate = false,
this.onWillPop, this.onWillPop,
this.onChanged, this.onChanged,
this.onSaved,
}) : assert(child != null), }) : assert(child != null),
super(key: key); super(key: key);
...@@ -119,13 +118,6 @@ class Form extends StatefulWidget { ...@@ -119,13 +118,6 @@ class Form extends StatefulWidget {
/// will rebuild. /// will rebuild.
final VoidCallback onChanged; final VoidCallback onChanged;
/// Called when the form is saved (after all the form fields have been saved).
///
/// See also:
///
/// * [FormState.save]
final VoidCallback onSaved;
@override @override
FormState createState() => FormState(); FormState createState() => FormState();
} }
...@@ -180,8 +172,6 @@ class FormState extends State<Form> { ...@@ -180,8 +172,6 @@ class FormState extends State<Form> {
void save() { void save() {
for (FormFieldState<dynamic> field in _fields) for (FormFieldState<dynamic> field in _fields)
field.save(); field.save();
if (widget.onSaved != null)
widget.onSaved();
} }
/// Resets every [FormField] that is a descendant of this [Form] back to its /// Resets every [FormField] that is a descendant of this [Form] back to its
......
...@@ -6,10 +6,9 @@ import 'package:flutter_test/flutter_test.dart'; ...@@ -6,10 +6,9 @@ import 'package:flutter_test/flutter_test.dart';
import 'package:flutter/material.dart'; import 'package:flutter/material.dart';
void main() { void main() {
testWidgets('onSaved callbacks are called', (WidgetTester tester) async { testWidgets('onSaved callback is called', (WidgetTester tester) async {
final GlobalKey<FormState> formKey = GlobalKey<FormState>(); final GlobalKey<FormState> formKey = GlobalKey<FormState>();
String fieldValue; String fieldValue;
bool fieldModifiedSinceFormOnSaved;
Widget builder() { Widget builder() {
return MediaQuery( return MediaQuery(
...@@ -20,12 +19,8 @@ void main() { ...@@ -20,12 +19,8 @@ void main() {
child: Material( child: Material(
child: Form( child: Form(
key: formKey, key: formKey,
onSaved: () { fieldModifiedSinceFormOnSaved = false; },
child: TextFormField( child: TextFormField(
onSaved: (String value) { onSaved: (String value) { fieldValue = value; },
fieldValue = value;
fieldModifiedSinceFormOnSaved = true;
},
), ),
), ),
), ),
...@@ -43,7 +38,6 @@ void main() { ...@@ -43,7 +38,6 @@ void main() {
formKey.currentState.save(); formKey.currentState.save();
// pump'ing is unnecessary because callback happens regardless of frames // pump'ing is unnecessary because callback happens regardless of frames
expect(fieldValue, equals(testValue)); expect(fieldValue, equals(testValue));
expect(fieldModifiedSinceFormOnSaved, isFalse);
} }
await checkText('Test'); await checkText('Test');
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment