Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
4889064f
Unverified
Commit
4889064f
authored
Sep 17, 2021
by
Kate Lovett
Committed by
GitHub
Sep 17, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix the fix (#90217)
parent
a8a27635
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
8 additions
and
64 deletions
+8
-64
fix_data.yaml
packages/flutter/lib/fix_data.yaml
+0
-64
material.dart
packages/flutter/test_fixes/material.dart
+4
-0
material.dart.expect
packages/flutter/test_fixes/material.dart.expect
+4
-0
No files found.
packages/flutter/lib/fix_data.yaml
View file @
4889064f
...
@@ -2162,22 +2162,6 @@ transforms:
...
@@ -2162,22 +2162,6 @@ transforms:
name
:
'
FloatingLabelBehavior'
name
:
'
FloatingLabelBehavior'
-
kind
:
'
removeParameter'
-
kind
:
'
removeParameter'
name
:
'
hasFloatingPlaceholder'
name
:
'
hasFloatingPlaceholder'
-
if
:
"
hasFloatingPlaceholder
!=
'true'
&&
hasFloatingPlaceholder
!=
'false'"
changes
:
-
kind
:
'
addParameter'
index
:
14
name
:
'
floatingLabelBehavior'
style
:
optional_named
argumentValue
:
expression
:
'
{%
hasFloatingPlaceholder
%}
?
{%
FloatingLabelBehavior
%}.auto
:
{%
FloatingLabelBehavior
%}.never'
requiredIf
:
"
hasFloatingPlaceholder
!=
'true'
&&
hasFloatingPlaceholder
!=
'false'"
variables
:
FloatingLabelBehavior
:
kind
:
'
import'
uris
:
[
'
material.dart'
]
name
:
'
FloatingLabelBehavior'
-
kind
:
'
removeParameter'
name
:
'
hasFloatingPlaceholder'
variables
:
variables
:
hasFloatingPlaceholder
:
hasFloatingPlaceholder
:
kind
:
'
fragment'
kind
:
'
fragment'
...
@@ -2223,22 +2207,6 @@ transforms:
...
@@ -2223,22 +2207,6 @@ transforms:
name
:
'
FloatingLabelBehavior'
name
:
'
FloatingLabelBehavior'
-
kind
:
'
removeParameter'
-
kind
:
'
removeParameter'
name
:
'
hasFloatingPlaceholder'
name
:
'
hasFloatingPlaceholder'
-
if
:
"
hasFloatingPlaceholder
!=
'true'
&&
hasFloatingPlaceholder
!=
'false'"
changes
:
-
kind
:
'
addParameter'
index
:
14
name
:
'
floatingLabelBehavior'
style
:
optional_named
argumentValue
:
expression
:
'
{%
hasFloatingPlaceholder
%}
?
{%
FloatingLabelBehavior
%}.auto
:
{%
FloatingLabelBehavior
%}.never'
requiredIf
:
"
hasFloatingPlaceholder
!=
'true'
&&
hasFloatingPlaceholder
!=
'false'"
variables
:
FloatingLabelBehavior
:
kind
:
'
import'
uris
:
[
'
material.dart'
]
name
:
'
FloatingLabelBehavior'
-
kind
:
'
removeParameter'
name
:
'
hasFloatingPlaceholder'
variables
:
variables
:
hasFloatingPlaceholder
:
hasFloatingPlaceholder
:
kind
:
'
fragment'
kind
:
'
fragment'
...
@@ -2295,22 +2263,6 @@ transforms:
...
@@ -2295,22 +2263,6 @@ transforms:
name
:
'
FloatingLabelBehavior'
name
:
'
FloatingLabelBehavior'
-
kind
:
'
removeParameter'
-
kind
:
'
removeParameter'
name
:
'
hasFloatingPlaceholder'
name
:
'
hasFloatingPlaceholder'
-
if
:
"
hasFloatingPlaceholder
!=
'true'
&&
hasFloatingPlaceholder
!=
'false'"
changes
:
-
kind
:
'
addParameter'
index
:
14
name
:
'
floatingLabelBehavior'
style
:
optional_named
argumentValue
:
expression
:
'
{%
hasFloatingPlaceholder
%}
?
{%
FloatingLabelBehavior
%}.auto
:
{%
FloatingLabelBehavior
%}.never'
requiredIf
:
"
hasFloatingPlaceholder
!=
'true'
&&
hasFloatingPlaceholder
!=
'false'"
variables
:
FloatingLabelBehavior
:
kind
:
'
import'
uris
:
[
'
material.dart'
]
name
:
'
FloatingLabelBehavior'
-
kind
:
'
removeParameter'
name
:
'
hasFloatingPlaceholder'
variables
:
variables
:
hasFloatingPlaceholder
:
hasFloatingPlaceholder
:
kind
:
'
fragment'
kind
:
'
fragment'
...
@@ -2356,22 +2308,6 @@ transforms:
...
@@ -2356,22 +2308,6 @@ transforms:
name
:
'
FloatingLabelBehavior'
name
:
'
FloatingLabelBehavior'
-
kind
:
'
removeParameter'
-
kind
:
'
removeParameter'
name
:
'
hasFloatingPlaceholder'
name
:
'
hasFloatingPlaceholder'
-
if
:
"
hasFloatingPlaceholder
!=
'true'
&&
hasFloatingPlaceholder
!=
'false'"
changes
:
-
kind
:
'
addParameter'
index
:
14
name
:
'
floatingLabelBehavior'
style
:
optional_named
argumentValue
:
expression
:
'
{%
hasFloatingPlaceholder
%}
?
{%
FloatingLabelBehavior
%}.auto
:
{%
FloatingLabelBehavior
%}.never'
requiredIf
:
"
hasFloatingPlaceholder
!=
'true'
&&
hasFloatingPlaceholder
!=
'false'"
variables
:
FloatingLabelBehavior
:
kind
:
'
import'
uris
:
[
'
material.dart'
]
name
:
'
FloatingLabelBehavior'
-
kind
:
'
removeParameter'
name
:
'
hasFloatingPlaceholder'
variables
:
variables
:
hasFloatingPlaceholder
:
hasFloatingPlaceholder
:
kind
:
'
fragment'
kind
:
'
fragment'
...
...
packages/flutter/test_fixes/material.dart
View file @
4889064f
...
@@ -189,17 +189,21 @@ void main() {
...
@@ -189,17 +189,21 @@ void main() {
const
InputDecoration
inputDecoration
=
InputDecoration
(
hasFloatingPlaceholder:
true
);
const
InputDecoration
inputDecoration
=
InputDecoration
(
hasFloatingPlaceholder:
true
);
InputDecoration
(
hasFloatingPlaceholder:
false
);
InputDecoration
(
hasFloatingPlaceholder:
false
);
InputDecoration
();
InputDecoration
();
InputDecoration
(
error:
''
);
InputDecoration
.
collapsed
(
hasFloatingPlaceholder:
true
);
InputDecoration
.
collapsed
(
hasFloatingPlaceholder:
true
);
InputDecoration
.
collapsed
(
hasFloatingPlaceholder:
false
);
InputDecoration
.
collapsed
(
hasFloatingPlaceholder:
false
);
InputDecoration
.
collapsed
();
InputDecoration
.
collapsed
();
InputDecoration
.
collapsed
(
error:
''
);
inputDecoration
.
hasFloatingPlaceholder
;
inputDecoration
.
hasFloatingPlaceholder
;
const
InputDecorationTheme
inputDecorationTheme
=
InputDecorationTheme
(
hasFloatingPlaceholder:
true
);
const
InputDecorationTheme
inputDecorationTheme
=
InputDecorationTheme
(
hasFloatingPlaceholder:
true
);
InputDecorationTheme
(
hasFloatingPlaceholder:
false
);
InputDecorationTheme
(
hasFloatingPlaceholder:
false
);
InputDecorationTheme
();
InputDecorationTheme
();
InputDecorationTheme
(
error:
''
);
inputDecorationTheme
.
hasFloatingPlaceholder
;
inputDecorationTheme
.
hasFloatingPlaceholder
;
inputDecorationTheme
.
copyWith
(
hasFloatingPlaceholder:
false
);
inputDecorationTheme
.
copyWith
(
hasFloatingPlaceholder:
false
);
inputDecorationTheme
.
copyWith
(
hasFloatingPlaceholder:
true
);
inputDecorationTheme
.
copyWith
(
hasFloatingPlaceholder:
true
);
inputDecorationTheme
.
copyWith
();
inputDecorationTheme
.
copyWith
();
inputDecorationTheme
.
copyWith
(
error:
''
);
// Changes made in https://github.com/flutter/flutter/pull/66482
// Changes made in https://github.com/flutter/flutter/pull/66482
ThemeData
(
textSelectionColor:
Colors
.
red
);
ThemeData
(
textSelectionColor:
Colors
.
red
);
...
...
packages/flutter/test_fixes/material.dart.expect
View file @
4889064f
...
@@ -190,17 +190,21 @@ void main() {
...
@@ -190,17 +190,21 @@ void main() {
const InputDecoration inputDecoration = InputDecoration(floatingLabelBehavior: FloatingLabelBehavior.auto);
const InputDecoration inputDecoration = InputDecoration(floatingLabelBehavior: FloatingLabelBehavior.auto);
InputDecoration(floatingLabelBehavior: FloatingLabelBehavior.never);
InputDecoration(floatingLabelBehavior: FloatingLabelBehavior.never);
InputDecoration();
InputDecoration();
InputDecoration(error: '');
InputDecoration.collapsed(floatingLabelBehavior: FloatingLabelBehavior.auto);
InputDecoration.collapsed(floatingLabelBehavior: FloatingLabelBehavior.auto);
InputDecoration.collapsed(floatingLabelBehavior: FloatingLabelBehavior.never);
InputDecoration.collapsed(floatingLabelBehavior: FloatingLabelBehavior.never);
InputDecoration.collapsed();
InputDecoration.collapsed();
InputDecoration.collapsed(error: '');
inputDecoration.floatingLabelBehavior;
inputDecoration.floatingLabelBehavior;
const InputDecorationTheme inputDecorationTheme = InputDecorationTheme(floatingLabelBehavior: FloatingLabelBehavior.auto);
const InputDecorationTheme inputDecorationTheme = InputDecorationTheme(floatingLabelBehavior: FloatingLabelBehavior.auto);
InputDecorationTheme(floatingLabelBehavior: FloatingLabelBehavior.never);
InputDecorationTheme(floatingLabelBehavior: FloatingLabelBehavior.never);
InputDecorationTheme();
InputDecorationTheme();
InputDecorationTheme(error: '');
inputDecorationTheme.floatingLabelBehavior;
inputDecorationTheme.floatingLabelBehavior;
inputDecorationTheme.copyWith(floatingLabelBehavior: FloatingLabelBehavior.never);
inputDecorationTheme.copyWith(floatingLabelBehavior: FloatingLabelBehavior.never);
inputDecorationTheme.copyWith(floatingLabelBehavior: FloatingLabelBehavior.auto);
inputDecorationTheme.copyWith(floatingLabelBehavior: FloatingLabelBehavior.auto);
inputDecorationTheme.copyWith();
inputDecorationTheme.copyWith();
inputDecorationTheme.copyWith(error: '');
// Changes made in https://github.com/flutter/flutter/pull/66482
// Changes made in https://github.com/flutter/flutter/pull/66482
ThemeData(textSelectionTheme: TextSelectionThemeData(selectionColor: Colors.red));
ThemeData(textSelectionTheme: TextSelectionThemeData(selectionColor: Colors.red));
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment