Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
48478b59
Unverified
Commit
48478b59
authored
Apr 04, 2018
by
xster
Committed by
GitHub
Apr 04, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove DevToolsSecurity check from initial flutter doctor (#16007)
parent
ae96e81c
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
29 deletions
+1
-29
ios_workflow.dart
packages/flutter_tools/lib/src/ios/ios_workflow.dart
+0
-7
ios_workflow_test.dart
packages/flutter_tools/test/ios/ios_workflow_test.dart
+1
-22
No files found.
packages/flutter_tools/lib/src/ios/ios_workflow.dart
View file @
48478b59
...
...
@@ -94,13 +94,6 @@ class IOSWorkflow extends DoctorValidator implements Workflow {
'Launch Xcode and install additional required components when prompted.'
));
}
if
((
await
macDevMode
).
contains
(
'disabled'
))
{
xcodeStatus
=
ValidationType
.
partial
;
messages
.
add
(
new
ValidationMessage
.
error
(
'Your Mac needs to enabled for developer mode before using Xcode for the first time.
\n
'
'Run
\'
sudo DevToolsSecurity -enable
\'
to enable developer mode.'
));
}
}
else
{
xcodeStatus
=
ValidationType
.
missing
;
...
...
packages/flutter_tools/test/ios/ios_workflow_test.dart
View file @
48478b59
...
...
@@ -111,22 +111,6 @@ void main() {
CocoaPods:
()
=>
cocoaPods
,
});
testUsingContext
(
'Emits partial status when Mac dev mode was never enabled'
,
()
async
{
when
(
xcode
.
isInstalled
).
thenReturn
(
true
);
when
(
xcode
.
versionText
)
.
thenReturn
(
'Xcode 8.2.1
\n
Build version 8C1002
\n
'
);
when
(
xcode
.
isInstalledAndMeetsVersionCheck
).
thenReturn
(
true
);
when
(
xcode
.
eulaSigned
).
thenReturn
(
true
);
when
(
xcode
.
isSimctlInstalled
).
thenReturn
(
true
);
final
IOSWorkflowTestTarget
workflow
=
new
IOSWorkflowTestTarget
(
macDevMode:
'Developer mode is currently disabled.'
);
final
ValidationResult
result
=
await
workflow
.
validate
();
expect
(
result
.
type
,
ValidationType
.
partial
);
},
overrides:
<
Type
,
Generator
>{
IMobileDevice:
()
=>
iMobileDevice
,
Xcode:
()
=>
xcode
,
CocoaPods:
()
=>
cocoaPods
,
});
testUsingContext
(
'Emits partial status when python six not installed'
,
()
async
{
when
(
xcode
.
isInstalled
).
thenReturn
(
true
);
when
(
xcode
.
versionText
)
...
...
@@ -354,11 +338,9 @@ class IOSWorkflowTestTarget extends IOSWorkflow {
bool
hasIosDeploy:
true
,
String
iosDeployVersionText:
'1.9.2'
,
bool
hasIDeviceInstaller:
true
,
String
macDevMode:
'Developer mode is already enabled.'
,
})
:
hasIosDeploy
=
new
Future
<
bool
>.
value
(
hasIosDeploy
),
iosDeployVersionText
=
new
Future
<
String
>.
value
(
iosDeployVersionText
),
hasIDeviceInstaller
=
new
Future
<
bool
>.
value
(
hasIDeviceInstaller
),
macDevMode
=
new
Future
<
String
>.
value
(
macDevMode
);
hasIDeviceInstaller
=
new
Future
<
bool
>.
value
(
hasIDeviceInstaller
);
@override
final
bool
hasPythonSixModule
;
...
...
@@ -374,7 +356,4 @@ class IOSWorkflowTestTarget extends IOSWorkflow {
@override
final
Future
<
bool
>
hasIDeviceInstaller
;
@override
final
Future
<
String
>
macDevMode
;
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment