Change doctor to point at Flutter extension (#17987)

packages/flutter_tools/lib/src/vscode/vscode.dart

@@ -13,7 +13,7 @@ import '../base/version.dart';
 const bool _includeInsiders = false;
 
 class VsCode {
-  static const String extensionIdentifier = 'Dart-Code.dart-code';
+  static const String extensionIdentifier = 'Dart-Code.flutter';
 
   VsCode._(this.directory, this.extensionDirectory, { Version version, this.edition })
       : this.version = version ?? Version.unknown {
@@ -43,7 +43,7 @@ class VsCode {
       _isValid = true;
       _extensionVersion = new Version.parse(
           extensionDir.basename.substring('$extensionIdentifier-'.length));
-      _validationMessages.add('Dart Code extension version $_extensionVersion');
+      _validationMessages.add('Flutter extension version $_extensionVersion');
     }
   }
 
@@ -175,7 +175,7 @@ class VsCode {
 
   @override
   String toString() =>
-      'VS Code ($version)${_extensionVersion != Version.unknown ? ', Dart Code ($_extensionVersion)' : ''}';
+      'VS Code ($version)${_extensionVersion != Version.unknown ? ', Flutter ($_extensionVersion)' : ''}';
 
   static String _getVersionFromPackageJson(String packageJsonPath) {
     if (!fs.isFileSync(packageJsonPath))

packages/flutter_tools/lib/src/vscode/vscode_validator.dart

@@ -10,7 +10,7 @@ import 'vscode.dart';
 
 class VsCodeValidator extends DoctorValidator {
   static const String extensionMarketplaceUrl =
-    'https://marketplace.visualstudio.com/items?itemName=Dart-Code.dart-code';
+    'https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter';
   final VsCode _vsCode;
 
   VsCodeValidator(this._vsCode) : super(_vsCode.productName);
@@ -38,7 +38,7 @@ class VsCodeValidator extends DoctorValidator {
       messages.addAll(_vsCode.validationMessages
           .map((String m) => new ValidationMessage.error(m)));
       messages.add(new ValidationMessage(
-          'Dart Code extension not installed; install from\n$extensionMarketplaceUrl'));
+          'Flutter extension not installed; install from\n$extensionMarketplaceUrl'));
     }
 
     return new ValidationResult(type, messages, statusInfo: vsCodeVersionText);

packages/flutter_tools/test/commands/doctor_test.dart

@@ -46,8 +46,8 @@ void main() {
       expect(message.message, 'VS Code at ${VsCodeValidatorTestTargets.validInstall}');
 
       message = result.messages
-          .firstWhere((ValidationMessage m) => m.message.startsWith('Dart Code '));
-      expect(message.message, 'Dart Code extension version 4.5.6');
+          .firstWhere((ValidationMessage m) => m.message.startsWith('Flutter '));
+      expect(message.message, 'Flutter extension version 4.5.6');
     });
 
     testUsingContext('vs code validator when 64bit installed', () async {
@@ -62,8 +62,8 @@ void main() {
       expect(message.message, 'VS Code at ${VsCodeValidatorTestTargets.validInstall}');
 
       message = result.messages
-          .firstWhere((ValidationMessage m) => m.message.startsWith('Dart Code '));
-      expect(message.message, 'Dart Code extension version 4.5.6');
+          .firstWhere((ValidationMessage m) => m.message.startsWith('Flutter '));
+      expect(message.message, 'Flutter extension version 4.5.6');
     });
 
     testUsingContext('vs code validator when extension missing', () async {
@@ -77,8 +77,8 @@ void main() {
       expect(message.message, 'VS Code at ${VsCodeValidatorTestTargets.validInstall}');
 
       message = result.messages
-          .firstWhere((ValidationMessage m) => m.message.startsWith('Dart Code '));
-      expect(message.message, startsWith('Dart Code extension not installed'));
+          .firstWhere((ValidationMessage m) => m.message.startsWith('Flutter '));
+      expect(message.message, startsWith('Flutter extension not installed'));
     });
   });